[Bug 28204] New: Table highlighting is broken at the cataloguing/additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28204 Bug ID: 28204 Summary: Table highlighting is broken at the cataloguing/additem.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: stalkernoid@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Created attachment 120092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120092&action=edit Look of the table with highlighted row Highlighting is broken at the /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX Every odd row of the table doesn't get highlighted with the yellow color when you try to edit it, meanwhile every even row does get highlighted as supposed to. How to reproduce: 1) Head over to the /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX, where XXXX is id of some bilbio record that has more than one biblio item. 2) Press the "Action" button of the first (or any other odd numbered) biblion item, and from the dropdown menu select "edit" option. 3) Notice that it doesn't highlight it with yellow color. 4) Now do the same but with second biblio item (or any even numbered item). 5) Notice that it highlights it with the yellow color. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28204 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28204 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28204 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28204 --- Comment #1 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 121242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121242&action=edit Bug 28204: Fix table highlighting Fix table highlighting at /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX Every odd row of the table didn't get highlighted with the yellow color when you tried to edit it previously, this patch fixes that. That happened because every odd row had different coloring style that was overwriting yellow highlight. How to reproduce: 1) Head over to the /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX, where XXXX is id of some bilbio record that has more than one biblio item. 2) Press the "Action" button of the first (or any other odd numbered) biblion item, and from the dropdown menu select "edit" option. 3) Notice that it doesn't highlight it with yellow color. 4) Now do the same but with second biblio item (or any even numbered item). 5) Notice that it highlights it with the yellow color. 6) Apply the patch. Do yarn build to compile css. 7) Make sure that every row of the table that you edit gets properly highlighted with the yellow color. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28204 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28204 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121242|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 121333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121333&action=edit Bug 28204: Fix table highlighting Fix table highlighting at /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX Every odd row of the table didn't get highlighted with the yellow color when you tried to edit it previously, this patch fixes that. That happened because every odd row had different coloring style that was overwriting yellow highlight. How to reproduce: 1) Head over to the /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX, where XXXX is id of some bilbio record that has more than one biblio item. 2) Press the "Action" button of the first (or any other odd numbered) biblion item, and from the dropdown menu select "edit" option. 3) Notice that it doesn't highlight it with yellow color. 4) Now do the same but with second biblio item (or any even numbered item). 5) Notice that it highlights it with the yellow color. 6) Apply the patch. Do yarn build to compile css. 7) Make sure that every row of the table that you edit gets properly highlighted with the yellow color. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28204 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121333|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 121334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121334&action=edit Bug 28204: Fix table highlighting Fix table highlighting at /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX Every odd row of the table didn't get highlighted with the yellow color when you tried to edit it previously, this patch fixes that. That happened because every odd row had different coloring style that was overwriting yellow highlight. How to reproduce: 1) Head over to the /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX, where XXXX is id of some bilbio record that has more than one biblio item. 2) Press the "Action" button of the first (or any other odd numbered) biblion item, and from the dropdown menu select "edit" option. 3) Notice that it doesn't highlight it with yellow color. 4) Now do the same but with second biblio item (or any even numbered item). 5) Notice that it highlights it with the yellow color. 6) Apply the patch. Do yarn build to compile css. 7) Make sure that every row of the table that you edit gets properly highlighted with the yellow color. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28204 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- A really odd bug - I can confirm it is fixed by the patch, but laving as NSO as I have asked Owen if he could take a look at the CSS. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28204 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28204 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121334|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 121335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121335&action=edit Bug 28204: Fix table highlighting Fix table highlighting at /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX Every odd row of the table didn't get highlighted with the yellow color when you tried to edit it previously, this patch fixes that. That happened because every odd row had different coloring style that was overwriting yellow highlight. How to reproduce: 1) Head over to the /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX, where XXXX is id of some bilbio record that has more than one biblio item. 2) Press the "Action" button of the first (or any other odd numbered) biblion item, and from the dropdown menu select "edit" option. 3) Notice that it doesn't highlight it with yellow color. 4) Now do the same but with second biblio item (or any even numbered item). 5) Notice that it highlights it with the yellow color. 6) Apply the patch. Do yarn build to compile css. 7) Make sure that every row of the table that you edit gets properly highlighted with the yellow color. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28204 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28204 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121335|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 121336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121336&action=edit Bug 28204: Fix table highlighting Fix table highlighting at /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX Every odd row of the table didn't get highlighted with the yellow color when you tried to edit it previously, this patch fixes that. That happened because every odd row had different coloring style that was overwriting yellow highlight. How to reproduce: 1) Head over to the /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX, where XXXX is id of some bilbio record that has more than one biblio item. 2) Press the "Action" button of the first (or any other odd numbered) biblion item, and from the dropdown menu select "edit" option. 3) Notice that it doesn't highlight it with yellow color. 4) Now do the same but with second biblio item (or any even numbered item). 5) Notice that it highlights it with the yellow color. 6) Apply the patch. Do yarn build to compile css. 7) Make sure that every row of the table that you edit gets properly highlighted with the yellow color. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28204 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Assignee|koha-bugs@lists.koha-commun |stalkernoid@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28204 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121336|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 121626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121626&action=edit Bug 28204: Fix table highlighting on the items table Fix table highlighting at /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX Every odd row of the table didn't get highlighted with the yellow color when you tried to edit it previously, this patch fixes that. That happened because every odd row had different coloring style that was overwriting yellow highlight. How to reproduce: 1) Head over to the /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX, where XXXX is id of some bilbio record that has more than one biblio item. 2) Press the "Action" button of the first (or any other odd numbered) biblion item, and from the dropdown menu select "edit" option. 3) Notice that it doesn't highlight it with yellow color. 4) Now do the same but with second biblio item (or any even numbered item). 5) Notice that it highlights it with the yellow color. 6) Apply the patch. Do yarn build to compile css. 7) Make sure that every row of the table that you edit gets properly highlighted with the yellow color. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> JD Amended commit title -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28204 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28204 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28204 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28204 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.01 released in| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28204 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> ---
3) Notice that it doesn't highlight it with yellow color. Without patch, problem seems not to affect 20.11.x
-- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org