http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Component|Templates |MARC Authority data support AssignedTo|oleonard@myacpl.org |gmcharlt@gmail.com --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-08-15 16:36:22 UTC --- If this is a template error then it's not one I can see either. I'm reclassifying this as an Authorities bug. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8212 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Small note: Bug should remain open after pushing this patch. The problem also still exists on the authority detail page in staff. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10295|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 10297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10297&action=edit [SIGNED-OFF] Bug 6720: show authority type in auth details Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Authority type on detail page in staff now shows correctly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Ian Walls <koha.sekjal@gmail.com> --- Patch 1: adds new template param to get the Auth Type properly, then displays it in the template. Passed QA. Patch 2: replaces an empty string with the actual Auth Type. Marking Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10297|0 |1 is obsolete| | --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 10297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10297 [SIGNED-OFF] Bug 6720: show authority type in auth details This patch has been pushed -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Another signoff for the first patch now that it's been rebased would be super keen. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 --- Comment #14 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #13)

Jared, is http://git.koha-community.org/gitweb/?p=koha.git;a=blobdiff;f=authorities/ detail.pl;h=a7d7d8f21882b7bcace75c5eb862eaebad8dfdeb; hp=d4f2c6730c76f19fb0aeefebdfd7fe5558066eff; hb=f809e47fd1644314bbd63542f3021382eece642f; hpb=f2ca89b30e8d48b987782ff3f9f7c8e8240b87a4

Safe to cherry-pick now, or best to wait until the second patch is pushed to master also?

You can cherry-pick that patch, and cherry-pick the next once it's been pushed to master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 --- Comment #16 from Mirko Tietgen <5p4m@gmx.de> --- Created attachment 10444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10444&action=edit Bug 6720: Display the authority type in OPAC Due to a peculiarity in the way SearchAuthorities worked, the authority search results on the OPAC always listed the authority type that the user searched for, rather than the authority type of the results. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, result list for OPAC search now shows the authority type for each record. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Rebased 20 June 2012. Signed-off-by: Mirko Tietgen <5p4m@gmx.de> Works as expected. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m QA Contact|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: my $thisauthtype = GetAuthType(GetAuthTypeCode($authid)); This line is very scabby. It does 2 selects on the auth_header table. But I don't find an other way to do that in our API. Considering the dirty code into the SearchAuthorities routine, I mark as passed QA this patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 --- Comment #20 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #19)

mmm... the code says: + $newline{authtype} = defined ($thisauthtype) ? + $thisauthtype->{'summary'} : + GetAuthType($authtypecode)->{'summary'};

"summary" is not the authtype description, but how the authority display is built. I tried the patch anyway, and got a -suspected- wrong result:

The "type of heading" column now show: [200a][, 200b][ 200d][ ; 200c][ (200f)]

:\\\

This definitely does not sound right. Follow-up coming shortly. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 --- Comment #21 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 10861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10861&action=edit Bug 6720 follow-up: use authtypetext instead of summary Although auth_types.summary contains a string describing the type of authority in MARC21, it does not in UNIMARC. auth_types.authtypetext contains the proper label in both marcflavours. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 --- Comment #23 from Chris Cormack <chris@bigballofwax.co.nz> --- String changes, held for 3.8.4 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #25 from Paul Poulain <paul.poulain@biblibre.com> --- I think I've found a big problem with this patch. Under certain circumstances (I think it's because zebra & mysql are unsynched, this can happen when you just deleted an authority, and it hasn't been deleted on zebra) I get: Can't use an undefined value as a HASH reference at /home/paul/koha.dev/koha-community/C4/AuthoritiesMarc.pm line 355. at /home/paul/koha.dev/koha-community/authorities/authorities-home.pl line 203 git blame tells me the culprit is here. Investigating a little bit, I see that: + GetAuthType($authtypecode)->{'summary'}; will fail if GetAuthType() returns nothing Changing this line to ( GetAuthType($authtypecode) ? $_->{'authtypetext'}:''); seems to fix the problem. Jared, could you check, confirm & provide a patch, i'll sign it immediately Another problem, maybe not related = the authorities in the list are now displayed HASH(0xb67ed88) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 --- Comment #26 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 11296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11296&action=edit Bug 6720 follow-up: fix error when auth has been deleted Thanks to Paul Poulain for finding the problem and proposing a solution. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #28 from Paul Poulain <paul.poulain@biblibre.com> --- follow-up signed-off, passed QA & pushed in one go -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9277 -- You are receiving this mail because: You are watching all bug changes.