[Bug 16724] New: Link from online help to manual broken (as of version 16.05)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 Bug ID: 16724 Summary: Link from online help to manual broken (as of version 16.05) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org In Koha version 16.05, the links from the online help to koha manual are broken. To reproduce: In staff client (e.g. About page), click on 'Help' at the top right af the screen. Then click on link 'manual' in "See the full documentation for the About page in the manual (online)." Result: For 16.05: http://manual.koha-community.org/16.4/en/aboutkoha.html The requested URL /16.4/en/aboutkoha.html was not found on this server. For current master (16.06.00.002): http://manual.koha-community.org/16.06/en/aboutkoha.html The requested URL /16.06/en/aboutkoha.html was not found on this server. The correct link should be (for both): The requested URL /16.05/en/aboutkoha.html was not found on this server. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 --- Comment #1 from Marc Véron <veron@veron.ch> --- Note: Version number for help files is calculated in help.pl line 68 ff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 --- Comment #2 from Marc Véron <veron@veron.ch> --- Calculation was introduced for 3.14.x ( by Bug 11238 - The version of the manual online link should be dynamically updated ). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11238 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11238 [Bug 11238] The version of the manual online link should be dynamically updated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52339&action=edit Bug 16724: Fix link to the online documentation links Since the numbering changes, the online doc links are broken. Test plan: Make sure the online doc links work on the help pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 --- Comment #4 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 52340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52340&action=edit Bug 16724 - Link from online help to manual broken (as of version 16.05) To test: - apply patch - load some page in staff client, open help, check the link to the manual for 16.05, it should include 16.05 for master, it should include 16.05 for versions < 16, it should still work as before This will work for xx.05 and xx.11 releases. If we will have xx.04 or xx.06 at some point, it has to be adjusted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net Attachment #52340|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52339|0 |1 is obsolete| | --- Comment #5 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 52341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52341&action=edit Bug 16724: Fix link to the online documentation links Since the numbering changes, the online doc links are broken. Test plan: Make sure the online doc links work on the help pages. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 --- Comment #6 from Marc Véron <veron@veron.ch> --- It displays OK with 16.05 and 16.06, but what about future versions? E.g. 16.07, 16.08 (will result in a link to http://manual.koha-community.org/16.07/en/ ) and 16.09, 16.10 (will result in a link to http://manual.koha-community.org/16.09/en/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The numbers for stable should always be .05 and .11 (may and november) currently - so that might work ok. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 52341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52341 Bug 16724: Fix link to the online documentation links Review of attachment 52341: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16724&attachment=52341) ----------------------------------------------------------------- ::: help.pl @@ +69,5 @@
if ( $help_version =~ m|^(\d+)\.(\d{2}).*$| ) { my $version = $1; my $major = $2; + unless ( $major % 2 ) { $major-- }; + $major = sprintf("%02d", $major);
Why not put the sprintf on the next line and remove the interpolation too? :) This works too, though. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to M. Tompsett from comment #8)
Comment on attachment 52341 [details] [review] Bug 16724: Fix link to the online documentation links
Review of attachment 52341 [details] [review]: -----------------------------------------------------------------
::: help.pl @@ +69,5 @@
if ( $help_version =~ m|^(\d+)\.(\d{2}).*$| ) { my $version = $1; my $major = $2; + unless ( $major % 2 ) { $major-- }; + $major = sprintf("%02d", $major);
Why not put the sprintf on the next line and remove the interpolation too? :) This works too, though.
I don't understand. Do you suggest $help_version = $version . '.' . sprintf("%02d", $major); ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52341|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 52539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52539&action=edit [PASSED QA] Bug 16724: Fix link to the online documentation links Since the numbering changes, the online doc links are broken. Test plan: Make sure the online doc links work on the help pages. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for Koha 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #12 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16724 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in 3.22.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org