[Bug 30096] New: Allow to change "late issue notification" setting in subscriptions batch modification tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30096 Bug ID: 30096 Summary: Allow to change "late issue notification" setting in subscriptions batch modification tool Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Serials Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org Depends on: 29997 Bug 29997 adds a "late issue notification" setting for subscriptions. This bug is for being able to modify this setting in the subscriptions batch modification tool. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 [Bug 29997] Allow to send email notification when a serial issue is late -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30096 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 130550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130550&action=edit Bug 30096: Add "late issue notification" to subscriptions batch mod tool This patch depends on bug 29997 Test plan: 1. On the Serials module main page, do a search that return at least 2 subscriptions 2. Check at least 2 boxes in the first column of the table, then click on "Edit selected serials" above the table 3. Verify that the table above the form display correct data for the "Late issue notification" column 4. Submit the form without changing anything. Verify that the setting "late issue notification" was not changed for selected subscriptions 5. Repeat steps 1 and 2. Set "Late issue notification" to one of the available options and submit the form. Verify that the setting "late issue notification" was changed to the selected option for all selected subscriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30096 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30096 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #2 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- (In reply to Julian Maurice from comment #1)
Created attachment 130550 [details] [review] Bug 30096: Add "late issue notification" to subscriptions batch mod tool
This patch depends on bug 29997
Test plan: 1. On the Serials module main page, do a search that return at least 2 subscriptions 2. Check at least 2 boxes in the first column of the table, then click on "Edit selected serials" above the table 3. Verify that the table above the form display correct data for the "Late issue notification" column 4. Submit the form without changing anything. Verify that the setting "late issue notification" was not changed for selected subscriptions 5. Repeat steps 1 and 2. Set "Late issue notification" to one of the available options and submit the form. Verify that the setting "late issue notification" was changed to the selected option for all selected subscriptions
Received this error when applying the patch: Received the error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'me.librarian' in 'field list' at /kohadevbox/koha/Koha/Objects.pm line 96 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30096 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130550|0 |1 is obsolete| | --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 175389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175389&action=edit Bug 30096: Add "late issue notification" to subscriptions batch mod tool This patch depends on bug 29997 Test plan: 1. On the Serials module main page, do a search that return at least 2 subscriptions 2. Check at least 2 boxes in the first column of the table, then click on "Edit selected serials" above the table 3. Verify that the table above the form display correct data for the "Late issue notification" column 4. Submit the form without changing anything. Verify that the setting "late issue notification" was not changed for selected subscriptions 5. Repeat steps 1 and 2. Set "Late issue notification" to one of the available options and submit the form. Verify that the setting "late issue notification" was changed to the selected option for all selected subscriptions Sponsored-by: Écoles Nationales Supérieures d'Architecture -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30096 --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Patch rebased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30096 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30096 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30096 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175389|0 |1 is obsolete| | --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 183391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183391&action=edit Bug 30096: Add "late issue notification" to subscriptions batch mod tool This patch depends on bug 29997 Test plan: 1. On the Serials module main page, do a search that return at least 2 subscriptions 2. Check at least 2 boxes in the first column of the table, then click on "Edit selected serials" above the table 3. Verify that the table above the form display correct data for the "Late issue notification" column 4. Submit the form without changing anything. Verify that the setting "late issue notification" was not changed for selected subscriptions 5. Repeat steps 1 and 2. Set "Late issue notification" to one of the available options and submit the form. Verify that the setting "late issue notification" was changed to the selected option for all selected subscriptions Sponsored-by: Écoles Nationales Supérieures d'Architecture -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30096 --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Automated patch testing results: [PASS] ALL PATCHES APPLY CLEANLY All patches apply successfully to the current codebase. **Patch Results:** [PASS] Bug-30096-Add-late-issue-notification-to-subscript.patch (ID: 183391) Status: SUCCESS Dependencies applied: 29997 + Patch applies cleanly **Dependencies:** 29997 --- This is an automated message from the patch testing system. Tested against branch: main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30096 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is blocked by the dependency being "Failed QA" currently. I believe this would be a nice addition to the serials module. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30096 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30095 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30096 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- This is strongly linked to Bug 30095 no ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30096 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Fridolin Somers from comment #8)
This is strongly linked to Bug 30095 no ?
And that is depending on: Bug 29996 - Show an alert on main page when serial issues are later Which doesn't apply. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org