[Bug 35147] New: Add IDs to Shibboleth text on OPAC login page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35147 Bug ID: 35147 Summary: Add IDs to Shibboleth text on OPAC login page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org So the message can be customised for the library using OPACUserJS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35147 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|oleonard@myacpl.org |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35147 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35147 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 157769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157769&action=edit Bug 35147: Add IDs to Shibboleth text on OPAC login page This enhancement makes it easier for libraries to change the Shibboleth-related messages on the OPAC login page. Libraries can employ OPACUserJS to change the text. For e.g., I can replace the message "If you do not have a Shibboleth account, but you do have a local login, then you may login below." by putting the following in OPACUserJS: $("#shib-local-text").text("If you do not have a staff member account, but are a member of the library, then you may log in below."); To test: 1. Go to <your-opac-url>/cgi-bin/koha/opac-user.pl , or disable the OpacPublic system preference. Ensure you are logged out of the OPAC. 2. In the staff interface, search for the OPACUserJS system preference under Koha Administration. Add the following JS and Save: $("#shib-invalid").text("Test changing the invalid Shibboleth login message."); $("#shib-title").text("Test changing the Shibboleth login heading."); $("#shib-link-text").text("Test changing the Shibboleth account link text."); $("#shib-local-title").text("Test changing the local login heading."); $("#shib-local-text").text("Test changing the message that shows if you do not have a Shibboleth account."); 3. Refresh the OPAC and confirm the text changes to reflect your JS. Note: The invalid Shibboleth login will be a bit harder to test, so if you can't test, confirm the HTML in the patch looks correct. Sponsored-by: New Zealand Council for Educational Research -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35147 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157769|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 157770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157770&action=edit Bug 35147: Add classes to Shibboleth text on OPAC login page This enhancement makes it easier for libraries to change the Shibboleth-related messages on the OPAC login page. Libraries can employ OPACUserJS to change the text. For e.g., I can replace the message "If you do not have a Shibboleth account, but you do have a local login, then you may login below." by putting the following in OPACUserJS: $(".shib_local_text").text("If you do not have a staff member account, but are a member of the library, then you may log in below."); To test: 1. Go to <your-opac-url>/cgi-bin/koha/opac-user.pl , or disable the OpacPublic system preference. Ensure you are logged out of the OPAC. 2. In the staff interface, search for the OPACUserJS system preference under Koha Administration. Add the following JS and Save: $(".shib_invalid").text("Test changing the invalid Shibboleth login message."); $(".shib_title").text("Test changing the Shibboleth login heading."); $(".shib_url").text("Test changing the Shibboleth account link text."); $(".shib_local_title").text("Test changing the local login heading."); $(".shib_local_text").text("Test changing the message that shows if you do not have a Shibboleth account."); 3. Refresh the OPAC and confirm the text changes to reflect your JS. Note: The invalid Shibboleth login will be a bit harder to test, so if you can't test, confirm the HTML in the patch looks correct. Sponsored-by: New Zealand Council for Educational Research -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35147 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add IDs to Shibboleth text |Add classes to Shibboleth |on OPAC login page |text on OPAC login page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35147 --- Comment #3 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Forgot to include on the test plan - click on the Log in button in the top masthead bar and confirm the text there has also been updated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35147 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35147 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157770|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 157859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157859&action=edit Bug 35147: Add classes to Shibboleth text on OPAC login page This enhancement makes it easier for libraries to change the Shibboleth-related messages on the OPAC login page. Libraries can employ OPACUserJS to change the text. For e.g., I can replace the message "If you do not have a Shibboleth account, but you do have a local login, then you may login below." by putting the following in OPACUserJS: $(".shib_local_text").text("If you do not have a staff member account, but are a member of the library, then you may log in below."); To test: 1. Go to <your-opac-url>/cgi-bin/koha/opac-user.pl , or disable the OpacPublic system preference. Ensure you are logged out of the OPAC. 2. In the staff interface, search for the OPACUserJS system preference under Koha Administration. Add the following JS and Save: $(".shib_invalid").text("Test changing the invalid Shibboleth login message."); $(".shib_title").text("Test changing the Shibboleth login heading."); $(".shib_url").text("Test changing the Shibboleth account link text."); $(".shib_local_title").text("Test changing the local login heading."); $(".shib_local_text").text("Test changing the message that shows if you do not have a Shibboleth account."); 3. Refresh the OPAC and confirm the text changes to reflect your JS. Note: The invalid Shibboleth login will be a bit harder to test, so if you can't test, confirm the HTML in the patch looks correct. Sponsored-by: New Zealand Council for Educational Research Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35147 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35147 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157859|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158018&action=edit Bug 35147: Add classes to Shibboleth text on OPAC login page This enhancement makes it easier for libraries to change the Shibboleth-related messages on the OPAC login page. Libraries can employ OPACUserJS to change the text. For e.g., I can replace the message "If you do not have a Shibboleth account, but you do have a local login, then you may login below." by putting the following in OPACUserJS: $(".shib_local_text").text("If you do not have a staff member account, but are a member of the library, then you may log in below."); To test: 1. Go to <your-opac-url>/cgi-bin/koha/opac-user.pl , or disable the OpacPublic system preference. Ensure you are logged out of the OPAC. 2. In the staff interface, search for the OPACUserJS system preference under Koha Administration. Add the following JS and Save: $(".shib_invalid").text("Test changing the invalid Shibboleth login message."); $(".shib_title").text("Test changing the Shibboleth login heading."); $(".shib_url").text("Test changing the Shibboleth account link text."); $(".shib_local_title").text("Test changing the local login heading."); $(".shib_local_text").text("Test changing the message that shows if you do not have a Shibboleth account."); 3. Refresh the OPAC and confirm the text changes to reflect your JS. Note: The invalid Shibboleth login will be a bit harder to test, so if you can't test, confirm the HTML in the patch looks correct. Sponsored-by: New Zealand Council for Educational Research Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35147 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158019&action=edit Bug 35147: (QA follow-up) Capitalzation: Shibboleth Login Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35147 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35147 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35147 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Small very useful enhancement, I backport. Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35147 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.06 |23.11.00,23.05.06,22.11.12 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35147 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35147 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36141 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36141 [Bug 36141] Add classes to CAS text on OPAC login page -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org