[Bug 10858] New: Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Bug ID: 10858 Summary: Browse selected biblios Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org After launching a search, lots of people would like to browse some results from several pages. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20947&action=edit Bug 10858: Browse selected biblios After launching a search, some people would like to browse some results from several pages. This patch adds, at the OPAC, a link "Browse selected biblios >>" when at least one biblio is checked. You can choose biblios from several page, not the current one. In this way, checkboxes already checked become again checked when you come back on this results page. After clicking the link, the "Browse results" block is filled with selected biblios, not (like as the current behavior) with the classic results. Test plan: - Launch a search at the OPAC - Check some biblios - Go on another page - Check some biblios - Come back to the first page and check that already checked biblio is automatically checked. - Click on the "Browse selected biblios >>" link - Check that you are able to browse results you had checked. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch Assignee|oleonard@myacpl.org |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Cédric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20947|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 21476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21476&action=edit Bug 10858: Browse selected biblios After launching a search, some people would like to browse some results from several pages. This patch adds, at the OPAC, a link "Browse selected biblios >>" when at least one biblio is checked. You can choose biblios from several page, not the current one. In this way, checkboxes already checked become again checked when you come back on this results page. After clicking the link, the "Browse results" block is filled with selected biblios, not (like as the current behavior) with the classic results. Test plan: - Launch a search at the OPAC - Check some biblios - Go on another page - Check some biblios - Come back to the first page and check that already checked biblio is automatically checked. - Click on the "Browse selected biblios >>" link - Check that you are able to browse results you had checked. Signed-off-by: C -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 21483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21483&action=edit Bug 10858 [Follow-up] Browse selected biblios This follow-up adds the browse functionality to the CCSR theme and adds some CSS for the "browse" link, including a new image in the image sprite. To test, apply the patch, clear your cache, and test the browsing functionality again. Confirm that the browse link looks good and works correctly in both the prog and CCSR themes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #5 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 10858 [Follow-up] Browse selected biblios Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/prog/en/css/opac.css Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/prog/en/css/opac.css CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/css/opac.css Patch failed at 0001 Bug 10858 [Follow-up] Browse selected biblios The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21476|0 |1 is obsolete| | Attachment #21483|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21646&action=edit Bug 10858: Browse selected biblios After launching a search, some people would like to browse some results from several pages. This patch adds, at the OPAC, a link "Browse selected biblios >>" when at least one biblio is checked. You can choose biblios from several page, not the current one. In this way, checkboxes already checked become again checked when you come back on this results page. After clicking the link, the "Browse results" block is filled with selected biblios, not (like as the current behavior) with the classic results. Test plan: - Launch a search at the OPAC - Check some biblios - Go on another page - Check some biblios - Come back to the first page and check that already checked biblio is automatically checked. - Click on the "Browse selected biblios >>" link - Check that you are able to browse results you had checked. Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21647&action=edit Bug 10858 [Follow-up] Browse selected biblios This follow-up adds the browse functionality to the CCSR theme and adds some CSS for the "browse" link, including a new image in the image sprite. To test, apply the patch, clear your cache, and test the browsing functionality again. Confirm that the browse link looks good and works correctly in both the prog and CCSR themes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Koha Team Amu <koha.aixmarseille@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21646|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21647|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #9 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 21966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21966&action=edit Bug 10858: Browse selected biblios After launching a search, some people would like to browse some results from several pages. This patch adds, at the OPAC, a link "Browse selected biblios >>" when at least one biblio is checked. You can choose biblios from several page, not the current one. In this way, checkboxes already checked become again checked when you come back on this results page. After clicking the link, the "Browse results" block is filled with selected biblios, not (like as the current behavior) with the classic results. Test plan: - Launch a search at the OPAC - Check some biblios - Go on another page - Check some biblios - Come back to the first page and check that already checked biblio is automatically checked. - Click on the "Browse selected biblios >>" link - Check that you are able to browse results you had checked. Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #10 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 21967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21967&action=edit Bug 10858 [Follow-up] Browse selected biblios This follow-up adds the browse functionality to the CCSR theme and adds some CSS for the "browse" link, including a new image in the image sprite. To test, apply the patch, clear your cache, and test the browsing functionality again. Confirm that the browse link looks good and works correctly in both the prog and CCSR themes. Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Koha Team AMU <koha.aixmarseille@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.aixmarseille@gmail.com --- Comment #11 from Koha Team AMU <koha.aixmarseille@gmail.com> --- Potential development : to have a list of results after the click on the "Browse selected biblios" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11132 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle@bywatersolutions.com --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Looks good for prog and ccsr opac themes. However, the feature needs to be updated to work with the new bootstrap theme as well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Kyle M Hall from comment #12) I will open a new report for the bootstrap theme. Back to Signed off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11296 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11311 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21966|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23541&action=edit Bug 10858: Browse selected biblios After launching a search, some people would like to browse some results from several pages. This patch adds, at the OPAC, a link "Browse selected biblios >>" when at least one biblio is checked. You can choose biblios from several page, not the current one. In this way, checkboxes already checked become again checked when you come back on this results page. After clicking the link, the "Browse results" block is filled with selected biblios, not (like as the current behavior) with the classic results. Test plan: - Launch a search at the OPAC - Check some biblios - Go on another page - Check some biblios - Come back to the first page and check that already checked biblio is automatically checked. - Click on the "Browse selected biblios >>" link - Check that you are able to browse results you had checked. Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23541|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23542&action=edit Bug 10858: Browse selected biblios After launching a search, some people would like to browse some results from several pages. This patch adds, at the OPAC, a link "Browse selected biblios >>" when at least one biblio is checked. You can choose biblios from several page, not the current one. In this way, checkboxes already checked become again checked when you come back on this results page. After clicking the link, the "Browse results" block is filled with selected biblios, not (like as the current behavior) with the classic results. Test plan: - Launch a search at the OPAC - Check some biblios - Go on another page - Check some biblios - Come back to the first page and check that already checked biblio is automatically checked. - Click on the "Browse selected biblios >>" link - Check that you are able to browse results you had checked. Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21967|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23543&action=edit Bug 10858 [Follow-up] Browse selected biblios This follow-up adds the browse functionality to the CCSR theme and adds some CSS for the "browse" link, including a new image in the image sprite. To test, apply the patch, clear your cache, and test the browsing functionality again. Confirm that the browse link looks good and works correctly in both the prog and CCSR themes. Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, works as advertised for prog and ccsr. Not implemented for bootstrap, but doesn't affect it detrimentally either. Jonathan plans to open a new bug to implement for bootstrap. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #17 from Galen Charlton <gmcharlt@gmail.com> --- General question about this proposed feature: what's wrong with using the cart for this? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Galen Charlton from comment #17)
General question about this proposed feature: what's wrong with using the cart for this?
The idea is to navigate between selected results, I don't see how to do that with the cart. When I open the basket, I can see a biblio list but the detail page is opened in a new window. Even if I improve the behavior, on a ux point of view I think it is not friendly to have to put biblios in the cart for browsing them. Moreover the same enhancement is developed for authorities (bug 11311), which can not be put in the cart. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23633&action=edit Bug 10858: FIX error if no biblio is selected If the user launch a search a directly go to the opac detail page, an error occurs: malformed JSON string, neither array, object, number, string or atom, at character offset 0 (before "(end of string)") at /usr/share/perl5/JSON.pm line 171. Test plan: - remove the bibs_selected cookie - launch a search - click on a result - the page should be displayed correctly (cherry picked from commit 660e8d0437338a5d533d333123b56f0219aec252) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I just took a look at the feature and I think I found a problem: 1) The feature should not be active, when OpacBrowseResults is turned off. Maybe there should even be a separate pref to control this independently from OpacBrowseResults. People are worried about the use of cookies in some contexts and it might be nice to limit the use of them to a mininum. 2) I wonder if the plugin used needs to be added to the about.pl page - not sure there. It also states alpha, but it does look like there is a stable version available now: https://code.google.com/p/jquery-json/ 3) While this feature is a bit fun to use, I wonder a bit about the use cases. Maybe the sponsoring library/libraires could share the idea behind the feature? 4) Currently the feature seems to do less than the cart or the list functionality offer, as there are no 'bulk' actions available, so I can understand what Galen means with his comment. 5) Also it changes the behaviour of an existing feature, which might be a bit unexpected to users. Not sure what we could do here. 6) When switching between different records you always have to reopen the "Browse results" area and this hides part of the possible actions on the page. This way you can't switch really fast between records and have to find your place in the list again. I think the first point is a 'Failed QA'. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #20)
Hm, I just took a look at the feature and I think I found a problem:
1) The feature should not be active, when OpacBrowseResults is turned off. Maybe there should even be a separate pref to control this independently from OpacBrowseResults. People are worried about the use of cookies in some contexts and it might be nice to limit the use of them to a mininum.
2) I wonder if the plugin used needs to be added to the about.pl page - not sure there. It also states alpha, but it does look like there is a stable version available now: https://code.google.com/p/jquery-json/
I will provide a followup for these 2 points.
3) While this feature is a bit fun to use, I wonder a bit about the use cases. Maybe the sponsoring library/libraires could share the idea behind the feature?
I will ask the customer for an answer.
4) Currently the feature seems to do less than the cart or the list functionality offer, as there are no 'bulk' actions available, so I can understand what Galen means with his comment.
The goal is to browse results, not to export them or any other actions.
5) Also it changes the behaviour of an existing feature, which might be a bit unexpected to users. Not sure what we could do here.
I am not sure that it changes the existing feature. If you click on a detail link (from the result list), you browse all results. If you want to browse selected biblios, you have to click on the new link "browse selected biblios" above the result list. It is 2 different features (but using the same browser UI).
6) When switching between different records you always have to reopen the "Browse results" area and this hides part of the possible actions on the page. This way you can't switch really fast between records and have to find your place in the list again.
Yes, it is the current behavior. I think this feature should be used using the next/previous links. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23781&action=edit Bug 10858: Don't use the cookie if the ft is disabled Is the pref 'OpacBrowseResults' is off, the feature should be completly off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23782&action=edit Bug 10858: Update the jquery.json plugin to the lastest version -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #20)
2) I wonder if the plugin used needs to be added to the about.pl page - not sure there.
I am not sure neither. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Yves Tomic <yves.tomic@u-psud.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yves.tomic@u-psud.fr --- Comment #25 from Yves Tomic <yves.tomic@u-psud.fr> --- The purpose of this patch is to give the possibility to users to select some results while browsing the results pages without going to the detail page immediately. After having browsed the results, the users can display the selected results and navigate through them. -- You are receiving this mail because: You are watching all bug changes.
From a functional perspective: I would like to see this feature in Koha. In earlier comments some mentioned the cart. But this is an interesting addition! Note also that I more than once heard the question: Why does Koha not remember
From a "minimalistic approach" I do wonder if we really need a new plugin (156
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #26 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Some prelimary QA comments/questions: the items I selected on another search result page? So even without browsing, you make some people happy. If you browse the selection, it would imo be good to show that you are doing so (Browse selected results vs. Browse results). If we use the js plugin, it would be good to acknowledge that on About, separate from the question if this specific MIT license needs that by law or so. Also I do not think that remembering a few biblios in a cookie, would be a big legal problem. We c/should clear the contents every time we start a new search. And if we are not allowed to create it, well we do not.. (We have some laws in the Netherlands too about confirming the use of cookies, but in the meantime things seem to go already in a less More technically: There is a small merge conflict in koha-tmpl/opac-tmpl/prog/en/css/opac.css. Note that I would like to see the bootstrap patch here also instead of on another report. Bootstrap is now leading and should be pushed first. (Is there any trouble there with less files?) lines) for storing just a few checkboxes (no offense). This is more a personal opinion too and would not be blocking. But could you on the other hand make more clear why we definitely need this plugin and cannot do it with what we have now [ within say 156 lines of code :) ] ? Waiting for some feedback. Thanks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #27 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- in a less -> in a less restrictive way -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #28 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. de Rooy from comment #26)
Some prelimary QA comments/questions:
Thank you Marcel for having a look at this one.
If you browse the selection, it would imo be good to show that you are doing so (Browse selected results vs. Browse results).
Will be fixed.
If we use the js plugin, it would be good to acknowledge that on About, separate from the question if this specific MIT license needs that by law or so.
In fact the plugin is useless, I will remove it.
Also I do not think that remembering a few biblios in a cookie, would be a big legal problem. We c/should clear the contents every time we start a new search. And if we are not allowed to create it, well we do not..
How do we know if we are allowed or not?
More technically: There is a small merge conflict in koha-tmpl/opac-tmpl/prog/en/css/opac.css.
Will be fixed.
Note that I would like to see the bootstrap patch here also instead of on another report. Bootstrap is now leading and should be pushed first. (Is there any trouble there with less files?)
The first patches were signed off, so I prefer to create another report for the bootstrap theme. I will add the patch from bug 11296 to this one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23542|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25427&action=edit Bug 10858: Browse selected biblios After launching a search, some people would like to browse some results from several pages. This patch adds, at the OPAC, a link "Browse selected biblios >>" when at least one biblio is checked. You can choose biblios from several page, not the current one. In this way, checkboxes already checked become again checked when you come back on this results page. After clicking the link, the "Browse results" block is filled with selected biblios, not (like as the current behavior) with the classic results. Test plan: - Launch a search at the OPAC - Check some biblios - Go on another page - Check some biblios - Come back to the first page and check that already checked biblio is automatically checked. - Click on the "Browse selected biblios >>" link - Check that you are able to browse results you had checked. Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23543|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25428&action=edit Bug 10858 [Follow-up] Browse selected biblios This follow-up adds the browse functionality to the CCSR theme and adds some CSS for the "browse" link, including a new image in the image sprite. To test, apply the patch, clear your cache, and test the browsing functionality again. Confirm that the browse link looks good and works correctly in both the prog and CCSR themes. Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, works as advertised for prog and ccsr. Not implemented for bootstrap, but doesn't affect it detrimentally either. Jonathan plans to open a new bug to implement for bootstrap. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23633|0 |1 is obsolete| | --- Comment #31 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25429&action=edit Bug 10858: FIX error if no biblio is selected If the user launch a search a directly go to the opac detail page, an error occurs: malformed JSON string, neither array, object, number, string or atom, at character offset 0 (before "(end of string)") at /usr/share/perl5/JSON.pm line 171. Test plan: - remove the bibs_selected cookie - launch a search - click on a result - the page should be displayed correctly (cherry picked from commit 660e8d0437338a5d533d333123b56f0219aec252) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23781|0 |1 is obsolete| | --- Comment #32 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25430&action=edit Bug 10858: Don't use the cookie if the ft is disabled Is the pref 'OpacBrowseResults' is off, the feature should be completly off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23782|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25431&action=edit Bug 10858: Update the jquery.json plugin to the lastest version -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #34 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25432&action=edit Bug 10858: Browse selected biblios - bootstrap Add the changes from bug 10858 to the bootstrap theme. Test plan: - Launch a search at the OPAC - Check some biblios - Go on another page - Check some biblios - Come back to the first page and check that already checked biblio is automatically checked. - Click on the "Browse selected biblios >>" link - Check that you are able to browse results you had checked. In addition to prog and ccsr templates, this patch allows to add selected biblios (from multiple pages) to the cart or a list. To test: - check some biblios from several pages - add them to the cart - add them to a list -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #35 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25433&action=edit Bug 10858: Remove the jQuery JSON plugin JSON.stringify and JSON.parse are natively supported by mordern browsers. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #36 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25434&action=edit Bug 10858: FIX the "Browse selected" link It should be updated on checkbox changes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #37 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25435&action=edit Bug 10858: FIX Only one occurrence of the biblionumbers should be stored We have to remove duplicate biblionumber in the array of biblionumbers stored in the cookie. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #38 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25436&action=edit Bug 10858: Replace "Browse results" with "Browse selected results" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #39 from Jonathan Druart <jonathan.druart@biblibre.com> --- *** Bug 11296 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #40 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Jonathan: Thanks for your adjustments and your patience in looking at what follows :) I would strongly prefer to slightly adjust a few patches here. We now add the plugin, update it and then remove it in this series.. I would not recommend to push that line of action if we can just remove it from the first patch. I have no objection to leaving the original signoff on that one when you enter your additional signoff commenting on the amend. After that I will add still another signoff. Makes that sense? Changing status to reflect this.. Please change back to SO after that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25427|0 |1 is obsolete| | Attachment #25428|0 |1 is obsolete| | Attachment #25429|0 |1 is obsolete| | Attachment #25430|0 |1 is obsolete| | Attachment #25431|0 |1 is obsolete| | Attachment #25432|0 |1 is obsolete| | Attachment #25433|0 |1 is obsolete| | Attachment #25434|0 |1 is obsolete| | Attachment #25435|0 |1 is obsolete| | Attachment #25436|0 |1 is obsolete| | --- Comment #41 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25450&action=edit Bug 10858: Browse selected biblios After launching a search, some people would like to browse some results from several pages. This patch adds, at the OPAC, a link "Browse selected biblios >>" when at least one biblio is checked. You can choose biblios from several page, not the current one. In this way, checkboxes already checked become again checked when you come back on this results page. After clicking the link, the "Browse results" block is filled with selected biblios, not (like as the current behavior) with the classic results. Test plan: - Launch a search at the OPAC - Check some biblios - Go on another page - Check some biblios - Come back to the first page and check that already checked biblio is automatically checked. - Click on the "Browse selected biblios >>" link - Check that you are able to browse results you had checked. Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #42 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25451&action=edit Bug 10858 [Follow-up] Browse selected biblios This follow-up adds the browse functionality to the CCSR theme and adds some CSS for the "browse" link, including a new image in the image sprite. To test, apply the patch, clear your cache, and test the browsing functionality again. Confirm that the browse link looks good and works correctly in both the prog and CCSR themes. Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, works as advertised for prog and ccsr. Not implemented for bootstrap, but doesn't affect it detrimentally either. Jonathan plans to open a new bug to implement for bootstrap. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #43 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25452&action=edit Bug 10858: FIX error if no biblio is selected If the user launch a search a directly go to the opac detail page, an error occurs: malformed JSON string, neither array, object, number, string or atom, at character offset 0 (before "(end of string)") at /usr/share/perl5/JSON.pm line 171. Test plan: - remove the bibs_selected cookie - launch a search - click on a result - the page should be displayed correctly (cherry picked from commit 660e8d0437338a5d533d333123b56f0219aec252) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #44 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25453&action=edit Bug 10858: Don't use the cookie if the ft is disabled Is the pref 'OpacBrowseResults' is off, the feature should be completly off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #45 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25454&action=edit Bug 10858: Browse selected biblios - bootstrap Add the changes from bug 10858 to the bootstrap theme. Test plan: - Launch a search at the OPAC - Check some biblios - Go on another page - Check some biblios - Come back to the first page and check that already checked biblio is automatically checked. - Click on the "Browse selected biblios >>" link - Check that you are able to browse results you had checked. In addition to prog and ccsr templates, this patch allows to add selected biblios (from multiple pages) to the cart or a list. To test: - check some biblios from several pages - add them to the cart - add them to a list -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #46 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25455&action=edit Bug 10858: FIX the "Browse selected" link It should be updated on checkbox changes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #47 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25456&action=edit Bug 10858: FIX Only one occurrence of the biblionumbers should be stored We have to remove duplicate biblionumber in the array of biblionumbers stored in the cookie. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #48 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25457&action=edit Bug 10858: Replace "Browse results" with "Browse selected results" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #49 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. de Rooy from comment #40)
I would strongly prefer to slightly adjust a few patches here. We now add the plugin, update it and then remove it in this series.. I would not recommend to push that line of action if we can just remove it from the first patch. I have no objection to leaving the original signoff on that one when you enter your additional signoff commenting on the amend. After that I will add still another signoff. Makes that sense?
Absolutely, it was a "morning laziness" :) I completely removed all references to this plugin in the last set of patches. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #50 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Some comments after experimenting the feature further on bootstrap/prog. Should we still put time in ccsr? 1. If you disable OpacBrowseResults, please remove the link. 2. In bootstrap clicking Browse selected on detail page does not respond (prog does) 3. This is a weird one but just mentioning: Disable cookies in your browser. Check two biblios on the same page. Click on Browse selected. No item was selected. Heh. If you cannot save the cookie, remove link too? Note that by checking the cookie again in setContextBiblioNumbers, you know if the first call succeeded or not. Waiting for some feedback. After that I will still have to look at the code somewhat more closely.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #51 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25512&action=edit Bug 10858: fix bad merge conflict -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #52 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25513&action=edit Bug 10858: follow-up Don't use the cookie if the ft is disabled -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #53 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25514&action=edit Bug 10858: Handle JS deactivated and cookies disabled If JS is deactivated, the "browse" link should not be displayed. Same if cookies are disabled, the feature does not work. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #54 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. de Rooy from comment #50)
1. If you disable OpacBrowseResults, please remove the link.
Fixed
2. In bootstrap clicking Browse selected on detail page does not respond (prog does)
Cause by a bad merge conflict reintroduced by last set of patches. Fixed!
3. This is a weird one but just mentioning: Disable cookies in your browser. Check two biblios on the same page. Click on Browse selected. No item was selected. Heh. If you cannot save the cookie, remove link too? Note that by checking the cookie again in setContextBiblioNumbers, you know if the first call succeeded or not.
Fixed too with the last patch. There were some weird behaviors if javascript was deactivated or cookies disabled. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25450|0 |1 is obsolete| | --- Comment #55 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 25643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25643&action=edit Bug 10858: Browse selected biblios After launching a search, some people would like to browse some results from several pages. This patch adds, at the OPAC, a link "Browse selected biblios >>" when at least one biblio is checked. You can choose biblios from several page, not the current one. In this way, checkboxes already checked become again checked when you come back on this results page. After clicking the link, the "Browse results" block is filled with selected biblios, not (like as the current behavior) with the classic results. Test plan: - Launch a search at the OPAC - Check some biblios - Go on another page - Check some biblios - Come back to the first page and check that already checked biblio is automatically checked. - Click on the "Browse selected biblios >>" link - Check that you are able to browse results you had checked. Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25451|0 |1 is obsolete| | --- Comment #56 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 25644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25644&action=edit Bug 10858 [Follow-up] Browse selected biblios This follow-up adds the browse functionality to the CCSR theme and adds some CSS for the "browse" link, including a new image in the image sprite. To test, apply the patch, clear your cache, and test the browsing functionality again. Confirm that the browse link looks good and works correctly in both the prog and CCSR themes. Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, works as advertised for prog and ccsr. Not implemented for bootstrap, but doesn't affect it detrimentally either. Jonathan plans to open a new bug to implement for bootstrap. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25452|0 |1 is obsolete| | --- Comment #57 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 25645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25645&action=edit Bug 10858: FIX error if no biblio is selected If the user launch a search a directly go to the opac detail page, an error occurs: malformed JSON string, neither array, object, number, string or atom, at character offset 0 (before "(end of string)") at /usr/share/perl5/JSON.pm line 171. Test plan: - remove the bibs_selected cookie - launch a search - click on a result - the page should be displayed correctly (cherry picked from commit 660e8d0437338a5d533d333123b56f0219aec252) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25453|0 |1 is obsolete| | --- Comment #58 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 25646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25646&action=edit Bug 10858: Don't use the cookie if the ft is disabled Is the pref 'OpacBrowseResults' is off, the feature should be completly off. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25454|0 |1 is obsolete| | --- Comment #59 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 25647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25647&action=edit Bug 10858: Browse selected biblios - bootstrap Add the changes from bug 10858 to the bootstrap theme. Test plan: - Launch a search at the OPAC - Check some biblios - Go on another page - Check some biblios - Come back to the first page and check that already checked biblio is automatically checked. - Click on the "Browse selected biblios >>" link - Check that you are able to browse results you had checked. In addition to prog and ccsr templates, this patch allows to add selected biblios (from multiple pages) to the cart or a list. To test: - check some biblios from several pages - add them to the cart - add them to a list Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25455|0 |1 is obsolete| | --- Comment #60 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 25648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25648&action=edit Bug 10858: FIX the "Browse selected" link It should be updated on checkbox changes. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25456|0 |1 is obsolete| | --- Comment #61 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 25649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25649&action=edit Bug 10858: FIX Only one occurrence of the biblionumbers should be stored We have to remove duplicate biblionumber in the array of biblionumbers stored in the cookie. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25457|0 |1 is obsolete| | --- Comment #62 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 25650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25650&action=edit Bug 10858: Replace "Browse results" with "Browse selected results" Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25512|0 |1 is obsolete| | --- Comment #63 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 25651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25651&action=edit Bug 10858: fix bad merge conflict Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25513|0 |1 is obsolete| | --- Comment #64 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 25652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25652&action=edit Bug 10858: follow-up Don't use the cookie if the ft is disabled Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25514|0 |1 is obsolete| | --- Comment #65 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 25653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25653&action=edit Bug 10858: Handle JS deactivated and cookies disabled If JS is deactivated, the "browse" link should not be displayed. Same if cookies are disabled, the feature does not work. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #66 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Nice work including QA changes. No complaints from koha-qa. Tested prog and bootstrap. Disabled cookies too for a short while :) Still found small debatable issue: First I selected one record on page 1, page 2 and page 3. After that I selected all records on page 1. It confused me at first to discover that the Browse results on detail are not in the order of the search results, but apparently in the order of being added to the list. No blocker for me, but we could argue about the order of the list. One of the commit messages promised this: In addition to prog and ccsr templates, this patch allows to add selected biblios (from multiple pages) to the cart or a list. To test: - check some biblios from several pages - add them to the cart - add them to a list Unfortunately, when I added items from two pages, only the item of the current page was added. Again (with this being my last QA before temporary cutoff date) no blocker for me :) A followup would be pretty on another report though. Saw some warnings in the log: opac-detail.pl: Use of uninitialized value in concatenation (.) or string at /usr/share/koha/testclone/opac/opac-detail.pl line 394 opac-detail.pl: Use of uninitialized value in concatenation (.) or string at /usr/share/koha/testclone/opac/opac-detail.pl line 400. But I have the impression that your patches did not touch these lines.. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #67 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. de Rooy from comment #66)
One of the commit messages promised this: In addition to prog and ccsr templates, this patch allows to add selected biblios (from multiple pages) to the cart or a list. To test: - check some biblios from several pages - add them to the cart - add them to a list Unfortunately, when I added items from two pages, only the item of the current page was added.
I just retested right now and it works using the bootstrap theme. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | Status|Passed QA |In Discussion --- Comment #68 from Galen Charlton <gmcharlt@gmail.com> --- This set up rather a lot of infrastructure for a feature whose workflow purpose can be met by the cart, and I remain dubious. Consequently, I'm punting this to the next RM. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #69 from Jonathan Druart <jonathan.druart@biblibre.com> --- I removed the "in discussion" status. Sent to the RM queue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #70 from Jonathan Druart <jonathan.druart@biblibre.com> --- Dear RM, what about this feature? :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25643|0 |1 is obsolete| | Attachment #25644|0 |1 is obsolete| | Attachment #25645|0 |1 is obsolete| | Attachment #25646|0 |1 is obsolete| | Attachment #25647|0 |1 is obsolete| | Attachment #25648|0 |1 is obsolete| | Attachment #25649|0 |1 is obsolete| | Attachment #25650|0 |1 is obsolete| | Attachment #25651|0 |1 is obsolete| | Attachment #25652|0 |1 is obsolete| | Attachment #25653|0 |1 is obsolete| | --- Comment #71 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36757&action=edit Bug 10858: Browse selected biblios After launching a search, some people would like to browse some results from several pages. This patch adds, at the OPAC, a link "Browse selected biblios >>" when at least one biblio is checked. You can choose biblios from several page, not the current one. In this way, checkboxes already checked become again checked when you come back on this results page. After clicking the link, the "Browse results" block is filled with selected biblios, not (like as the current behavior) with the classic results. Test plan: - Launch a search at the OPAC - Check some biblios - Go on another page - Check some biblios - Come back to the first page and check that already checked biblio is automatically checked. - Click on the "Browse selected biblios >>" link - Check that you are able to browse results you had checked. You can also: - check some biblios from several pages - add them to the cart - add them to a list Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #72 from Jonathan Druart <jonathan.druart@biblibre.com> --- Ok so, back on this one. It did not apply at all and had ccsr+prog themes. This new patch is just a squash patch with only the bootstrap theme changes. Test plan is the same. QA Note:(In reply to M. de Rooy from comment #26)
If you browse the selection, it would imo be good to show that you are doing so (Browse selected results vs. Browse results).
I removed this change, it did not work. Actually I don't see an easy way to do that and consider it as a minor and should not be a blocker. Switch back in the QA queue to give confidence to the RM. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy@rijksmuseum.nl | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #73 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- CONFLICT (add/add): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.cookie.min.js Auto-merging koha-tmpl/opac-tmpl/bootstrap/js/basket.js Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36757|0 |1 is obsolete| | --- Comment #74 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38033&action=edit Bug 10858: Browse selected biblios -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #75 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) Shoudl this be included on the about.pl page? +// Extends jQuery API +// http://www.wskidmore.com/downloads/jquery-uniqueArray.min.js 2) I think there are display problems, when both the cart and the lists are turned off: For example, this is only available with the prefs ON: var MSG_NO_RECORD_SELECTED = _("No item was selected"); Browse selected record still shows up, but I see only one checkbox on my third record in the list? (confusing) I am not logged in and tried in 2 different browsers. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #76 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38405&action=edit Bug 10858: Define the NO_RECORD_SELECTED msg in any case And not only when cart or list are defined. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #77 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #75)
1) Shoudl this be included on the about.pl page? +// Extends jQuery API +// http://www.wskidmore.com/downloads/jquery-uniqueArray.min.js
The domain is down and I don't know at all where I found this piece of code. It was certainly under the MIT license.
2) I think there are display problems, when both the cart and the lists are turned off:
For example, this is only available with the prefs ON: var MSG_NO_RECORD_SELECTED = _("No item was selected");
Ok fixed.
Browse selected record still shows up, but I see only one checkbox on my third record in the list? (confusing)
I am not logged in and tried in 2 different browsers.
I don't get it, I have never seen that. Please provide more info to recreate the issue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #78 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
1) Shoudl this be included on the about.pl page? +// Extends jQuery API +// http://www.wskidmore.com/downloads/jquery-uniqueArray.min.js
The domain is down and I don't know at all where I found this piece of code. It was certainly under the MIT license.
I am not very comfortable with the dependency as it doesn't include a lisence statement right now and there seems no way to trace it back to an author. Could we replace this with our own code or some other plugin? Some of the other problems went away after making sure my browser cache was cleared. But I still see a problem when both cart and list are turned off: the text "browse selected records" still shows up, but there are no checkboxes to select a record. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #79 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39502&action=edit Bug 10858: Replace the unique jQuery function with our own -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om Assignee|jonathan.druart@biblibre.co |julian.maurice@biblibre.com |m | Status|Signed Off |Failed QA --- Comment #80 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #78)
Some of the other problems went away after making sure my browser cache was cleared. But I still see a problem when both cart and list are turned off: the text "browse selected records" still shows up, but there are no checkboxes to select a record.
This is still valid. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #81 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, thx for the follow-up replacing the jQuery! Are we waiting for another follow-up here? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #82 from Jonathan Druart <jonathan.druart@biblibre.com> --- No sorry, back to Needs QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #83 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 39938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39938&action=edit No way to select records with list and cart inactive - link stil shows Hi Jonathan, I think the link should disappear when neither cart nor list are available - or we need to keep showing the checkboxes for selecting records in the result list. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #84 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 41838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41838&action=edit Bug 10858: Always show checkboxes in OPAC search results Because "Browse selected biblios" action will always be available -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38033|0 |1 is obsolete| | --- Comment #85 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 41839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41839&action=edit Bug 10858: Browse selected biblios Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38405|0 |1 is obsolete| | --- Comment #86 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 41840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41840&action=edit Bug 10858: Define the NO_RECORD_SELECTED msg in any case Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39502|0 |1 is obsolete| | --- Comment #87 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 41841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41841&action=edit Bug 10858: Replace the unique jQuery function with our own Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41838|0 |1 is obsolete| | --- Comment #88 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 41842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41842&action=edit Bug 10858: Always show checkboxes in OPAC search results Because "Browse selected biblios" action will always be available -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #89 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Julian, I think the last patch makes a wrong assumption - the browse feature is useless if OpacBrowseResults is turned off (which some of our libraries actually have). So I think removing the checks for the checkboxes should be undone and a check for this pref added to the code - for the checkboxes and also for the link at the top of the results. What do you think? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #90 from Julian Maurice <julian.maurice@biblibre.com> --- Hi Katrin, I made this assumption by looking at the code, but the code is wrong, and you are right ;) I will submit a followup, replacing the last patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41842|0 |1 is obsolete| | --- Comment #91 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 44903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44903&action=edit Bug 10858: Show checkbox if OpacBrowseResult is set -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #92 from Frédéric Demians <frederic@tamil.fr> --- On last patch, I don't understand that, the last test: [% IF ( Koha.Preference('opacbookbag') == 1 ) || ( Koha.Preference('virtualshelves') == 1 ) || ( Koha.Preference('OpacBrowseResults') == 1 ) || ( Koha.Preference('RequestOnOpac') == 1 && (not SEARCH_RESULT.norequests) && Koha.Preference('opacuserlogin') ) %] I think that it's rather: || ( Koha.Preference('RequestOnOpac') == 1 && (not SEARCH_RESULT.norequests) && (not Koha.Preference('opacuserlogin')) ) But I'm not sure... And When everything is disabled, no checkboxes at all, links 'check all' / 'clear all' are still displayed. This bug is also in master, but still... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #93 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- hm, the last line seems correct to me: if holds and login are allowed... -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org