[Bug 10538] New: Improve importation of .CSV framework files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 Bug ID: 10538 Summary: Improve importation of .CSV framework files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: mtj@kohaaloha.com CC: gmcharlt@gmail.com Koha often fails when importing CSV framework files, because Koha can currently only import 'perfectly quoted' CSV files this patch uses the amazing Text::CSV module to improve the robustness of the importation process -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 --- Comment #1 from Mason James <mtj@kohaaloha.com> --- Created attachment 19400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19400&action=edit Bug 10538 - Improve importation of .CSV framework files this patch is basically a rewrite of the _import_table_csv() sub, using Text::CSV to test this patch... 1/ dump a framework as a .csv file, to your disk 2/ open that .csv file in LibreOffice (or OpenOffice) and save that file as a new.csv note: LO/OO has just created a 'broken' new.csv file 3/ import new.csv file into Koha, (the import should FAIL) 4/ apply patch and repeat step 3, (the import should SUCCEED) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- My saved LibreOffice csv failed to import both pre and post patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Mason, Could you describe the issue? I cannot reproduce, the csv file seems good for the default framework and the acquisition framework. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- I don't get any error log output, just an import failed message from the browser. Perhaps if you uploaded a pair of framework files for testing, it would help. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- I confirm I cannot reproduce. Tested with several frameworks. Maybe it would be useful to attach a csv framework file to this report? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mtj@kohaaloha.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #6 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19400|0 |1 is obsolete| | --- Comment #7 from Joy Nelson <joy@bywatersolutions.com> --- Created attachment 22112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22112&action=edit Bug 10538 - Improve importation of .CSV framework files this patch is basically a rewrite of the _import_table_csv() sub, using Text::CSV to test this patch... 1/ dump a framework as a .csv file, to your disk 2/ open that .csv file in LibreOffice (or OpenOffice) and save that file as a new.csv note: LO/OO has just created a 'broken' new.csv file 3/ import new.csv file into Koha, (the import should FAIL) 4/ apply patch and repeat step 3, (the import should SUCCEED) Signed-off-by: Joy Nelson <joy@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 --- Comment #8 from Joy Nelson <joy@bywatersolutions.com> --- Created attachment 22113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22113&action=edit Bug 8368: (follow-up) restore use of quoted printable for message body This is necessary to prevent the equals sign that is part of the link back to the OPAC from being mangled, thereby breaking the link. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Joy Nelson <joy@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22112|0 |1 is obsolete| | Attachment #22113|0 |1 is obsolete| | --- Comment #9 from Joy Nelson <joy@bywatersolutions.com> --- Created attachment 22114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22114&action=edit Signed-off-by: Joy Nelson <joy@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am a bit worried about this rewrite. OO/LibreOffice seems to remove the quotation marks from the fields when you save the file with a new name. The patch makes it possible to import the file anyway. But this can lead to other problems, for example it would be possible to have a comma in one of the descriptions and this field would not be imported, without any warning or error message. I also wonder about the use case here, because we also offer a specific spreadsheet format to be used with OO/Libre Office. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am moving this to failed QA - see questions and notes in comment 10. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org