[Bug 24103] New: Add option to dump built search query to templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Bug ID: 24103 Summary: Add option to dump built search query to templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org It would be nice to be able to see what is actually being searched in the search engine when performing a query -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 95792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95792&action=edit Bug 24103: Add option to dump search query to templates To test: 1 - Apply patch, update database 2 - Note new syspref 'DumpSearchQueryTemplate' 3 - Leave it off 4 - Enable DumpTemplateVariablesOpac and Staff 5 - Search on staff and opac 6 - View the source 7 - Search for 'search_query' - you shouldn't find it 8 - Enable the new pref 9 - Repeat, but you should find the query 10 - Test staff/opac search and advanced search, cataloguing search, authority search, authfinder search, adding to a basket form a new biblio 11 - All should work and show the query 12 - This will work under both ES and Zebra -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala@helsinki.fi, | |jonathan.druart@bugs.koha-c | |ommunity.org, | |kyle@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24110 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens@lancasterseminar | |y.edu Status|Needs Signoff |Failed QA --- Comment #2 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- (In reply to Nick Clemens from comment #1)
Created attachment 95792 [details] [review] Bug 24103: Add option to dump search query to templates
To test: 1 - Apply patch, update database 2 - Note new syspref 'DumpSearchQueryTemplate' 3 - Leave it off 4 - Enable DumpTemplateVariablesOpac and Staff 5 - Search on staff and opac 6 - View the source 7 - Search for 'search_query' - you shouldn't find it 8 - Enable the new pref 9 - Repeat, but you should find the query 10 - Test staff/opac search and advanced search, cataloguing search, authority search, authfinder search, adding to a basket form a new biblio 11 - All should work and show the query 12 - This will work under both ES and Zebra
This is very, very close but needs one more thing: it doesn't apply to OPAC authority searches. Test results: 1. Applied patch, updatedatabase, restart_all 2. Noted new syspref 'DumpSearchQueryTemplate' 3. Didn't turn it on 4. Enabled 'DumpTemplateVarsIntranet' and 'DumpTemplateVarsOpac' 5. Searched on staff/intranet, searched on OPAC 6. Viewed the source 7. Searched staff/intranet and OPAC source for 'search_query' - did not find it 8. Enabled 'DumpSearchQueryTemplate' 9. Repeated searches, viewed source, searched source for 'search_query' and found in both staff/intranet source and OPAC source 10-11. Subsequent test searches: a. OPAC advanced search - Yes b. OPAC authority search - NO c. Staff advanced search - Yes d. Cataloguing search - Yes e. Staff authority search - Yes d. Auth_finder search (when editing a biblio) - Yes e. Adding to basket from existing record - Yes 12. Tested with ES only. Plan to retest with both ES and Zebra if patch can be updated to include OPAC authority search. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 98928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98928&action=edit Bug 24103: (follow-up) Dump query on opac authorities search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95792|0 |1 is obsolete| | Attachment #98928|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 99023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99023&action=edit Bug 24103: Add option to dump search query to templates To test: 1 - Apply patch, update database 2 - Note new syspref 'DumpSearchQueryTemplate' 3 - Leave it off 4 - Enable DumpTemplateVariablesOpac and Staff 5 - Search on staff and opac 6 - View the source 7 - Search for 'search_query' - you shouldn't find it 8 - Enable the new pref 9 - Repeat, but you should find the query 10 - Test staff/opac search and advanced search, cataloguing search, authority search, authfinder search, adding to a basket form a new biblio 11 - All should work and show the query 12 - This will work under both ES and Zebra Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 99024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99024&action=edit Bug 24103: (follow-up) Dump query on opac authorities search Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- I tested these under Zebra ONLY, so I don't think I can mark this as signed off. But I wanted to at least give a signoff for Zebra. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99023|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 99054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99054&action=edit Bug 24103: Add option to dump search query to templates To test: 1 - Apply the patch, update the database (perl installer/data/mysql/updatedatabase.pl) 2 - Note new system preference 'DumpSearchQueryTemplate' 3 - Leave it off 4 - Enable DumpTemplateVarsIntranet and DumpTemplateVarsOpac system preferences 5 - Search on staff and opac 6 - View the page source 7 - Search for 'search_query' - you shouldn't find it 8 - Enable the new system preference 9 - Repeat steps 5-7, but you should now find the 'search_query' 10 - Test staff/opac search and advanced search, cataloguing search, authority search, authfinder search (/cgi-bin/koha/authorities/auth_finder.pl), adding to a basket form a new biblio 11 - All should work and show the query 12 - This will work under both ES and Zebra Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99024|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 99055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99055&action=edit Bug 24103: (follow-up) Dump query on opac authorities search Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #9 from David Nind <david@davidnind.com> --- Tested on Elastic Search and everything works as per the test plan. To enable Elastic Search on koha-testing-docker: 1) Start up with ku-es6 (instead of just ku) (see the note at bottom of koha-testing-docker README about 'Having Elasticsearch run') 2) Change the search engine from Zebra to Elasticsearch (SearchEngine system preference) 3) Reindex the content: go into the container using kshell then change to the koha directory and run ./misc/search_tools/rebuild_elasticsearch.pl -v -d 4) Search in either the staff interface or OPAC to make sure you get results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'd like it if this was not tied to the other preferences. It makes it hard to work with and not sure if we couldn't just have added to the output without needing a new pref? But working and helpful - passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99054|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 99137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99137&action=edit Bug 24103: Add option to dump search query to templates To test: 1 - Apply patch, update database 2 - Note new syspref 'DumpSearchQueryTemplate' 3 - Leave it off 4 - Enable DumpTemplateVariablesOpac and Staff 5 - Search on staff and opac 6 - View the source 7 - Search for 'search_query' - you shouldn't find it 8 - Enable the new pref 9 - Repeat, but you should find the query 10 - Test staff/opac search and advanced search, cataloguing search, authority search, authfinder search, adding to a basket form a new biblio 11 - All should work and show the query 12 - This will work under both ES and Zebra Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99055|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 99138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99138&action=edit Bug 24103: (follow-up) Dump query on opac authorities search Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement allows you release notes| |to view the search query | |used by Zebra or Elastic | |Search, to help with | |troubleshooting. To use, | |enable the new system | |preference | |DumpSearchQueryTemplate, | |enable | |DumpTemplateVarsIntranet | |and DumpTemplateVarsOpac, | |and then search the page | |source in the staff | |interface or OPAC for | |'search_query'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |joy@bywatersolutions.com Status|Pushed to master |RESOLVED --- Comment #14 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Version(s)|20.05.00 |20.05.00, 19.11.05 released in| | Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to stable --- Comment #15 from Joy Nelson <joy@bywatersolutions.com> --- Backported to 19.11.x branch for 19.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- not backporting enhancement to 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement allows you |This enhancement allows you release notes|to view the search query |to view the search query |used by Zebra or Elastic |used by Zebra or |Search, to help with |Elasticsearch, to help with |troubleshooting. To use, |troubleshooting. To use, |enable the new system |enable the new system |preference |preference |DumpSearchQueryTemplate, |DumpSearchQueryTemplate, |enable |enable |DumpTemplateVarsIntranet |DumpTemplateVarsIntranet |and DumpTemplateVarsOpac, |and DumpTemplateVarsOpac, |and then search the page |and then search the page |source in the staff |source in the staff |interface or OPAC for |interface or OPAC for |'search_query'. |'search_query'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement allows you |This enhancement allows you release notes|to view the search query |to view the search query |used by Zebra or |used by Zebra or |Elasticsearch, to help with |Elasticsearch, to help with |troubleshooting. To use, |troubleshooting. To use, |enable the new system |enable the new system |preference |preference |DumpSearchQueryTemplate, |DumpSearchQueryTemplate, |enable |enable |DumpTemplateVarsIntranet |DumpTemplateVarsIntranet |and DumpTemplateVarsOpac, |and DumpTemplateVarsOpac, |and then search the page |and then search the page |source in the staff |source in the staff |interface or OPAC for |interface or OPAC for |'search_query'. |'search_query'. | | | |**New | |system preferences**: | |`DumpSearchQueryTemplate`, | |`DumpTemplateVarsIntranet` | |and `DumpTemplateVarsOpac` | |all default to disabled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement allows you |This enhancement allows you release notes|to view the search query |to view the search query |used by Zebra or |used by Zebra or |Elasticsearch, to help with |Elasticsearch, to help with |troubleshooting. To use, |troubleshooting. To use, |enable the new system |enable the new system |preference |preference |DumpSearchQueryTemplate, |DumpSearchQueryTemplate, |enable |enable |DumpTemplateVarsIntranet |`DumpTemplateVarsIntranet` |and DumpTemplateVarsOpac, |and `DumpTemplateVarsOpac`, |and then search the page |and then search the page |source in the staff |source in the staff |interface or OPAC for |interface or OPAC for |'search_query'. |'search_query'. | | |**New |**New |system preferences**: |system preference**: |`DumpSearchQueryTemplate`, |`DumpSearchQueryTemplate` |`DumpTemplateVarsIntranet` |defaults to disabled. |and `DumpTemplateVarsOpac` | |all default to disabled. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30543 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30543 [Bug 30543] Decouple DumpSearchQueryTemplate from other template dump preferences -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org