[Bug 18750] New: t/db_dependent/Circulation/Branch.t fails.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18750 Bug ID: 18750 Summary: t/db_dependent/Circulation/Branch.t fails. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: mtompset@hotmail.com QA Contact: gmcharlt@gmail.com prove t/db_dependent/Circulation/Branch.t fails test 12 not ok 12 - AddReturn respects default return policy - return to homebranch In C4::Circulation, the CanBookBeReturned returns 0 for the wrong branch, but never tests if it is returnable for the right branch. Adding in logic triggers the NeedsTransfer else case near the end of the AddReturn function. It is unclear what else might break as a side-effect of this patch method. I will put this into Discussion, unless someone else can verify this is the correct way to fix the problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18750 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18750 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 64085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64085&action=edit Bug 18750: t/db_dependent/Circulation/Branch.t fails TEST PLAN --------- prove -v t/db_dependent/Circulation/Branch.t -- nice kaboom apply patch prove -v t/db_dependent/Circulation/Branch.t -- everything passes run koha qa test tools BIG DISCLAIMER EXPLAINING IN DISCUSSION STATUS: Look for 'WrongBranch' vs 'NeedsTransfer' logic elsewhere I have not spent time doing this, which is why this is 'In Discussion'. If it is fully confirmed that it does not break anywhere else, then and only then feel free to sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18750 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|In Discussion |Failed QA --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Tests pass for me, it is certainly more data related then a bug in the logic code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18750 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Tests pass for me, it is certainly more data related than a bug in the logic code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18750 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Is this dead now? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18750 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |INVALID --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #4)
Is this dead now?
Yes and no, the tests do not longer exist, but the pm code is still there. As we do not have answer from Mark I would suggest to close this bug report (invalid) and let him reopening it if he thinks it is needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org