[Bug 8428] New: can't save contracts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8428 Priority: P5 - low Change sponsored?: --- Bug ID: 8428 Assignee: koha-bugs@lists.koha-community.org Summary: can't save contracts Severity: major Classification: Unclassified OS: All Reporter: nengard@gmail.com URL: /cgi-bin/koha/admin/aqcontract.pl?op=add_form&booksell erid=1 Hardware: All Status: NEW Version: master Component: Acquisitions Product: Koha I'm trying to create a contract and no matter how many times I click the save button nothing happens. I get no errors, no saving, no confirmation, just nothing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8428 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can confirm this bug. Firebug shows a Javascript error: ReferenceError: Date_from_syspref is not defined [Bei diesem Fehler anhalten] var startDate = Date_from_syspref($("#contractstartdate").val()); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8428 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8428 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Acquisitions |Templates Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the problem was caused by the switch to the new calendar, because the new calendar.inc file is missing the function. Date_from_syspref. The function is also used in claim.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8428 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8428 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11799&action=edit Bug 8428 - can't save contracts When I replaced the old calendar widget with the jQueryUI version we lost a JavaScript function which is required by a couple of pages: Date_from_syspref. This patch adds the function back to the calendar include and corrects variables in the two affected templates to make it work again. To test: - create a new contract. Submitting should work properly and without JavaScript errors. - Open the serials claims page (serials/claims.pl) and filter the results by date. Submitting the filter form should work properly and without JavaScript errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8428 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8428 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11799|0 |1 is obsolete| | --- Comment #4 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 11800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11800&action=edit [SIGNED-OFF] Bug 8428 - can't save contracts When I replaced the old calendar widget with the jQueryUI version we lost a JavaScript function which is required by a couple of pages: Date_from_syspref. This patch adds the function back to the calendar include and corrects variables in the two affected templates to make it work again. To test: - create a new contract. Submitting should work properly and without JavaScript errors. - Open the serials claims page (serials/claims.pl) and filter the results by date. Submitting the filter form should work properly and without JavaScript errors. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Both tests passed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8428 --- Comment #5 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 11801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11801&action=edit serials claim form messed up The patch works, and I'm not sure if the patch caused this design issue so I signed off. A follow up should be submitted to make it so that the title search box appears next to the Title label instead of the Library label like it does now. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8428 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8428 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #5)
A follow up should be submitted to make it so that the title search box appears next to the Title label instead of the Library label like it does now.
This issue is unrelated to the changes made in this patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8428 --- Comment #7 from Nicole C. Engard <nengard@gmail.com> --- Design issue submitted in Bug 8681 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8428 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11801|0 |1 is obsolete| | --- Comment #8 from Nicole C. Engard <nengard@gmail.com> --- Comment on attachment 11801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11801 serials claim form messed up removing - now on Bug 8681 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8428 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact| |mtj@kohaaloha.com --- Comment #9 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #4)
Created attachment 11800 [details] [SIGNED-OFF] Bug 8428 - can't save contracts Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Both tests passed.
passing QA... $ koha-qa.pl testing 1 commit(s) (applied to commit 0acebb8) * d4f2940 Bug 8428 - can't save contracts koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqcontract.tt koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt * koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc OK * koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqcontract.tt OK * koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8428 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 Blocks| |8181 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8428 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Doesn't apply on 3.8.x please reformat if needed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8428 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |rel_3_10 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #11)
Doesn't apply on 3.8.x please reformat if needed
Not needed. The bug is related to the addition of the jQueryUI datepicker which isn't in 3.8.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8428 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- Resolved in 3.10.0 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org