http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12111 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |mathsabypro@gmail.com |ity.org | --- Comment #1 from mathieu saby <mathsabypro@gmail.com> --- Created attachment 27311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27311&action=edit [PATCH] Bug 12111: Improving templates regarding order notes This bug changes some lines in modordernotes.tt to make them more easily translatable, especially in german (remark by K. Fisher on bug 9416). No change should be visible It also suppresses the ability to edit order "vendor note" in reception, as the note for vendor is not made to be changed after the document is received. Test plan : - in a basket, try to edit the notes (internal and vendor) of order. Check the display is correct - go in reception module (parcel.pl page) : in the list of all orders to receive, you must have a link to change "internal note", but no more link to change "vendor note" - try to receive a specific order which have a "vendor note". On the right panel of the page, you must have an editable textarea for internal note, and a non-editable (colored in grey) textarea for vendor note -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12111 paxed <pasi.kallinen@pttk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen@pttk.fi --- Comment #2 from paxed <pasi.kallinen@pttk.fi> --- Small nitpick: "Change order vendor note vendor note" - note the doubled "vendor note" -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12111 --- Comment #4 from mathieu saby <mathsabypro@gmail.com> --- oups, I wrote it to quickly :( I'll fix that this week end Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12111 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12111 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27311|0 |1 is obsolete| | Attachment #27649|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27661&action=edit [PASSED QA] Bug 12111: Improving templates regarding order notes This bug changes some lines in modordernotes.tt to make them more easily translatable, especially in german (remark by K. Fisher on bug 9416). No change should be visible It also suppresses the ability to edit order "vendor note" in reception, as the note for vendor is not made to be changed after the document is received. Test plan : - in a basket, try to edit the notes (internal and vendor) of order. Check the display is correct - go in reception module (parcel.pl page) : in the list of all orders to receive, you must have a link to change "internal note", but no more link to change "vendor note" - try to receive a specific order which have a "vendor note". On the right panel of the page, you must have an editable textarea for internal note, and a non-editable (colored in grey) textarea for vendor note Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12111 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with a follow-up that replaces the textarea with a span when displaying the vendor note on the order receiving page. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12111 --- Comment #10 from Yohann Dufour <yohann.dufour@biblibre.com> --- Created attachment 29576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29576&action=edit Bug 12111: (follow-up) fix breadcrumbs wording for vendor note As asked by QAer, this followup fixes wording in modordernotes.tt for vendor note (Change order vendor note vendor note => Change order vendor note) It also uses [%- and -%] to make code more readable Test plan : try to edit a vendor note, check the wording is correct in breadcrumbs Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, should be nicely translatable now. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12111 --- Comment #11 from Yohann Dufour <yohann.dufour@biblibre.com> --- I'm sorry for the last comment, I've done a mistake with git bz -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12111 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj@kohaaloha.com Status|Pushed to Master |Pushed to Stable --- Comment #12 from Mason James <mtj@kohaaloha.com> --- (In reply to Galen Charlton from comment #8)

Pushed to master,

Possible selection for 3.16.x -- You are receiving this mail because: You are watching all bug changes.