[Bug 8522] New: Markup errors cause problems with customized CSS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8522 Priority: P5 - low Change sponsored?: --- Bug ID: 8522 Assignee: oleonard@myacpl.org Summary: Markup errors cause problems with customized CSS Severity: normal Classification: Unclassified OS: All Reporter: oleonard@myacpl.org Hardware: All Status: ASSIGNED Version: master Component: Templates Product: Koha Created attachment 11198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11198&action=edit Screenshot showing the header background problem A few files have markup errors which are causing display problems when a custom stylesheet is set up to override the background of the #header region. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8522 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11199&action=edit Bug 8522 - Markup errors cause problems with customized CSS Some includes and templates contained duplicate "header" ids in the markup. The problem should have come up in routine page validation, but was obvious when custom CSS was applied. To test, load any of the affected pages and validate the generated HTML. There should be no errors about 'ID "header" already defined." Or, add custom CSS to intranetusercss: ...and confirm that only the topmost menu background is affected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8522 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8522 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Sorry, the CSS example didn't come through because it was prefixed with "#" ! #header { background : #336699 none; } -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8522 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11199|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11396&action=edit Bug 8522 - Markup errors cause problems with customized CSS Some includes and templates contained duplicate "header" ids in the markup. The problem should have come up in routine page validation, but was obvious when custom CSS was applied. To test, load any of the affected pages and validate the generated HTML. There should be no errors about 'ID "header" already defined." Or, add custom CSS to intranetusercss: ...and confirm that only the topmost menu background is affected. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8522 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8522 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com --- Comment #4 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #3)
Created attachment 11396 [details] Bug 8522 - Markup errors cause problems with customized CSS
Some includes and templates contained duplicate "header" ids in the markup. The problem should have come up in routine page validation, but was obvious when custom CSS was applied.
To test, load any of the affected pages and validate the generated HTML. There should be no errors about 'ID "header" already defined." Or, add custom CSS to intranetusercss:
...and confirm that only the topmost menu background is affected.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
patch look good, passing QA mason@xen1:~/git/head$ koha-qa.pl * e6a5599 Bug 8522 - Markup errors cause problems with customized CSS koha-tmpl/intranet-tmpl/prog/en/includes/budgets-admin-search.inc koha-tmpl/intranet-tmpl/prog/en/includes/cities-admin-search.inc koha-tmpl/intranet-tmpl/prog/en/includes/patrons-admin-search.inc koha-tmpl/intranet-tmpl/prog/en/includes/roadtype-admin-search.inc koha-tmpl/intranet-tmpl/prog/en/includes/z3950-admin-search.inc koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK mason@xen1:~/git/head$ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8522 --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8522 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master. Already on stable, setting status accordingly -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org