[Bug 26184] New: Wrap at_least_one_library_not_available_for_pickup text in HTML element
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 Bug ID: 26184 Summary: Wrap at_least_one_library_not_available_for_pickup text in HTML element Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org In the opac-reserve template there are these lines: [% IF at_least_one_library_not_available_for_pickup %] <br>Note: Library policy does not allow hold/pickup of an item available locally. Please come to the library to retrieve these items [% END %] This is wording that some libraries would like to change but since it is not wrapped in an HTML element is difficult. We should wrap this in an HTML element -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 107972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107972&action=edit Bug 26184: Add html element to note in OPAC reserve template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 --- Comment #2 from Brandon J <brandon.jimenez@inlibro.com> --- Created attachment 108526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108526&action=edit Bug : 26184 - element missing a proper HTML element Signed-off-by: Brandon J <brandon.jimenez@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 Brandon J <brandon.jimenez@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brandon.jimenez@inlibro.com Status|Needs Signoff |Signed Off --- Comment #3 from Brandon J <brandon.jimenez@inlibro.com> --- to test : 2 -before applying the patch : 3 -- 1 Home (OPAC) 4 -- 2 Click on a book 5 -- 3 Click Place Hold 6 NOTE: if you don't see the text, the library has to disable hold. 7 To disable Hold: 8 -- 1 HOME (Intranet) 9 -- 2 Preferences 10 -- 3 Search for OPACHoldsIfAvailableAtPickup and turn it to "Don't allow" 11 12 - APPLY PATCH 13 - Retest (in the inspector the note is enclosed now by a SPAN tag) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 Brandon J <brandon.jimenez@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Hi Brandon, Thanks for looking at this and testing. Did you sign-off on this patch? Looks like you added a sign-off but didn't change the status to signed-off. Looks like you also supplied a patch which includes some changes to updatedatabase.pl, I am going to mark that patch as obsolete. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108526|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Wrap |Wrap opac-reserve.tt note |at_least_one_library_not_av |text in HTML element |ailable_for_pickup text in | |HTML element | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107972|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 110401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110401&action=edit Bug 26184: Add html element to note in OPAC reserve template Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- I signed-off using Brandon J's test plan in comment 3 - feel free to change the sign off attribution to Brandon J! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Wrap opac-reserve.tt note |Wrap opac-reserve.tt note |text in HTML element |text in a div element -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Wrap opac-reserve.tt note |Wrap 'items available for |text in a div element |pick-up' note when placing | |a hold in the OPAC in a div | |element -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110401|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110427&action=edit Bug 26184: Add div element to 'items available' note in OPAC reserve template Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |oleonard@myacpl.org --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Why this class name? Isn't it just a note? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #8)
Why this class name? Isn't it just a note?
Jonathan, would you rather the class name be something else? I don't mind changing it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- class="note"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, as the stated intention here was to be able to change the text, a specific class (or id) makes more sense. With possibly changing translations hooking the jQuery on a test or word is not ideal. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- test = text... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.06 released in| | --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Status|Pushed to master |Pushed to stable --- Comment #15 from Aleisha Amohia <aleisha@catalyst.net.nz> --- enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org