[Bug 18936] New: Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Bug ID: 18936 Summary: Convert issuingrules fields to circulation_rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Depends on: 18930 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 [Bug 18930] Move lost item refund rules to circulation_rules table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65247&action=edit Bug 18936 - Convert issuingrules fields to circulation_rules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65248&action=edit Bug 18936: (followup) Fix upgrade step -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65249&action=edit Bug 18936: Fix api/v1/holds.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #4 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 67629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67629&action=edit Bug 18936: (follow-up) Add foreign key and scope enhancement to circ rules This necessitates moving the circ rules from using '*' to using undef/NULL. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #5 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 67758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67758&action=edit Bug 18936: (follow-up) Update REST definition for /.../kinds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please don't forget to assign your bugs to yourself! (Is it Kyle or Jesse here?) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jesse Weaver <pianohacker@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15522 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 [Bug 15522] New interface for revamped circulation rules -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #7 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 68236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68236&action=edit Bug 18936: (follow-up) fix rental odiscount lookup -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.bourgault@inlibro.com --- Comment #8 from David Bourgault <david.bourgault@inlibro.com> --- No test plan? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65247|0 |1 is obsolete| | --- Comment #9 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 71034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71034&action=edit Bug 18936 - Convert issuingrules fields to circulation_rules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65248|0 |1 is obsolete| | --- Comment #10 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 71035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71035&action=edit Bug 18936: (followup) Fix upgrade step -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65249|0 |1 is obsolete| | --- Comment #11 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 71036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71036&action=edit Bug 18936: Fix api/v1/holds.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67629|0 |1 is obsolete| | --- Comment #12 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 71037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71037&action=edit Bug 18936: (follow-up) Add foreign key and scope enhancement to circ rules This necessitates moving the circ rules from using '*' to using undef/NULL. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67758|0 |1 is obsolete| | --- Comment #13 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 71038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71038&action=edit Bug 18936: (follow-up) Update REST definition for /.../kinds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68236|0 |1 is obsolete| | --- Comment #14 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 71039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71039&action=edit Bug 18936: (follow-up) fix rental odiscount lookup -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #15 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 71040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71040&action=edit Bug 18936: (follow-up) Remove issuingrules from kohastructure.sql -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #16 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 71041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71041&action=edit Bug 18936: (follow-up) fix tests, null vs. empty behavior for limiting rules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71034|0 |1 is obsolete| | --- Comment #17 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 72230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72230&action=edit Bug 18936 - Convert issuingrules fields to circulation_rules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71035|0 |1 is obsolete| | --- Comment #18 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 72231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72231&action=edit Bug 18936: (followup) Fix upgrade step -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71036|0 |1 is obsolete| | --- Comment #19 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 72232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72232&action=edit Bug 18936: Fix api/v1/holds.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71037|0 |1 is obsolete| | --- Comment #20 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 72233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72233&action=edit Bug 18936: (follow-up) Add foreign key and scope enhancement to circ rules This necessitates moving the circ rules from using '*' to using undef/NULL. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71038|0 |1 is obsolete| | --- Comment #21 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 72234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72234&action=edit Bug 18936: (follow-up) Update REST definition for /.../kinds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71039|0 |1 is obsolete| | --- Comment #22 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 72235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72235&action=edit Bug 18936: (follow-up) fix rental odiscount lookup -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71040|0 |1 is obsolete| | --- Comment #23 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 72236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72236&action=edit Bug 18936: (follow-up) Remove issuingrules from kohastructure.sql -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71041|0 |1 is obsolete| | --- Comment #24 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 72237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72237&action=edit Bug 18936: (follow-up) fix tests, null vs. empty behavior for limiting rules -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #25 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 72238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72238&action=edit Bug 18936: (follow-up) Fix tests, replace old get_onshelfholds_policy method -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #26 from Séverine Queune <severine.queune@bulac.fr> --- Hi Jesse, how could this one be tested ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Kyle, assigning this to you, ok? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle@bywatersolutions.com |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have started a rebase but it's getting very hard here. I will wait a bit for other patches to get attention. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Just for reference: https://gitlab.com/joubu/Koha/commits/bug_18936 It is not supposed to be tested, I am not expecting it to work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Remove branch rebased and updated. TODO: "notes for rule" is certainly broken (bug 12365) Kyle, I have now 1 line per category and item type on the circ rule admin page, is that expected? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72230|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72231|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72232|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72233|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72234|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72235|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72236|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72237|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72238|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #30)
Remove branch rebased and updated.
TODO: "notes for rule" is certainly broken (bug 12365)
Kyle, I have now 1 line per category and item type on the circ rule admin page, is that expected?
If I understand what you are saying, the answer is yes. From the user perspective, the circ rules should look pretty much the same as they always have. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- No it did not, that's why I asked :) I pushed another commit that fixes the problem I got. Thanks for the answer! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #33 from Owen Leonard <oleonard@myacpl.org> --- Is this ready for testing? When I run updatedatabase I get some errors: DEV atomic update: bug_18925.perl DBD::mysql::db selectrow_array failed: Table 'koha_kohadev.branch_borrower_circ_rules' doesn't exist [for Statement " SHOW COLUMNS FROM branch_borrower_circ_rules WHERE Field = ? "] at /home/vagrant/kohaclone/C4/Installer.pm line 531. ...etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #33)
Is this ready for testing? When I run updatedatabase I get some errors:
DEV atomic update: bug_18925.perl DBD::mysql::db selectrow_array failed: Table 'koha_kohadev.branch_borrower_circ_rules' doesn't exist [for Statement " SHOW COLUMNS FROM branch_borrower_circ_rules WHERE Field = ? "] at /home/vagrant/kohaclone/C4/Installer.pm line 531.
...etc.
Hi Owen, I have rebased the whole dependency tree and updated the remote branch. The upgrade process should pass if the DB structure comes from master. However I have seen those errors if you run it twice. It is a bug in column_exists that does not test if the table still exist. I am not confident with the patches from this bug report (lot of rebases), maybe it would be better to validate that the ones from the deps are ok. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.com/joubu/Ko | |ha/commits/bug_18936 --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Remote branch rebased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22472 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8858 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8858 [Bug 8858] C4::Circulation::GetBranchItemRule is poorly written -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|8858 | --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 8858 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8858 [Bug 8858] C4::Circulation::GetBranchItemRule is poorly written -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22284 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 [Bug 22284] Groups of pickup locations for holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset@biblibre.co | |m --- Comment #37 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Should this bug be in "assigned" instead of "Needs Signoff"? updatedabase fails: logs: https://framabin.org/p/?ee2bc83c735fb710#wvTUZlLVsrUIoShkp6kyGxpjY9Ov3osvFLl... dump: latest MARC21 http://git.koha-community.org/gitweb/?p=contrib/global.git;a=history;f=sandb... code:7ca6504be2d9ce96ef929c90b3b83a84a935244e https://gitlab.com/joubu/Koha/commits/bug_18936 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |wizzyrea@gmail.com --- Comment #38 from Liz Rea <wizzyrea@gmail.com> --- I think these errors will put this on a failed QA state (Sorry Jonathan...) Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #29)
Just for reference: https://gitlab.com/joubu/Koha/commits/bug_18936
It is not supposed to be tested, I am not expecting it to work correctly.
Remote branch rebased. Previous comment still applies, please focus on dependencies first. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano@theke.io Blocks|22284 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 [Bug 22284] Groups of pickup locations for holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Bug 18936 depends on bug 18930, which changed state. Bug 18930 Summary: Move lost item refund rules to circulation_rules table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #40 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 91953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91953&action=edit Bug 18936: Convert issuingrules fields to circulation_rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #41 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 91954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91954&action=edit Bug 18936: (followup) Fix upgrade step -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #42 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 91955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91955&action=edit Bug 18936: Fix api/v1/holds.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 91956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91956&action=edit Bug 18936: (follow-up) Add foreign key and scope enhancement to circ rules This necessitates moving the circ rules from using '*' to using undef/NULL. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #44 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 91957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91957&action=edit Bug 18936: (follow-up) Update REST definition for /.../kinds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #45 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 91958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91958&action=edit Bug 18936: (follow-up) fix rental odiscount lookup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #46 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 91959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91959&action=edit Bug 18936: (follow-up) Remove issuingrules from kohastructure.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 91960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91960&action=edit Bug 18936: (follow-up) fix tests, null vs. empty behavior for limiting rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #48 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 91961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91961&action=edit Bug 18936: (follow-up) Fix tests, replace old get_onshelfholds_policy method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #49 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 91962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91962&action=edit Bug 18936: move get_opacitemholds_policy method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #50 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 91963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91963&action=edit Bug 18936: Move guess_article_requestable_itemtypes method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #51 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 91964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91964&action=edit Bug 18936: Remove last bit of Koha::IssuingRule -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #52 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 91965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91965&action=edit Bug 18936: Fix syntax issue TODO: Replace croak with exceptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #53 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 91966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91966&action=edit Bug 18936: Fix several issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #54 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 91967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91967&action=edit Bug 18936: chargename removed by bug 21753 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #55 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 91968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91968&action=edit Bug 18936: new suspension_chargeperiod -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #56 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 91969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91969&action=edit Bug 18936: new holds_per_day -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #57 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 91970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91970&action=edit Bug 18936: Replace an other insert into issuingrules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #58 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 91971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91971&action=edit Bug 18936: Fix Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #59 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 91972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91972&action=edit Bug 18936: More fixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #60 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 91973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91973&action=edit Bug 18936: Add missing filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #61 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 91974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91974&action=edit Bug 18936: Fix Update DB entry -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91974|0 |1 is obsolete| | --- Comment #62 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 91975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91975&action=edit Bug 18936: Fix Update DB entry -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #63 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is now ready for testing! The remote branch has been rebased and adjusted. Patches attached to this bug report as well. Test plan: - checkout master and create several circulation rules - apply these patches and run the updatedatabase.pl script - confirm that the screen displays the correct value - add/edit/delete rules and confirm that there is no regression - focus on empty strings vs 0 vs undef values - pick some rules you know well and confirm the restrictions applies accordingly to the values you have defined (renewalsallowed for instance) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23323 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23323 [Bug 23323] Koha::RefundLostItemFeeRules->find() should require `branchcode`, `categorycode` and `itemtype` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91953|0 |1 is obsolete| | Attachment #91954|0 |1 is obsolete| | Attachment #91955|0 |1 is obsolete| | Attachment #91956|0 |1 is obsolete| | Attachment #91957|0 |1 is obsolete| | Attachment #91958|0 |1 is obsolete| | Attachment #91959|0 |1 is obsolete| | Attachment #91960|0 |1 is obsolete| | Attachment #91961|0 |1 is obsolete| | Attachment #91962|0 |1 is obsolete| | Attachment #91963|0 |1 is obsolete| | Attachment #91964|0 |1 is obsolete| | Attachment #91965|0 |1 is obsolete| | Attachment #91966|0 |1 is obsolete| | Attachment #91967|0 |1 is obsolete| | Attachment #91968|0 |1 is obsolete| | Attachment #91969|0 |1 is obsolete| | Attachment #91970|0 |1 is obsolete| | Attachment #91971|0 |1 is obsolete| | Attachment #91972|0 |1 is obsolete| | Attachment #91973|0 |1 is obsolete| | Attachment #91975|0 |1 is obsolete| | --- Comment #64 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94179&action=edit Bug 18936: Convert issuingrules fields to circulation_rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #65 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94180&action=edit Bug 18936: (followup) Fix upgrade step -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #66 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94181&action=edit Bug 18936: Fix api/v1/holds.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #67 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94182&action=edit Bug 18936: (follow-up) Add foreign key and scope enhancement to circ rules This necessitates moving the circ rules from using '*' to using undef/NULL. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #68 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94183&action=edit Bug 18936: (follow-up) Update REST definition for /.../kinds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #69 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94184&action=edit Bug 18936: (follow-up) fix rental odiscount lookup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #70 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94185&action=edit Bug 18936: (follow-up) Remove issuingrules from kohastructure.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #71 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94186&action=edit Bug 18936: (follow-up) fix tests, null vs. empty behavior for limiting rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #72 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94187&action=edit Bug 18936: (follow-up) Fix tests, replace old get_onshelfholds_policy method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #73 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94188&action=edit Bug 18936: move get_opacitemholds_policy method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #74 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94189&action=edit Bug 18936: Move guess_article_requestable_itemtypes method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #75 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94190&action=edit Bug 18936: Remove last bit of Koha::IssuingRule -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #76 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94191&action=edit Bug 18936: Fix syntax issue TODO: Replace croak with exceptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #77 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94192&action=edit Bug 18936: Fix several issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #78 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94193&action=edit Bug 18936: chargename removed by bug 21753 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #79 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94194&action=edit Bug 18936: new suspension_chargeperiod -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #80 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94195&action=edit Bug 18936: new holds_per_day -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #81 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94196&action=edit Bug 18936: Replace an other insert into issuingrules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #82 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94197&action=edit Bug 18936: Fix Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #83 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94198&action=edit Bug 18936: More fixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #84 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94199&action=edit Bug 18936: Add missing filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #85 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94200&action=edit Bug 18936: Fix Update DB entry -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |josef.moravec@gmail.com --- Comment #86 from Josef Moravec <josef.moravec@gmail.com> --- sorry, tried to apply, but got: Applying: Bug 18936: More fixes error: sha1 information is lacking or useless (C4/Reserves.pm). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #87 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think this bug probably warrants the 'Just a git branch' approach and should have the patches removed from here.. those capable of testing this should be capable of adding a remote and checking out the branch that Jonathan is maintaining :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA --- Comment #88 from Josef Moravec <josef.moravec@gmail.com> --- I tested using git branch and found two issues: - holds per day are not transferred in database update - in note column, I can see link "view notes" even if there is no note - if the rule is specific for library and patron category, or for library and itemtype, the rules for current checkouts allowed and current on-site checkouts allowed are not transferred - No automatic renewal after (hard limit) does not respect dateformat and is shown in iso format - Overdue fines cap (amount) is not possible to edit in GUI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #89 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Josef Moravec from comment #88) Hi Josef, thanks for testing this!
I tested using git branch and found two issues:
- holds per day are not transferred in database update
Fixed!
- in note column, I can see link "view notes" even if there is no note
Fixed!
- if the rule is specific for library and patron category, or for library and itemtype, the rules for current checkouts allowed and current on-site checkouts allowed are not transferred
I do not recreate that. checkout master create specific rule for CPL and a given patron's category checkout bug_18936 update => I do see the value for current checkouts allowed
- No automatic renewal after (hard limit) does not respect dateformat and is shown in iso format
Fixed!
- Overdue fines cap (amount) is not possible to edit in GUI
I do not recreate: Edit the line Modify the value for 'Overdue fines cap (amount)' Save => The value is correctly displayed in the table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94179|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94180|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94181|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94182|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94183|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94184|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94185|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94186|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94187|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94188|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94189|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94190|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94191|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94192|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94193|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94194|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94195|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94196|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94197|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94198|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94199|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94200|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #90 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This all scans well, if you get a chance it would be great to have a final SO/QA by January as it's one I'm targetting for an early push. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |joonas.kylmala@helsinki.fi --- Comment #91 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Hi Jonathan, failing the patches "Bug 18936: More fixes", "Bug 18936: Fix Circulation.t", "Bug 18936: Fix several issues" and "Bug 18936: Fix Update DB entry" since they miss description of the changes so there is no way to know what is the intended change here therefore testing will be super difficult. Also with "Bug 18936: Fix several issues" it would be more logical to have then several commits for those. So I will take a look again once the descriptions of changes are added, ok? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #92 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Joonas Kylmälä from comment #91)
Hi Jonathan,
failing the patches "Bug 18936: More fixes", "Bug 18936: Fix Circulation.t", "Bug 18936: Fix several issues" and "Bug 18936: Fix Update DB entry" since they miss description of the changes so there is no way to know what is the intended change here therefore testing will be super difficult. Also with "Bug 18936: Fix several issues" it would be more logical to have then several commits for those.
So I will take a look again once the descriptions of changes are added, ok?
Hi Joonas, Those patches are follow-up sI submitted when I retested the feature after a feature. I can understand they do not make sense in the git log, but they do for me (as I am rebasing this for 2 years now). I would suggest to squash the patches when reviewing them, and you will see that the changes make sense. Fix Circulation.t: Make the tests Circulation.t pass (maxissueqty was missing when the rule was created) Fix several issues: branchcode, categorycode and itemtype are no longer mandatory to create a new rule Fix Update DB entry: Some rules were missing (or added when they should not). Also branchcode, categorycode and itemtype must not be '*' but NULL, otherwise the FK constraint will not be satisfied. We are at Signoff step, that should not block testers to test this feature. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #93 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patches rebased. There is one test that is failing I do not manage to fix (t/db_dependent/Koha/Charges/Fees.t). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #94 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Testers should consider using the branch bug_18936 from my koha-misc4dev repo to fix reset_all: https://gitlab.com/joubu/koha-misc4dev/commits/bug_18936 Will be cleaned and merged into master when these patches will be pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle@bywatersolutions.com |joonas.kylmala@helsinki.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Minna Kivinen <minna.kivinen@hamk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |minna.kivinen@hamk.fi --- Comment #95 from Minna Kivinen <minna.kivinen@hamk.fi> --- Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Tested following: - Added several rules for different combinations of patron category and item type - Modified rules - Removed rules - Added new rules - Tested functionalities against rules: Hard due date, Loan period, Loans allowed (total), Renewals allowed (count), No renewal before, Holds allowed (total) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Minna Kivinen <minna.kivinen@hamk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #96 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Problems I noticed after doing database upgrade and comparing the web page before db upgrade and after db upgrade: - The "Clone these rules to: " feature is missing after the patch set - "Holds allowed (daily)" was previously empty now with the patch set it says "Unlimited" - "Fine amount" is now with 6 decimals instead of previous 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #97 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- (In reply to Joonas Kylmälä from comment #96)
- "Holds allowed (daily)" was previously empty now with the patch set it says "Unlimited"
This is fine, the empty value previously also meant "Unlimited", here it is just made explicit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #98 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Even though it should be allowed, I get this error message when making a hold for Student patron for Music item: "Daily hold limit reached for patron". I have rules: category = Student, itemtype = Music, Holds allowed (daily) = Unlimited and category = All, itemtype = ALL, Holds allowed (daily) = 0 If for the latter "All rule" I change it to 1 then things work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Minna Kivinen <minna.kivinen@hamk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #99 from Minna Kivinen <minna.kivinen@hamk.fi> --- Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Tested following: - Added several rules for different combinations of patron category and item type - Modified rules - Removed rules - Added new rules - Tested functionalities against rules: Hard due date, Loan period, Loans allowed (total), Renewals allowed (count), No renewal before, Holds allowed (total) - Tested especially empty values on rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #100 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Minna Kivinen from comment #99)
Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Tested following: - Added several rules for different combinations of patron category and item type - Modified rules - Removed rules - Added new rules - Tested functionalities against rules: Hard due date, Loan period, Loans allowed (total), Renewals allowed (count), No renewal before, Holds allowed (total) - Tested especially empty values on rules
Thank you! I have added your signed-off-by lines to the commit messages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #101 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- The qa-koha.pl tool detected an issue with constant being redefined:
FAIL Koha/CirculationRules.pm FAIL valid Constant subroutine >Koha::CirculationRules::GUESSED_ITEMTYPES_KEY redefined
This appears to be from circular dependency: Koha/CirculationRules.pm -> Koha/CirculationRule.pm -> Koha/ItemTypes.pm -> Koha/ItemType.pm -> Koha/CirculationRules.pm if someone has the time to remove the circularity here would be great! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #102 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Minor: Koha::CirculationRule ->item_type, ->library and ->patron_category must use the DBIC RS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #103 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Joonas Kylmälä from comment #101)
The qa-koha.pl tool detected an issue with constant being redefined:
FAIL Koha/CirculationRules.pm FAIL valid Constant subroutine >Koha::CirculationRules::GUESSED_ITEMTYPES_KEY redefined
This appears to be from circular dependency:
Koha/CirculationRules.pm -> Koha/CirculationRule.pm -> Koha/ItemTypes.pm -> Koha/ItemType.pm -> Koha/CirculationRules.pm
if someone has the time to remove the circularity here would be great!
I would not care much about that. Note that the QA script is ignoring the "subroutine ... redefined" warning. Here it displays "Constant subroutine ... redefined" and that is why it's not ignored. The circular dependency already existed: % git checkout master % perl -wc Koha/CirculationRules.pm Subroutine get_effective_rule redefined at Koha/CirculationRules.pm line 42. Subroutine set_rule redefined at Koha/CirculationRules.pm line 82. Subroutine set_rules redefined at Koha/CirculationRules.pm line 140. Subroutine delete redefined at Koha/CirculationRules.pm line 171. Subroutine _type redefined at Koha/CirculationRules.pm line 184. Subroutine object_class redefined at Koha/CirculationRules.pm line 192. Koha/CirculationRules.pm syntax OK -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #104 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've given this a look over myself now and am pretty happy.. as soon as we have your stamp of approval Joonas we'll go for it! :) Well done guys! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #105 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- I would still like to wait Joubu to update https://gitlab.com/joubu/koha-misc4dev/commits/bug_18936 so that using that branch all the tests pass again. The defaults currently differ from the original values and therefore the tests don't pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #106 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- (In reply to Joonas Kylmälä from comment #105)
I would still like to wait Joubu to update https://gitlab.com/joubu/koha-misc4dev/commits/bug_18936 so that using that branch all the tests pass again. The defaults currently differ from the original values and therefore the tests don't pass.
I can actually just do upgradedatabase from master and run the tests so this is not necessary. Sorry for the noise. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #107 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- I followed the test plan, and as requested there to test some specific rules I know, I choose to test hold related rules and renewal rules. Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Big thanks for all involved on this 2+ years old bug! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #108 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98299&action=edit Bug 18936: Convert issuingrules fields to circulation_rules Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #109 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98300&action=edit Bug 18936: (followup) Fix upgrade step Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #110 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98301&action=edit Bug 18936: Fix api/v1/holds.t Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #111 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98302&action=edit Bug 18936: (follow-up) Add foreign key and scope enhancement to circ rules This necessitates moving the circ rules from using '*' to using undef/NULL. Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #112 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98303&action=edit Bug 18936: (follow-up) Update REST definition for /.../kinds Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #113 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98304&action=edit Bug 18936: (follow-up) fix rental odiscount lookup Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #114 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98305&action=edit Bug 18936: (follow-up) Remove issuingrules from kohastructure.sql Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #115 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98306&action=edit Bug 18936: (follow-up) fix tests, null vs. empty behavior for limiting rules Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #116 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98307&action=edit Bug 18936: (follow-up) Fix tests, replace old get_onshelfholds_policy method Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #117 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98308&action=edit Bug 18936: move get_opacitemholds_policy method Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #118 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98309&action=edit Bug 18936: Move guess_article_requestable_itemtypes method Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #119 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98310&action=edit Bug 18936: Remove last bit of Koha::IssuingRule Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #120 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98311&action=edit Bug 18936: Fix syntax issue TODO: Replace croak with exceptions Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #121 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98312&action=edit Bug 18936: Fix several issues Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #122 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98313&action=edit Bug 18936: chargename removed by bug 21753 Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #123 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98314&action=edit Bug 18936: new suspension_chargeperiod Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #124 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98315&action=edit Bug 18936: new holds_per_day Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #125 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98316&action=edit Bug 18936: Replace an other insert into issuingrules Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #126 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98317&action=edit Bug 18936: Fix Circulation.t Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #127 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98318&action=edit Bug 18936: More fixes Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #128 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98319&action=edit Bug 18936: Add missing filters Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #129 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98320&action=edit Bug 18936: Fix Update DB entry Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #130 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98321&action=edit Bug 18936: fixes from comment #88 - holds per day are not transferred in database update (actually not displayed) - in note column, I can see link "view notes" even if there is no note - No automatic renewal after (hard limit) does not respect dateformat and is shown in iso format Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #131 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98322&action=edit Bug 18936: Fix warning about page about wrong lengthunit Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #132 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98323&action=edit Bug 18936: (follow-up) Don't retrieve unused issuing rule The chargename rule is not used anywhere in the code Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #133 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98324&action=edit Bug 18936: Fix some more tests * CanItemBeReserved Prior to "Bug 18936: Convert issuingrules fields to circulation_rules", GetHoldRule returned holds_per_record even if no reservesallowed was defined. This change restores this behavior. FIXME Note: In GetHoldRule we return itemtype only if reservesallowed is set, not sure it is correct. * t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t When setting returnbranch, holdallowed and hold_fulfillment_policy, we should not provide categorycode. * t/db_dependent/Holds.t Prefer to keep the existing rules instead of removing them. It got quite hard to understand what was going on here because of the mixup with the rule reservesallowed that was in issuingrules, and the other rules we used for the tests. Also, categorycode should not be passed to set those 3 rules (holdallowed, hold_fulfillment_policy and returnbranch) * t/db_dependent/Circulation.t Setting lengthunit to 'hours', no need to make sure the rule has been correctly be saved * t/db_dependent/Circulation/CalcDateDue.t It uses hardcoded data that is not in the sample data (categorycode=C). Let use K that exists and postpone a refactore of the whole script (to make it create the data it needs). * t/db_dependent/Circulation/ReturnClaims.t * t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t Simple replace Koha::IssuingRule with Koha::CirculationRules * t/db_dependent/Koha/Charges/Fees.t => FIXME Still failing, stuck here, need help Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #134 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98325&action=edit Bug 18936: (follow-up) Add missing circulation rule to fix tests The tests passed before by a chance because the default kohadevbox installation script added a issuing rule that had lengthunit = days. If you use a Koha version before the commits introduced by Bug 18936 you can reproduce the Fees.t tests failing by deleting all the issuing rules from database with
delete issuingrules;
and then running $ prove t/db_dependent/Koha/Charges/Fees.t Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #135 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98326&action=edit Bug 18936: Make sure we default to '*' if no rule exist Making sure the code is doing what we expect. Also this patch fix CirculationRules.t Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #136 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98327&action=edit Bug 18936: Insert default rules during the onboarding tool Those default values have been picked from bug 15522 (Koha::CirculationRules) Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #137 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98328&action=edit Bug 18936: Replace '*' with undef No test was provided initially so considering out of the scope for this one as well, but that's lacking terribly! Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #138 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98329&action=edit Bug 18936: Fix the delete rule buttons The itemtype and categorycode were always set to '*' Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #139 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98330&action=edit Bug 18936: (follow-up 2) Add foreign key and scope enhancement to circ rules The previous patch modifies: - categorycode => undef, - itemtype => undef, - branchcode => $branch, + branchcode => undef, But in that condition $branchcode is not '*' and so we should not set it to undef Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #140 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98331&action=edit Bug 18936: (follow-up) Fix typo in documentation Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #141 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98332&action=edit Bug 18936: (follow-up) Add missing import of Koha::CirculationRules Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #142 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98333&action=edit Bug 18936: Fix inconsistencies in IssuingRules.t * get_effective_rule should not pass rule_value * indentation fix * add comment to list the rules we have when the test _is_row_match is executed * compare ->rule_name and ->rule_value returns Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #143 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98334&action=edit Bug 18936: (follow-up2) Fix tests, replace old get_onshelfholds_policy method Previous change to this file was different from the one that existed prior to this patchset. Restoring value for onshelfholds, note that it did not change anything in the test result. Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #144 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98335&action=edit Bug 18936: (follow-up) Add cloning of circulation rules back to Koha The "Clone these rules" feature in admin/smart-rules.pl was dropped. This re-implements the cloning using Koha objects. Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #145 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98336&action=edit Bug 18936: (follow-up) Make possible to have unlimited value for holds_per_day Without this it is not possible to make for a specific patron category or itemtype a more specific unlimited holds_per_day rule if you have a catch all rule (categorycode = *, itemtype = *) with limited holds_per_day value. Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #146 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98337&action=edit Bug 18936: (follow-up2) Make possible to have unlimited value for holds_per_day Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #147 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98338&action=edit Bug 18936: Fix IssuingRules/guess_article_requestable_itemtypes.t Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #148 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98339&action=edit Bug 18936: (follow-up) Adjust circ rule related tests so that they pass Bunch of tests broke after moving from issuingrules to circulation_rules. This accomodates the tests for this refactoring and DB change. Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #149 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98340&action=edit Bug 18936: (follow-up2) Adjust circ rule related tests so that they pass The itemtype did not exist in the DB. We create it at the beginning of the tests. Ideally we would like to create it filling the form. Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #150 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98341&action=edit Bug 18936: (follow-up) Fix checkouts endpoint and its tests - Fixes a bug caused by the refactoring in Koha/REST/V1/Checkouts.pm (run the tests without this patch and you will see the tests fails because 'rule_name' parameter was forgotten). - Changes the tests to use the new Koha::CirculationRule objects instead of directly using issuingrules DB table Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #151 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98342&action=edit Bug 18936: (QA follow-up) Add missing POD Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #152 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98343&action=edit Bug 18936: (follow-up) More fixes Previous "More fixes" patch added a debugging statement, not needed. Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #153 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98344&action=edit Bug 18936: (QA follow-up) Convert remaining tests to use Koha::CirculationRules These two uses of Koha::IssuingRule were forgotten so this converts them to use the new Koha::CirculationRules object. Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #154 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98345&action=edit Bug 18936: Remove 2 new occurrences of Koha::IssuingRules Fix conflict with bug 13121 Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #155 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98346&action=edit Bug 18936: (QA follow-up) Fix failing test Using categorycode as a scope is not possible for any of these rules so lets remove it. Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #156 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98347&action=edit Bug 18936: Fix failing test in api/v1/holds.t Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #157 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #158 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Guys, this has been a real stirling effort! Thanks to all involved in pushing it over the finish line, amazing work! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_target | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #159 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98407&action=edit Bug 18936: Display 'Unlimited' for Holds allowed (total) holds_per_day and reservesallowed are set to unlimited in the rules inserted by misc4dev -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #160 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98408&action=edit Bug 18936: Fix selenium/administration_tasks.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #161 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24602 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602 [Bug 24602] The fallback value for onshelfholds should be 0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #162 from Joy Nelson <joy@bywatersolutions.com> --- Not backporting to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.isherwood@ptfs-europ | |e.com Blocks| |24083 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 [Bug 24083] Koha should support "seen" vs "unseen" renewals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24669 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24669 [Bug 24669] Editing circulation rule breaks holds when total holds unlimited -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24670 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24670 [Bug 24670] Circulation and fine rules page has performance issues since issuingrules change -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Database tables have release notes| |changed. CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Database tables have |As part of ongoing efforts release notes|changed. |to simplify and enhance the | |circulation rules system, | |the `issuingrules` table | |has been removed and | |replaced by a new | |`circulation_rules` table. | | | |Any reports that may have | |used the issueingrules | |table will need to be | |updated to utilise the | |updated database structure. Summary|Convert issuingrules fields |Move issuingrules into |to circulation_rules |circulation_rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25556 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25556 [Bug 25556] Holds blocked when empty holdallowed value present in circulation_rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24159 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 [Bug 24159] Short loan collection issues on a day marked as closed (move useDaysMode to circ rules) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26910 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26911 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911 [Bug 26911] Update for 18936 can cause data loss if constraints are violated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29705 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 [Bug 29705] Test suite has some IssuingRules left-overs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Andrew Isherwood <bugzilla@warmlight.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla@warmlight.co.uk | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36017 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36017 [Bug 36017] Dead code in admin/clone-rules -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org