[Bug 22527] New: Web installer links to wrong database manual when database user doesn't have required privileges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 Bug ID: 22527 Summary: Web installer links to wrong database manual when database user doesn't have required privileges Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: lari.taskula@hypernova.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Target Milestone: --- To reproduce: 1. Use MySQL or MariaDB for your Koha installation 2. Create an empty database and point $KOHA_CONF to this database name. 3. Grant SELECT privilege to your database user, e.g. grant select on koha3.* to 'koha'@'%' identified by 'koha'; 4. Go to step 2 of web installer where it checks database connection 5. Observe the following message User koha doesn't have enough privilege on database koha. Ask for or make a change in the user's privileges. User koha must have USAGE, INSERT, UPDATE, DELETE, DROP and CREATE privileges on database koha2. Need help? See manual for PostgreSQL 6. Note "See manual for PostgreSQL" is wrong. Should be "See manual for MySQL". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 --- Comment #1 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 86698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86698&action=edit Bug 22527: Fix link to wrong database manual in web installer To reproduce: 1. Use MySQL or MariaDB for your Koha installation 2. Create an empty database and point $KOHA_CONF to this database name. 3. Grant SELECT privilege to your database user, e.g. grant select on koha3.* to 'koha'@'%' identified by 'koha'; 4. Go to step 2 of web installer where it checks database connection 5. Observe the following message User koha doesn't have enough privilege on database koha. Ask for or make a change in the user's privileges. User koha must have USAGE, INSERT, UPDATE, DELETE, DROP and CREATE privileges on database koha2. Need help? See manual for PostgreSQL 6. Note "See manual for PostgreSQL" is wrong. Should be "See manual for MySQL". 7. Apply patch 8. Refresh page and observe it now displays correct link Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 --- Comment #2 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 86699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86699&action=edit Bug 22527: Enhance visibility of error message Place database user privilege issue into a yellow box to enhance visilibty. Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lari.taskula@hypernova.fi |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86698|0 |1 is obsolete| | Attachment #86699|0 |1 is obsolete| | --- Comment #3 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87550&action=edit Bug 22527: Fix link to wrong database manual in web installer To reproduce: 1. Use MySQL or MariaDB for your Koha installation 2. Create an empty database and point $KOHA_CONF to this database name. 3. Grant SELECT privilege to your database user, e.g. grant select on koha3.* to 'koha'@'%' identified by 'koha'; 4. Go to step 2 of web installer where it checks database connection 5. Observe the following message User koha doesn't have enough privilege on database koha. Ask for or make a change in the user's privileges. User koha must have USAGE, INSERT, UPDATE, DELETE, DROP and CREATE privileges on database koha2. Need help? See manual for PostgreSQL 6. Note "See manual for PostgreSQL" is wrong. Should be "See manual for MySQL". 7. Apply patch 8. Refresh page and observe it now displays correct link Sponsored-by: Hypernova Oy Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 --- Comment #4 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87551&action=edit Bug 22527: Enhance visibility of error message Place database user privilege issue into a yellow box to enhance visilibty. Sponsored-by: Hypernova Oy Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 22366 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #6 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #5)
*** Bug 22366 has been marked as a duplicate of this bug. ***
Do we want the default of this link to be PostgreSQL? For instance, if the user is not using a MySQL database but for some reason is also not using a PostgreSQL database, they will still be pointed to the PostgreSQL manual. This could be confusing for first time users. Is this a case that could feasibly occur? I don't know enough about the types of databases that people use with Koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Hayley Mapley from comment #6)
(In reply to Katrin Fischer from comment #5)
*** Bug 22366 has been marked as a duplicate of this bug. ***
Do we want the default of this link to be PostgreSQL? For instance, if the user is not using a MySQL database but for some reason is also not using a PostgreSQL database, they will still be pointed to the PostgreSQL manual. This could be confusing for first time users. Is this a case that could feasibly occur? I don't know enough about the types of databases that people use with Koha.
I think the only databases Koha currently supports are MariaDB and MySQL - PostgreSQL support is not functional, but I think it was once an option or work had been started on it. Lari, could you comment too please? Will this work for MariaDB? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #8 from Liz Rea <wizzyrea@gmail.com> --- MariaDB and MySQL are not significantly different in this regard. To be fair, we could omit the link entirely, and tell them what to search for for their chosen DBMS. For example: For help with granting permissions, please search for $DBMS manual grant permissions or something like. Or we could not say anything at all, and expect that working with DBMS systems is something lots of people should know how to do, or that they have an IT professional somewhere up the chain they can ask who knows what to search for. This is, I feel, a less nice way to go about it but it would keep us from having to maintain this external connection (I mean, we link to MySQL manual version 4.1 - that's really old!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think Liz makes a good point about the link to the MySQL manual being quite old. Maybe having a generic message would be the best way to go here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87550|0 |1 is obsolete| | Attachment #87551|0 |1 is obsolete| | --- Comment #10 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 88084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88084&action=edit Bug 2527: web installer links to outdated DB manual To reproduce: 1. Use MySQL or MariaDB for your Koha installation 2. Create an empty database and point $KOHA_CONF to this database name. 3. Grant SELECT privilege to your database user, e.g. grant select on koha3.* to 'koha'@'%' identified by 'koha'; 4. Go to step 2 of web installer where it checks database connection 5. Observe the following message User koha doesn't have enough privilege on database koha. Ask for or make a change in the user's privileges. User koha must have USAGE, INSERT, UPDATE, DELETE, DROP and CREATE privileges on database koha2. Need help? See manual for PostgreSQL 6. Note "See manual for PostgreSQL" is wrong. Should now read Need help? For help with granting permissions, please search online for "[% dbms %] manual grant permissions" of course the dbms should be the dbms you are using. 7. Apply patch, restart all 8. Refresh page and observe it now displays correct link Test plan and original patchset by Lari Taskula <lari.taskula@hypernova.fi> Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 --- Comment #11 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 89198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89198&action=edit Bug 22527: web installer links to outdated DB manual To reproduce: 1. Use MySQL or MariaDB for your Koha installation 2. Create an empty database and point $KOHA_CONF to this database name. 3. Grant SELECT privilege to your database user, e.g. grant select on koha3.* to 'koha'@'%' identified by 'koha'; 4. Go to step 2 of web installer where it checks database connection 5. Observe the following message User koha doesn't have enough privilege on database koha. Ask for or make a change in the user's privileges. User koha must have USAGE, INSERT, UPDATE, DELETE, DROP and CREATE privileges on database koha2. Need help? See manual for PostgreSQL 6. Note "See manual for PostgreSQL" is wrong. Should now read Need help? For help with granting permissions, please search online for "[% dbms %] manual grant permissions" of course the dbms should be the dbms you are using. 7. Apply patch, restart all 8. Refresh page and observe it now displays correct link Test plan and original patchset by Lari Taskula <lari.taskula@hypernova.fi> Sponsored-by: Hypernova Oy Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lari.taskula@hypernova.fi |wizzyrea@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88084|0 |1 is obsolete| | Attachment #89198|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89374&action=edit Bug 22527: web installer links to outdated DB manual To reproduce: 1. Use MySQL or MariaDB for your Koha installation 2. Create an empty database and point $KOHA_CONF to this database name. 3. Grant SELECT privilege to your database user, e.g. grant select on koha3.* to 'koha'@'%' identified by 'koha'; 4. Go to step 2 of web installer where it checks database connection 5. Observe the following message User koha doesn't have enough privilege on database koha. Ask for or make a change in the user's privileges. User koha must have USAGE, INSERT, UPDATE, DELETE, DROP and CREATE privileges on database koha2. Need help? See manual for PostgreSQL 6. Note "See manual for PostgreSQL" is wrong. Should now read Need help? For help with granting permissions, please search online for "[% dbms %] manual grant permissions" of course the dbms should be the dbms you are using. 7. Apply patch, restart all 8. Refresh page and observe it now displays correct link Test plan and original patchset by Lari Taskula <lari.taskula@hypernova.fi> Sponsored-by: Hypernova Oy Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89375&action=edit Bug 22527: Remove extra space after '?' Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nick, not sure about the 2 spaces after '?'. I let you decide (and squash!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Included second patch and squashed Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 89452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89452&action=edit Bug 22527: (RM follow-up) Add filter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.06 released in| | CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.05.x for 18.05.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org