https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Locale is ignored when |Locale is ignored when |saving season/month/day |saving season name in the |name in the database |database -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #2 from Blou <philippe.blouin@inlibro.com> --- Created attachment 95996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95996&action=edit Bug 24172: Allow translation of seasons in serials-edit.tt and subscription-detail.tt Seasons are not handled by locales. Those generated are stored in English in the database, and the display in serials-collection.tt is translating them. But once you click on "Edit serials" or if you go straight to the subscription's display, those are displayed as in the database: in English. This patch reproduces the same trick as in serial-collection.tt and allow for the display to be translated. NOTE: this patch's testing require knowledge of translation tools. Reproducing Caroline's test: 0- Make sure you have at least one language other than English installed 1- With staff interface in English, create a subscription with a seasonal numbering pattern and frequency, with locale in your other language 2- Check the prediction pattern, note that the season names are in English not the locale language 3- Change the staff interface to other language, redo the prediction pattern test with locale in other language, note that the season names are in other language 4- Save the subscription 5- Receive an issue, note that the season name in the "Numbered" column on serials-edit.pl is in English 6- Save your issue 7- Switch interface in other language 8- Note that the season name on serials-collection is in other language 9- If you check the database, you will see the season name is in English, even though the subscription.locale is something else 10- validate the different pages: - serials-collection.pl: display is translated - serials-edit.pl: name pulled directly from db - subscription-detail.pl: name pulled directly from db - detail.pl: name pulled directly from db - opac-detail.pl: name pulled directly from db 11- APPLY THE PATCH 12- translate the string a) ./translate update <some locale> b) find the strings, translate them c) ./translate install <same locale> 13- restart Plack ? 14- validate the pages again. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Severity|enhancement |minor CC| |philippe.blouin@inlibro.com Change sponsored?|--- |Sponsored Patch complexity|--- |Small patch --- Comment #4 from Blou <philippe.blouin@inlibro.com> --- Applied it on 19.05 for our customer, it works in French. Sponsored By: Collecto (formely known as CCSR) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #5 from Blou <philippe.blouin@inlibro.com> --- Created attachment 96051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96051&action=edit Bug 24172: Allow translation of seasons in details.tt and opac-details.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95996|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 100331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100331&action=edit Bug 24172: Allow translation of seasons in serials-edit.tt and subscription-detail.tt Seasons are not handled by locales. Those generated are stored in English in the database, and the display in serials-collection.tt is translating them. But once you click on "Edit serials" or if you go straight to the subscription's display, those are displayed as in the database: in English. This patch reproduces the same trick as in serial-collection.tt and allow for the display to be translated. NOTE: this patch's testing require knowledge of translation tools. Reproducing Caroline's test: 0- Make sure you have at least one language other than English installed 1- With staff interface in English, create a subscription with a seasonal numbering pattern and frequency, with locale in your other language 2- Check the prediction pattern, note that the season names are in English not the locale language 3- Change the staff interface to other language, redo the prediction pattern test with locale in other language, note that the season names are in other language 4- Save the subscription 5- Receive an issue, note that the season name in the "Numbered" column on serials-edit.pl is in English 6- Save your issue 7- Switch interface in other language 8- Note that the season name on serials-collection is in other language 9- If you check the database, you will see the season name is in English, even though the subscription.locale is something else 10- validate the different pages: - serials-collection.pl: display is translated - serials-edit.pl: name pulled directly from db - subscription-detail.pl: name pulled directly from db - detail.pl: name pulled directly from db - opac-detail.pl: name pulled directly from db 11- APPLY THE PATCH 12- translate the string a) ./translate update <some locale> b) find the strings, translate them c) ./translate install <same locale> 13- restart Plack ? 14- validate the pages again. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This works as expected so I'm signing it off... But.. I would really like to see the logic factored out into an include file. It seems ripe for such a factoring task and would lead to less code to maintain and thus a lower likelihood of future mistakes in this area. I'd really like to see the above addressed as part of QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100888&action=edit Bug 24172: Move duplicated code to an include file -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Waiting for an answer. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I FQA it to get an answer... Will come back later. You are welcome for the follow-up. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (I did not test that it works as I described it, but guessing it is how it works reading the code) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Blou can you please double check and come back to us? I am not sure about storing 'translated' values in the db if this wasn't done before. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Blou from comment #19)

(Sorry, still hadn't come back to it as promessed)

The goal is really that it it stored in English, always.

So we are saying the same thing, maybe you should read again comment 14. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I don't think this specific needs should be merged with the Koha codebase. If you really want it you can handle it with some JS code. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|jonathan.druart@bugs.koha-c | |ommunity.org | --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #14)

So basically we have "Winter" in DB, we are editing a serial, "Hiver" is put in the input text letting the user think that it is the value in DB, you save, and "Hiver" is inserted in DB.

Maybe you are right, but this behaviour is totally wrong. We should translate it from the very beginning in that case (and update the DB data with a DB update?). I am letting another QAer tackling this one as it seems we are stuck. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #26 from Nick Clemens <nick@bywatersolutions.com> --- I think I agree with Jonathan and Katrin - we should not store the translated value in the DB if we can avoid it. The rest of these patches have no problems, they look good. I think we do need to pursue the idea of a separate edit box, perhaps using the same splitting as in the translation - get matches before season name, that is 1 inoutm the season is a translated dropdown with english in the values, then a second input for trailing. Adding a 'blank' option to dropdown will allow removing season name for special issues. I would suggest removing the changes to the edit screen and tackling the editing on a new bug. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20511 --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Bug 20511 may fix this. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100331|0 |1 is obsolete| | --- Comment #30 from Blou <philippe.blouin@inlibro.com> --- Created attachment 139803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139803&action=edit Bug 24172: Allow translation of seasons in serials-edit.tt and subscription-detail.tt Seasons are not handled by locales. Those generated are stored in English in the database, and the display in serials-collection.tt is translating them. But once you click on "Edit serials" or if you go straight to the subscription's display, those are displayed as in the database: in English. This patch reproduces the same trick as in serial-collection.tt and allow for the display to be translated. NOTE: this patch's testing require knowledge of translation tools. Reproducing Caroline's test: 0- Make sure you have at least one language other than English installed 1- With staff interface in English, create a subscription with a seasonal numbering pattern and frequency, with locale in your other language 2- Check the prediction pattern, note that the season names are in English not the locale language 3- Change the staff interface to other language, redo the prediction pattern test with locale in other language, note that the season names are in other language 4- Save the subscription 5- Receive an issue, note that the season name in the "Numbered" column on serials-edit.pl is in English 6- Save your issue 7- Switch interface in other language 8- Note that the season name on serials-collection is in other language 9- If you check the database, you will see the season name is in English, even though the subscription.locale is something else 10- validate the different pages: - serials-collection.pl: display is translated - serials-edit.pl: name pulled directly from db - subscription-detail.pl: name pulled directly from db - detail.pl: name pulled directly from db - opac-detail.pl: name pulled directly from db 11- APPLY THE PATCH 12- translate the string a) ./translate update <some locale> b) find the strings, translate them c) ./translate install <same locale> 13- restart Plack ? 14- validate the pages again. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can try to look into this one, as I've also tested bug 20511, but since I'll be on vacation next week, it won't be quick. Please switch to needs signoff or signed off (depending on the nature of the rebase) when you think this is ready for testing again. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100888|0 |1 is obsolete| | --- Comment #34 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 139805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139805&action=edit Bug 24172: Move duplicated code to an include file -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139804|0 |1 is obsolete| | --- Comment #36 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 139807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139807&action=edit Bug 24172: Allow translation of seasons in details.tt and opac-details.tt Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139803|0 |1 is obsolete| | --- Comment #38 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 139809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139809&action=edit Bug 24172: Allow translation of seasons in serials-edit.tt and subscription-detail.tt Seasons are not handled by locales. Those generated are stored in English in the database, and the display in serials-collection.tt is translating them. But once you click on "Edit serials" or if you go straight to the subscription's display, those are displayed as in the database: in English. This patch reproduces the same trick as in serial-collection.tt and allow for the display to be translated. NOTE: this patch's testing require knowledge of translation tools. Reproducing Caroline's test: 0- Make sure you have at least one language other than English installed 1- With staff interface in English, create a subscription with a seasonal numbering pattern and frequency, with locale in your other language 2- Check the prediction pattern, note that the season names are in English not the locale language 3- Change the staff interface to other language, redo the prediction pattern test with locale in other language, note that the season names are in other language 4- Save the subscription 5- Receive an issue, note that the season name in the "Numbered" column on serials-edit.pl is in English 6- Save your issue 7- Switch interface in other language 8- Note that the season name on serials-collection is in other language 9- If you check the database, you will see the season name is in English, even though the subscription.locale is something else 10- validate the different pages: - serials-collection.pl: display is translated - serials-edit.pl: name pulled directly from db - subscription-detail.pl: name pulled directly from db - detail.pl: name pulled directly from db - opac-detail.pl: name pulled directly from db 11- APPLY THE PATCH 12- translate the string a) ./translate update <some locale> b) find the strings, translate them c) ./translate install <same locale> 13- restart Plack ? 14- validate the pages again. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 24172: Allow translation of seasons in details.tt and opac-details.tt Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 24172: Move duplicated code to an include file -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139807|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal --- Comment #39 from Blou <philippe.blouin@inlibro.com> --- Hello Katrin, I noticed you made some slight turn around on this bug. Is there anything else that could be done? Although Nick sided with Jonathan, I don't think anyone refuted Caroline's arguments ont comment 23. This needs to be stored. So if we're talking transition, we're all ear! Here, and at Collecto (so about 100 large institutions total), we just apply the patch. As it was mostly (and wrongly) shown in English beforehand, it still is. At least until the user can now edit it as needed. I have a hard time imagining an atomic update that could fix that. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139809|0 |1 is obsolete| | --- Comment #41 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 148921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148921&action=edit Bug 24172: Allow translation of seasons in serials-edit.tt and subscription-detail.tt Seasons are not handled by locales. Those generated are stored in English in the database, and the display in serials-collection.tt is translating them. But once you click on "Edit serials" or if you go straight to the subscription's display, those are displayed as in the database: in English. This patch reproduces the same trick as in serial-collection.tt and allow for the display to be translated. NOTE: this patch's testing require knowledge of translation tools. Reproducing Caroline's test: 0- Make sure you have at least one language other than English installed 1- With staff interface in English, create a subscription with a seasonal numbering pattern and frequency, with locale in your other language 2- Check the prediction pattern, note that the season names are in English not the locale language 3- Change the staff interface to other language, redo the prediction pattern test with locale in other language, note that the season names are in other language 4- Save the subscription 5- Receive an issue, note that the season name in the "Numbered" column on serials-edit.pl is in English 6- Save your issue 7- Switch interface in other language 8- Note that the season name on serials-collection is in other language 9- If you check the database, you will see the season name is in English, even though the subscription.locale is something else 10- validate the different pages: - serials-collection.pl: display is translated - serials-edit.pl: name pulled directly from db - subscription-detail.pl: name pulled directly from db - detail.pl: name pulled directly from db - opac-detail.pl: name pulled directly from db 11- APPLY THE PATCH 12- translate the string a) ./translate update <some locale> b) find the strings, translate them c) ./translate install <same locale> 13- restart Plack ? 14- validate the pages again. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 24172: Allow translation of seasons in details.tt and opac-details.tt Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 24172: Move duplicated code to an include file -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #42 from Hammat wele <hammat.wele@inlibro.com> --- (In reply to Magnus Enger from comment #40)

Sorry.

$ git bz apply 24172

koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt CONFLICT (content): Merge conflict in

The patch apply now. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148921|0 |1 is obsolete| | --- Comment #44 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 151330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151330&action=edit Bug 24172: Allow translation of seasons in serials-edit.tt and subscription-detail.tt Seasons are not handled by locales. Those generated are stored in English in the database, and the display in serials-collection.tt is translating them. But once you click on "Edit serials" or if you go straight to the subscription's display, those are displayed as in the database: in English. This patch reproduces the same trick as in serial-collection.tt and allow for the display to be translated. NOTE: this patch's testing require knowledge of translation tools. Reproducing Caroline's test: 0- Make sure you have at least one language other than English installed 1- With staff interface in English, create a subscription with a seasonal numbering pattern and frequency, with locale in your other language 2- Check the prediction pattern, note that the season names are in English not the locale language 3- Change the staff interface to other language, redo the prediction pattern test with locale in other language, note that the season names are in other language 4- Save the subscription 5- Receive an issue, note that the season name in the "Numbered" column on serials-edit.pl is in English 6- Save your issue 7- Switch interface in other language 8- Note that the season name on serials-collection is in other language 9- If you check the database, you will see the season name is in English, even though the subscription.locale is something else 10- validate the different pages: - serials-collection.pl: display is translated - serials-edit.pl: name pulled directly from db - subscription-detail.pl: name pulled directly from db - detail.pl: name pulled directly from db - opac-detail.pl: name pulled directly from db 11- APPLY THE PATCH 12- translate the string a) ./translate update <some locale> b) find the strings, translate them c) ./translate install <same locale> 13- restart Plack ? 14- validate the pages again. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 24172: Allow translation of seasons in details.tt and opac-details.tt Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 24172: Move duplicated code to an include file -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #46 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #14)

Had a look again at this.

I agree with the changes in subscription-detail.tt, catalogue/detail.tt and opac-detail.tt However I am still not sure what we are doing in serials-edit.tt is correct:

(In reply to Jonathan Druart from comment #10)

...

I do not understand what is done here, why do we want to modify the value on editing? It means we are going to have "Winter" and "Hiver" at the same time in the DB?

So basically we have "Winter" in DB, we are editing a serial, "Hiver" is put in the input text letting the user think that it is the value in DB, you save, and "Hiver" is inserted in DB.

Could you confirm it is the behaviour you expect?

Is this fixed? I am still setting that: + Issue <input type="text" name="serialseq" id="serialseq[% serialslis.serialid | html %]" + value="[% PROCESS localize_numbering_pattern_season season => serialslis.serialseq %]" + size="20" maxlength="100" /> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |no-sandbox -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #48 from Blou <philippe.blouin@inlibro.com> --- The previous comment is not clear on what needs to be corrected. Considering Jonathan's objections were previously on architectural principles, I do not think those lines suddenly present the last hurdle for this to pass. Hammat rebased it so that we can have it working for the latest version (us, Collecto, and anyone else interested), but I don't think any serious change will be made to our solution without a clear path to Passed QA. The person in charge will rebase it again in a few months and put it as "Need signoff" out of habit. I leave it as Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158671|0 |1 is obsolete| | --- Comment #50 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 170319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170319&action=edit Bug 24172: Allow translation of seasons in serials-edit.tt and subscription-detail.tt Seasons are not handled by locales. Those generated are stored in English in the database, and the display in serials-collection.tt is translating them. But once you click on "Edit serials" or if you go straight to the subscription's display, those are displayed as in the database: in English. This patch reproduces the same trick as in serial-collection.tt and allow for the display to be translated. NOTE: this patch's testing require knowledge of translation tools. Reproducing Caroline's test: 0- Make sure you have at least one language other than English installed 1- With staff interface in English, create a subscription with a seasonal numbering pattern and frequency, with locale in your other language 2- Check the prediction pattern, note that the season names are in English not the locale language 3- Change the staff interface to other language, redo the prediction pattern test with locale in other language, note that the season names are in other language 4- Save the subscription 5- Receive an issue, note that the season name in the "Numbered" column on serials-edit.pl is in English 6- Save your issue 7- Switch interface in other language 8- Note that the season name on serials-collection is in other language 9- If you check the database, you will see the season name is in English, even though the subscription.locale is something else 10- validate the different pages: - serials-collection.pl: display is translated - serials-edit.pl: name pulled directly from db - subscription-detail.pl: name pulled directly from db - detail.pl: name pulled directly from db - opac-detail.pl: name pulled directly from db 11- APPLY THE PATCH 12- translate the string a) ./translate update <some locale> b) find the strings, translate them c) ./translate install <same locale> 13- restart Plack ? 14- validate the pages again. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 24172: Allow translation of seasons in details.tt and opac-details.tt Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 24172: Move duplicated code to an include file -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #52 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172223&action=edit Bug 24172: [WIP alternate] Process seasons using locale when generating FIXME: I like this path, however, what we really need is a way to get localized seasons in the perl. DateTime handles months and daynames, but has no support for seasons. This patch won't work because it relies on having the languages installed and being able to translate locale 'fre' to language dir 'fr-FR' Attaching only for possible future reference. Currently we are always generating season strings as English, and translating in the templates. Compare this to handling of day/month names which are translated when generated. The numbering for a serial issue is expected to be static as printed - i.e. the French version of an issue will always say 'Hiver' while the English will always say 'Winter'. Translating depending on the interface language will make it harder for users to locate issues in a bilingual context This patch relies on bug 38034 allowing the processing of includes in process_tt If this patch is acceptable we will need a follow-up with a script to correct older serials to the correct locale in the DB - we should be able to run them through process_tt with the correct locale To test: 0 - Apply patch 1 - Make sure you have at least one language other than English installed, we're using French here 2 - Ensure translations are updated after this patch, or install the patch with the fr-FR localizer.inc 2 - Create 2 subscriptions, using numbering 'Seasonal', 1 with locale in english, 1 with locale French 3 - Ensure the prediction is in correct language for the locale 4 - Receive some issues 5 - Confirm the issues are generated with the correct locale for each subscription 6 - Ensure that changing the interface for the staff client does not affect the numering for any views Author: Nick <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #54 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- I tried my hand here - when editing we split the value and provide a dropdown that is only visibly translated. My WIP patch would be a better solution, translating the values when generating, but it needs more infrastructure. If InLibro accepts my patch I think we can possibly move this one forward - or anyone can feel free toed ti what I have done. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171104|0 |1 is obsolete| | --- Comment #56 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 175493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175493&action=edit Bug 24172: Allow translation of seasons in serials-edit.tt and subscription-detail.tt Seasons are not handled by locales. Those generated are stored in English in the database, and the display in serials-collection.tt is translating them. But once you click on "Edit serials" or if you go straight to the subscription's display, those are displayed as in the database: in English. This patch reproduces the same trick as in serial-collection.tt and allow for the display to be translated. NOTE: this patch's testing require knowledge of translation tools. Reproducing Caroline's test: 0- Make sure you have at least one language other than English installed 1- With staff interface in English, create a subscription with a seasonal numbering pattern and frequency, with locale in your other language 2- Check the prediction pattern, note that the season names are in English not the locale language 3- Change the staff interface to other language, redo the prediction pattern test with locale in other language, note that the season names are in other language 4- Save the subscription 5- Receive an issue, note that the season name in the "Numbered" column on serials-edit.pl is in English 6- Save your issue 7- Switch interface in other language 8- Note that the season name on serials-collection is in other language 9- If you check the database, you will see the season name is in English, even though the subscription.locale is something else 10- validate the different pages: - serials-collection.pl: display is translated - serials-edit.pl: name pulled directly from db - subscription-detail.pl: name pulled directly from db - detail.pl: name pulled directly from db - opac-detail.pl: name pulled directly from db 11- APPLY THE PATCH 12- translate the string a) ./translate update <some locale> b) find the strings, translate them c) ./translate install <same locale> 13- restart Plack ? 14- validate the pages again. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 24172: Allow translation of seasons in details.tt and opac-details.tt Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 24172: Move duplicated code to an include file -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174095|0 |1 is obsolete| | --- Comment #58 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 175495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175495&action=edit Bug 24172: Add missing localizer.inc for opac -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175493|0 |1 is obsolete| | --- Comment #59 from Magnus Enger <magnus@libriotech.no> --- Created attachment 177395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177395&action=edit Bug 24172: Allow translation of seasons in serials-edit.tt and subscription-detail.tt Seasons are not handled by locales. Those generated are stored in English in the database, and the display in serials-collection.tt is translating them. But once you click on "Edit serials" or if you go straight to the subscription's display, those are displayed as in the database: in English. This patch reproduces the same trick as in serial-collection.tt and allow for the display to be translated. NOTE: this patch's testing require knowledge of translation tools. Reproducing Caroline's test: 0- Make sure you have at least one language other than English installed 1- With staff interface in English, create a subscription with a seasonal numbering pattern and frequency, with locale in your other language 2- Check the prediction pattern, note that the season names are in English not the locale language 3- Change the staff interface to other language, redo the prediction pattern test with locale in other language, note that the season names are in other language 4- Save the subscription 5- Receive an issue, note that the season name in the "Numbered" column on serials-edit.pl is in English 6- Save your issue 7- Switch interface in other language 8- Note that the season name on serials-collection is in other language 9- If you check the database, you will see the season name is in English, even though the subscription.locale is something else 10- validate the different pages: - serials-collection.pl: display is translated - serials-edit.pl: name pulled directly from db - subscription-detail.pl: name pulled directly from db - detail.pl: name pulled directly from db - opac-detail.pl: name pulled directly from db 11- APPLY THE PATCH 12- translate the string a) ./translate update <some locale> b) find the strings, translate them c) ./translate install <same locale> 13- restart Plack ? 14- validate the pages again. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 24172: Allow translation of seasons in details.tt and opac-details.tt Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 24172: Move duplicated code to an include file Signed-off-by: Magnus Enger <magnus@libriotech.no> Followed the test plan, works as advertised (with my little followup). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175495|0 |1 is obsolete| | --- Comment #61 from Magnus Enger <magnus@libriotech.no> --- Created attachment 177397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177397&action=edit Bug 24172: Add missing localizer.inc for opac Signed-off-by: Magnus Enger <magnus@libriotech.no> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #64 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 177634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177634&action=edit Bug 24172: (follow-up) Split serial sequence upon editing and server This patch checks whether we find a season match in the numeration when editing/receiving a serial. If so, we split the input into three boxes, the before string, the season as a dropdown, and the after string. The dropdown visible values wil be transalated, however, the values will be in English. It's a bit ugly, but it works. To test: 1 - Apply patch, update translation 2 - Receive some issues of the serial 3 - Try receiving in English or your other lang 4 - Confirm values are saved in English in the DB either way 5 - Confirm issues show in the currently selected language either way 6 - Test with a non-seasonal serial, confirm no changes Signed-off-by: Magnus Enger <magnus@libriotech.no> Followed the test plan, works as advertised. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #66 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 177636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177636&action=edit Bug 24172: Followup: Add missing spans to localizer.inc Two of the lines in this file were missing a </span>, resulting in Fall and Winter not being translated properly. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #68 from Jonathan Druart <jonathan.druart@gmail.com> --- I think we now reached the same solution as bug 20511. We lost a lot of time... And so we hit the same problem, and the problematic use case we had there is not solved here: only the first season will be translated/handled. Example: "From season Primavera to season Summer" (I have not updated the translation, hence the "From... to season..." not translated) And also the edition: https://snipboard.io/wSvYV5.jpg -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177633|0 |1 is obsolete| | --- Comment #70 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 179883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179883&action=edit Bug 24172: Allow translation of seasons in serials-edit.tt and subscription-detail.tt Seasons are not handled by locales. Those generated are stored in English in the database, and the display in serials-collection.tt is translating them. But once you click on "Edit serials" or if you go straight to the subscription's display, those are displayed as in the database: in English. This patch reproduces the same trick as in serial-collection.tt and allow for the display to be translated. NOTE: this patch's testing require knowledge of translation tools. Reproducing Caroline's test: 0- Make sure you have at least one language other than English installed 1- With staff interface in English, create a subscription with a seasonal numbering pattern and frequency, with locale in your other language 2- Check the prediction pattern, note that the season names are in English not the locale language 3- Change the staff interface to other language, redo the prediction pattern test with locale in other language, note that the season names are in other language 4- Save the subscription 5- Receive an issue, note that the season name in the "Numbered" column on serials-edit.pl is in English 6- Save your issue 7- Switch interface in other language 8- Note that the season name on serials-collection is in other language 9- If you check the database, you will see the season name is in English, even though the subscription.locale is something else 10- validate the different pages: - serials-collection.pl: display is translated - serials-edit.pl: name pulled directly from db - subscription-detail.pl: name pulled directly from db - detail.pl: name pulled directly from db - opac-detail.pl: name pulled directly from db 11- APPLY THE PATCH 12- translate the string a) ./translate update <some locale> b) find the strings, translate them c) ./translate install <same locale> 13- restart Plack ? 14- validate the pages again. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 24172: Allow translation of seasons in details.tt and opac-details.tt Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 24172: Move duplicated code to an include file Signed-off-by: Magnus Enger <magnus@libriotech.no> Followed the test plan, works as advertised (with my little followup). Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177635|0 |1 is obsolete| | --- Comment #72 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 179885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179885&action=edit Bug 24172: Add missing localizer.inc for opac Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #74 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Rebased -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #75 from Magnus Enger <magnus@libriotech.no> --- (In reply to Katrin Fischer from comment #69)

I am sorry, but this didn't cleanly auto_rebase - can you please rebase and send it back to my queue? I will get to it ASAP.

Based on this comment from Katrin, I think the status here should be "Passed QA"?

Please also give feedback to Jonathans comment, it sounds like a follow-up might be required

Not sure if there was a followup for this yet? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #76 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Magnus Enger from comment #75)

(In reply to Katrin Fischer from comment #69)

...

I am sorry, but this didn't cleanly auto_rebase - can you please rebase and send it back to my queue? I will get to it ASAP.

Based on this comment from Katrin, I think the status here should be "Passed QA"?

...

Please also give feedback to Jonathans comment, it sounds like a follow-up might be required

Not sure if there was a followup for this yet?

Unfortunately it wasn't :( Please in order to move this forward: 1) Help me understand and give feedback to Jonathan's comment. I admit I was dancing around this one a bit because I want to fully understand how it works and how it will affect existing subscriptions etc. and thought I'd need a longer quite time slot for this. 2) Fix QA test tool complaints. Please try to squash any tidy into the existing patches (no extra tidy patch): FAIL koha-tmpl/intranet-tmpl/prog/en/includes/localizer.inc FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/includes/localizer.inc` OK koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt` FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt` FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/showpredictionpattern.tt FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/modules/serials/showpredictionpattern.tt` OK koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/localizer.inc FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/opac-tmpl/bootstrap/en/includes/localizer.inc` FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt` Processing additional checks * Commit title does not contain 'follow-up' correctly spelt - 64a522df8ba -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179884|0 |1 is obsolete| | --- Comment #78 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 185748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185748&action=edit Bug 24172: (follow-up) Split serial sequence upon editing and server This patch checks whether we find a season match in the numeration when editing/receiving a serial. If so, we split the input into three boxes, the before string, the season as a dropdown, and the after string. The dropdown visible values wil be transalated, however, the values will be in English. It's a bit ugly, but it works. To test: 1 - Apply patch, update translation 2 - Receive some issues of the serial 3 - Try receiving in English or your other lang 4 - Confirm values are saved in English in the DB either way 5 - Confirm issues show in the currently selected language either way 6 - Test with a non-seasonal serial, confirm no changes Signed-off-by: Magnus Enger <magnus@libriotech.no> Followed the test plan, works as advertised. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179886|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #81 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I don't think this should still be in Failed QA since there has been a correction. Can the QA team confirm the newest patch is OK? Putting back in Signed off so someone can look at it. Let me know if this is not the right way to get QA eyes on this ;) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185749|0 |1 is obsolete| | --- Comment #83 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 191029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191029&action=edit Bug 24172: Add missing localizer.inc for opac Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185747|0 |1 is obsolete| | --- Comment #85 from David Nind <david@davidnind.com> --- Created attachment 194202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194202&action=edit Bug 24172: Allow translation of seasons in serials-edit.tt and subscription-detail.tt Seasons are not handled by locales. Those generated are stored in English in the database, and the display in serials-collection.tt is translating them. But once you click on "Edit serials" or if you go straight to the subscription's display, those are displayed as in the database: in English. This patch reproduces the same trick as in serial-collection.tt and allow for the display to be translated. NOTE: this patch's testing require knowledge of translation tools. Reproducing Caroline's test: 0- Make sure you have at least one language other than English installed 1- With staff interface in English, create a subscription with a seasonal numbering pattern and frequency, with locale in your other language 2- Check the prediction pattern, note that the season names are in English not the locale language 3- Change the staff interface to other language, redo the prediction pattern test with locale in other language, note that the season names are in other language 4- Save the subscription 5- Receive an issue, note that the season name in the "Numbered" column on serials-edit.pl is in English 6- Save your issue 7- Switch interface in other language 8- Note that the season name on serials-collection is in other language 9- If you check the database, you will see the season name is in English, even though the subscription.locale is something else 10- validate the different pages: - serials-collection.pl: display is translated - serials-edit.pl: name pulled directly from db - subscription-detail.pl: name pulled directly from db - detail.pl: name pulled directly from db - opac-detail.pl: name pulled directly from db 11- APPLY THE PATCH 12- translate the string a) ./translate update <some locale> b) find the strings, translate them c) ./translate install <same locale> 13- restart Plack ? 14- validate the pages again. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 24172: Allow translation of seasons in details.tt and opac-details.tt Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 24172: Move duplicated code to an include file Signed-off-by: Magnus Enger <magnus@libriotech.no> Followed the test plan, works as advertised (with my little followup). Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191029|0 |1 is obsolete| | --- Comment #87 from David Nind <david@davidnind.com> --- Created attachment 194204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194204&action=edit Bug 24172: Add missing localizer.inc for opac Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194202|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194204|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #89 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 196951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196951&action=edit Bug 24172: Allow translation of seasons in serials-edit.tt and subscription-detail.tt Seasons are not handled by locales. Those generated are stored in English in the database, and the display in serials-collection.tt is translating them. But once you click on "Edit serials" or if you go straight to the subscription's display, those are displayed as in the database: in English. This patch reproduces the same trick as in serial-collection.tt and allow for the display to be translated. NOTE: this patch's testing require knowledge of translation tools. Reproducing Caroline's test: 0- Make sure you have at least one language other than English installed 1- With staff interface in English, create a subscription with a seasonal numbering pattern and frequency, with locale in your other language 2- Check the prediction pattern, note that the season names are in English not the locale language 3- Change the staff interface to other language, redo the prediction pattern test with locale in other language, note that the season names are in other language 4- Save the subscription 5- Receive an issue, note that the season name in the "Numbered" column on serials-edit.pl is in English 6- Save your issue 7- Switch interface in other language 8- Note that the season name on serials-collection is in other language 9- If you check the database, you will see the season name is in English, even though the subscription.locale is something else 10- validate the different pages: - serials-collection.pl: display is translated - serials-edit.pl: name pulled directly from db - subscription-detail.pl: name pulled directly from db - detail.pl: name pulled directly from db - opac-detail.pl: name pulled directly from db 11- APPLY THE PATCH 12- translate the string a) ./translate update <some locale> b) find the strings, translate them c) ./translate install <same locale> 13- restart Plack ? 14- validate the pages again. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 24172: Allow translation of seasons in details.tt and opac-details.tt Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 24172: Move duplicated code to an include file Signed-off-by: Magnus Enger <magnus@libriotech.no> Followed the test plan, works as advertised (with my little followup). Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #91 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 196953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196953&action=edit Bug 24172: Add missing localizer.inc for opac Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196951|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196953|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #93 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 198651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198651&action=edit Bug 24172: Allow translation of seasons in serials-edit.tt and subscription-detail.tt Seasons are not handled by locales. Those generated are stored in English in the database, and the display in serials-collection.tt is translating them. But once you click on "Edit serials" or if you go straight to the subscription's display, those are displayed as in the database: in English. This patch reproduces the same trick as in serial-collection.tt and allow for the display to be translated. NOTE: this patch's testing require knowledge of translation tools. Reproducing Caroline's test: 0- Make sure you have at least one language other than English installed 1- With staff interface in English, create a subscription with a seasonal numbering pattern and frequency, with locale in your other language 2- Check the prediction pattern, note that the season names are in English not the locale language 3- Change the staff interface to other language, redo the prediction pattern test with locale in other language, note that the season names are in other language 4- Save the subscription 5- Receive an issue, note that the season name in the "Numbered" column on serials-edit.pl is in English 6- Save your issue 7- Switch interface in other language 8- Note that the season name on serials-collection is in other language 9- If you check the database, you will see the season name is in English, even though the subscription.locale is something else 10- validate the different pages: - serials-collection.pl: display is translated - serials-edit.pl: name pulled directly from db - subscription-detail.pl: name pulled directly from db - detail.pl: name pulled directly from db - opac-detail.pl: name pulled directly from db 11- APPLY THE PATCH 12- translate the string a) ./translate update <some locale> b) find the strings, translate them c) ./translate install <same locale> 13- restart Plack ? 14- validate the pages again. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 24172: Allow translation of seasons in details.tt and opac-details.tt Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 24172: Move duplicated code to an include file Signed-off-by: Magnus Enger <magnus@libriotech.no> Followed the test plan, works as advertised (with my little followup). Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #95 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 198653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198653&action=edit Bug 24172: Add missing localizer.inc for opac Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #97 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 198655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198655&action=edit Bug 24172: (fixup) Do not translate enumchron in catalogue_detail.inc and opac-details.tt Patch from commit 547cc13 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |testopia@bugs.koha-communit | |y.org --- Comment #99 from Lisette Scheer <lisette@bywatersolutions.com> --- Setting empty QA contacts to Default. Some searches don't handle empty QA contact fields well. -- You are receiving this mail because: You are watching all bug changes.