[Bug 33927] New: Improve translation of title tags: Tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33927 Bug ID: 33927 Summary: Improve translation of title tags: Tools Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 33906 This patch will modify tools templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %] Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33906 [Bug 33906] [OMNIBUS] Improve translation of title tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33927 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33927 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155711&action=edit Bug 33927: Improve translation of title tags: Tools This patch modifies tools templates so that title tags can be more easily translated. The patch also makes some modifications to titles, breadcrumb navigation, and page headers in order to make them more consistent with each other and with other similar pages. To test, apply the patch and go to Tools. Test each of the following pages and each variation of the page to confirm that titles, breadcrumbs, and page headers look correct. - Tools home page - Import patrons - Import results - Notices and slips - Main page - Main page filtered by library - New notice - Edit notice - Preview notice: With a CHECKIN, CHECKOUT, or HOLD_SLIP notice, fill in the "Data for preview" box in the "Email" section. Although the template loads in a modal window which doesn't show the page title, you can confirm that there are no errors. - Overdue notice/status triggers - Batch patron deletion - Confirmation page - Batch patron modification - Batch extend due dates - Upload patron images Print notices: With useDischarge enabled, log into the OPAC as a user with no checkouts. Go to the "Ask for a discharge" tab and click "Ask for a discharge." Locate the patron's record in the staff interface and click "Discharges" in the left-hand sidebar menu. Click "Generate discharge." Open the resulting PDF file in a browser. The page title should be "Print notices for [date]." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33927 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- One note for testing. To test "Upload patron images" pages make sure the system preference 'patronimages' is set to 'allow'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33927 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33927 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155711|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 155712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155712&action=edit Bug 33927: Improve translation of title tags: Tools This patch modifies tools templates so that title tags can be more easily translated. The patch also makes some modifications to titles, breadcrumb navigation, and page headers in order to make them more consistent with each other and with other similar pages. To test, apply the patch and go to Tools. Test each of the following pages and each variation of the page to confirm that titles, breadcrumbs, and page headers look correct. - Tools home page - Import patrons - Import results - Notices and slips - Main page - Main page filtered by library - New notice - Edit notice - Preview notice: With a CHECKIN, CHECKOUT, or HOLD_SLIP notice, fill in the "Data for preview" box in the "Email" section. Although the template loads in a modal window which doesn't show the page title, you can confirm that there are no errors. - Overdue notice/status triggers - Batch patron deletion - Confirmation page - Batch patron modification - Batch extend due dates - Upload patron images Print notices: With useDischarge enabled, log into the OPAC as a user with no checkouts. Go to the "Ask for a discharge" tab and click "Ask for a discharge." Locate the patron's record in the staff interface and click "Discharges" in the left-hand sidebar menu. Click "Generate discharge." Open the resulting PDF file in a browser. The page title should be "Print notices for [date]." Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33927 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33927 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33927 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155712|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156025&action=edit Bug 33927: Improve translation of title tags: Tools This patch modifies tools templates so that title tags can be more easily translated. The patch also makes some modifications to titles, breadcrumb navigation, and page headers in order to make them more consistent with each other and with other similar pages. To test, apply the patch and go to Tools. Test each of the following pages and each variation of the page to confirm that titles, breadcrumbs, and page headers look correct. - Tools home page - Import patrons - Import results - Notices and slips - Main page - Main page filtered by library - New notice - Edit notice - Preview notice: With a CHECKIN, CHECKOUT, or HOLD_SLIP notice, fill in the "Data for preview" box in the "Email" section. Although the template loads in a modal window which doesn't show the page title, you can confirm that there are no errors. - Overdue notice/status triggers - Batch patron deletion - Confirmation page - Batch patron modification - Batch extend due dates - Upload patron images Print notices: With useDischarge enabled, log into the OPAC as a user with no checkouts. Go to the "Ask for a discharge" tab and click "Ask for a discharge." Locate the patron's record in the staff interface and click "Discharges" in the left-hand sidebar menu. Click "Generate discharge." Open the resulting PDF file in a browser. The page title should be "Print notices for [date]." Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33927 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33927 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33927 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33927 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org