[Bug 35460] New: Unable to add or edit hold rules in circulation rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 Bug ID: 35460 Summary: Unable to add or edit hold rules in circulation rules table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: emmi.takkinen@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Adding or editing following columns in circulation rules table doesn't seem to work: - Holds allowed (total) - Holds allowed (daily) - Holds per record (count) To reproduce: 1. Create new rule or edit existing one. 2. Add or change values in following columns: - Holds allowed (total) - Holds allowed (daily) - Holds per record (count 3. Save rule. => Note that columns have value "Unlimited" on them. If you check database, columns haven't been saved. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- It seems that bug 8367 dropped those columns at some point from smart-rules.pl and now the saving isn't working. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |blocker --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Emmi, do you have a link to the broken database update? it should have only added a column. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 --- Comment #3 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Katrin Fischer from comment #2)
Hi Emmi, do you have a link to the broken database update? it should have only added a column.
It's not really a database update that is broken https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158023 If you look changes made to smart-rules.pl variable my $rules, these columns have been dropped from there. I'm currently making a patch for this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | --- Comment #4 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 159449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159449&action=edit Bug 35460: Fix add and edit of hold rules in circulation rules table Adding or editing following columns in circulation rules table didn't work: - Holds allowed (total) - Holds allowed (daily) - Holds per record (count) At some point those columns were dropped from list of saved columns in smart-rules.pl. To test: 1. Create new rule or edit existing one. 2. Add or change values in following columns: - Holds allowed (total) - Holds allowed (daily) - Holds per record (count 3. Save rule. => Note that columns have value "Unlimited" on them. If you check database, columns haven't been saved. 4. Apply this patch. 5. Repeat steps 1. to 3. => Columns should now have values in them and they are saved to database. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |major --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks Emmi! (just was got scared for a moment there. Still not nice, but not AS evil) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33847 CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159449|0 |1 is obsolete| | --- Comment #6 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 159452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159452&action=edit Bug 35460: Fix add and edit of hold rules in circulation rules table Adding or editing following columns in circulation rules table didn't work: - Holds allowed (total) - Holds allowed (daily) - Holds per record (count) At some point those columns were dropped from list of saved columns in smart-rules.pl. To test: 1. Create new rule or edit existing one. 2. Add or change values in following columns: - Holds allowed (total) - Holds allowed (daily) - Holds per record (count 3. Save rule. => Note that columns have value "Unlimited" on them. If you check database, columns haven't been saved. 4. Apply this patch. 5. Repeat steps 1. to 3. => Columns should now have values in them and they are saved to database. Sponsored-by: Koha-Suomi Oy Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Going straight to PQA for this one - it's a small, straightforward change and an important fix -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 --- Comment #8 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Katrin Fischer from comment #5)
Thanks Emmi!
(just was got scared for a moment there. Still not nice, but not AS evil)
Sorry for that :D but yeah, it's not _that_ bad situation but quite nasty still. Those columns are easy to miss since they are at the end of table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8367 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Always good to add the "Depends on:" to help our RMaints finding the right versions for backporting :) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 [Bug 8367] How long is a hold waiting for pickup at a more granular level -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.01 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 Bug 35460 depends on bug 8367, which changed state. Bug 8367 Summary: How long is a hold waiting for pickup at a more granular level https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org