[Bug 8979] New: "News" does not work with CCSR
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8979 Priority: P5 - low Change sponsored?: --- Bug ID: 8979 Assignee: oleonard@myacpl.org Summary: "News" does not work with CCSR Severity: enhancement Classification: Unclassified OS: All Reporter: ed.veal@bywatersolutions.com Hardware: All Status: NEW Version: rel_3_10 Component: OPAC Product: Koha The Koha>Tools>News features do not work withing the CCSR theme. Ed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8979 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8979 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |fcapovilla@live.ca --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Changing assignee to Frédérick since he originally designed the theme and can probably fix this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8979 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|fcapovilla@live.ca |pelletiermaxime@gmail.com --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Assignee changed per comment on bug 8884. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8979 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8979 --- Comment #3 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 15645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15645&action=edit Bug 8979 - simple addition of news to CCSR theme Nothing fancy, just displays the news in the mobile view. To test: enable CCSR theme ensure you have a news item that will be displayed on the home page browse to your test site with a mobile phone - news item should be displayed (without the patch it will not be displayed) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8979 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |liz@catalyst.net.nz --- Comment #4 from Liz Rea <liz@catalyst.net.nz> --- Probably at some point we will also want to have the option to click through to a news item if it gets too long. If you put a lot of news on the mobile page you lose the "log in" link off the bottom of the screen. We could simply move that up to the top, as well, and let the news and stuff on the mobile home go down as far as it's wanted, or we could do like the user pages do and pop out a menu. I don't know what's best, I'll leave that to a designer. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8979 --- Comment #5 from Liz Rea <liz@catalyst.net.nz> --- Also optional would be to stick the log in at the bottom and have the rest scroll "under" it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8979 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8979 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15645|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15667&action=edit [SIGNED-OFF] Bug 8979 - simple addition of news to CCSR theme Nothing fancy, just displays the news in the mobile view. To test: enable CCSR theme ensure you have a news item that will be displayed on the home page browse to your test site with a mobile phone - news item should be displayed (without the patch it will not be displayed) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works as described. No errors. Note: Perhaps 'Persona' login could be hidden in movile view. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8979 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8979 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|pelletiermaxime@gmail.com |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8979 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com Patch complexity|--- |Trivial patch Version|3.10 |master QA Contact| |paul.poulain@biblibre.com --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * passes koha-qa.pl * trivial patch, does the job passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8979 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15667|0 |1 is obsolete| | --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16281&action=edit Bug 8979 - simple addition of news to CCSR theme Nothing fancy, just displays the news in the mobile view. To test: enable CCSR theme ensure you have a news item that will be displayed on the home page browse to your test site with a mobile phone - news item should be displayed (without the patch it will not be displayed) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works as described. No errors. Note: Perhaps 'Persona' login could be hidden in movile view. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8979 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8979 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- I wouldn't hide the persona login in mobile view, since it works fine on android/firefoxos phones. Pushed to 3.10.x will be in 3.10.5 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org