[Bug 39145] New: Differentiate between deleting or transferring public and shared lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 Bug ID: 39145 Summary: Differentiate between deleting or transferring public and shared lists Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl The pref ListOwnershipUponPatronDeletion currently only has two flavors: - change owner of public or shared lists - delete these lists It would be nice to at least have a third option to change the owner of public lists only and delete the shared lists. This would not add the burden to staff to take care of lists that were shared between some patrons. The option to change owner for shared lists only seems to be less useful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz, | |jake.deery@ptfs-europe.com, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178136&action=edit Bug 39145: Add option to transfer only public lists to preference Test plan: Run updatedatabase.pl Check ListOwnershipUponPatronDeletion on Patron preferences tab. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178137&action=edit Bug 39145: Apply new pref values to ->disown_or_delete Test plan: Set ListOwnershipUponPatronDeletion to 'change owner of these lists'. Create a public list1 and a private list2 for patron A. Enable sharing lists and share list2 with another patron. Remove patron A. Check that list1 and list2 are transferred. Set ListOwnershipUponPatronDeletion to 'change owner of public lists, delete shared lists'. Create a public list3 and a private list4 for patron B. Share list4 with another patron. Remove patron B. Check that list3 is transferred and list4 is deleted. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178138&action=edit Bug 39145: Add unit tests Test plan: Run t/db_dependent/Koha/Virtualshelves.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 182851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182851&action=edit Bug 39145: (follow-up) Tidy files No test plan (just result of perltidy). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178136|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 182870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182870&action=edit Bug 39145: Add option to transfer only public lists to preference Test plan: Run updatedatabase.pl Check ListOwnershipUponPatronDeletion on Patron preferences tab. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178137|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 182871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182871&action=edit Bug 39145: Apply new pref values to ->disown_or_delete Test plan: Set ListOwnershipUponPatronDeletion to 'change owner of these lists'. Create a public list1 and a private list2 for patron A. Enable sharing lists and share list2 with another patron. Remove patron A. Check that list1 and list2 are transferred. Set ListOwnershipUponPatronDeletion to 'change owner of public lists, delete shared lists'. Create a public list3 and a private list4 for patron B. Share list4 with another patron. Remove patron B. Check that list3 is transferred and list4 is deleted. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178138|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 182872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182872&action=edit Bug 39145: Add unit tests Test plan: Run t/db_dependent/Koha/Virtualshelves.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182851|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 182873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182873&action=edit Bug 39145: (follow-up) Tidy files No test plan (just result of perltidy). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This enhancement to the release notes| |lists feature adds a new | |option to the | |ListOwnershipUponPatronDele | |tion system preference - | |"change owner of public | |lists, delete shared | |lists". | | | |When the patron | |that created a list is | |deleted (and this option is | |set): | |- the owner of any | |public lists are changed | |(to the patron deleting the | |patron, or the patron set | |in ListOwnerDesignated), | |and | |- any shared lists are | |deleted. --- Comment #9 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. I used Mary Burton as Patron A, Lisa Charles as Patron B, and Henry A as Patron C. 2. I edited each patron so that I could: - log in as that patron in the OPAC - share lists by adding an email address: added name@example.com as the email 3. To share lists, you need to enable this system preferences: - OpacAllowSharingPrivateLists - set to Allow 4. How to share a list: - Log in as Patron A (Mary) - Under Lists, select share and then share with Patron B (Lisa), email address is lisa@example.com - To "activate" the shared list: . access the database: koha-mysql kohadev . copy the URL from the email to Patron B (Lisa) to activate the shared list: . select * from message_queue; . copy the URL from the message . login as Patron B in a private browser window (you need to log in as the patron before pasting the link) . paste the URL . accept the shared list 5. When you delete Patron A (Mary) the lists are transferred to the koha patron 6. When you delete Patron B (Lisa) the public list (list3) is transferred to the koha patron, and the private list (list4) is deleted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Nind from comment #8)
Signed-off-by: David Nind <david@davidnind.com>
Thx David ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182870|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 184702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184702&action=edit Bug 39145: Add option to transfer only public lists to preference Test plan: Run updatedatabase.pl Check ListOwnershipUponPatronDeletion on Patron preferences tab. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182871|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 184703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184703&action=edit Bug 39145: Apply new pref values to ->disown_or_delete Test plan: Set ListOwnershipUponPatronDeletion to 'change owner of these lists'. Create a public list1 and a private list2 for patron A. Enable sharing lists and share list2 with another patron. Remove patron A. Check that list1 and list2 are transferred. Set ListOwnershipUponPatronDeletion to 'change owner of public lists, delete shared lists'. Create a public list3 and a private list4 for patron B. Share list4 with another patron. Remove patron B. Check that list3 is transferred and list4 is deleted. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182872|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 184704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184704&action=edit Bug 39145: Add unit tests Test plan: Run t/db_dependent/Koha/Virtualshelves.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182873|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 184705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184705&action=edit Bug 39145: (follow-up) Tidy files No test plan (just result of perltidy). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Rebased. Note that this is a false qa tools warning: [FAIL] installer/data/mysql/mandatory/sysprefs.sql FAIL semicolon simicolon found instead of comma at line 893 The file should just end with a sEmicolon. Not sure what a simicolon is ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I'm afraid I get lots of test failures on t/db_dependent/Koha/Virtualshelves.t on this one.. could you take a look Marcel? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize (ashimema) from comment #16)
I'm afraid I get lots of test failures on t/db_dependent/Koha/Virtualshelves.t on this one.. could you take a look Marcel?
Just checked again: Running tests (1) * Proving /usr/share/koha/t/db_dependent/Koha/Virtualshelves.t PASS But I see a (new) qa failure:[FAIL] installer/data/mysql/atomicupdate/bug_39145.pl FAIL forbidden_patterns forbidden pattern: Have you considered sharing the new syspref to HEA? (see bug 23849 and C4/UsageStats.pm) (line 13) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #17)
But I see a (new) qa failure:[FAIL] installer/data/mysql/atomicupdate/bug_39145.pl FAIL forbidden_patterns forbidden pattern: Have you considered sharing the new syspref to HEA? (see bug 23849 and C4/UsageStats.pm) (line 13)
That is a false warning. Ping Jonathan, Joubu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize (ashimema) from comment #16)
I'm afraid I get lots of test failures on t/db_dependent/Koha/Virtualshelves.t on this one.. could you take a look Marcel?
Please provide test output. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Marcel de Rooy from comment #18)
(In reply to Marcel de Rooy from comment #17)
But I see a (new) qa failure:[FAIL] installer/data/mysql/atomicupdate/bug_39145.pl FAIL forbidden_patterns forbidden pattern: Have you considered sharing the new syspref to HEA? (see bug 23849 and C4/UsageStats.pm) (line 13)
That is a false warning.
Ping Jonathan, Joubu
Yes, ignore it. See https://gitlab.com/koha-community/qa-test-tools/-/merge_requests/85 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184702|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186960&action=edit Bug 39145: Add option to transfer only public lists to preference Test plan: Run updatedatabase.pl Check ListOwnershipUponPatronDeletion on Patron preferences tab. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184703|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186961&action=edit Bug 39145: Apply new pref values to ->disown_or_delete Test plan: Set ListOwnershipUponPatronDeletion to 'change owner of these lists'. Create a public list1 and a private list2 for patron A. Enable sharing lists and share list2 with another patron. Remove patron A. Check that list1 and list2 are transferred. Set ListOwnershipUponPatronDeletion to 'change owner of public lists, delete shared lists'. Create a public list3 and a private list4 for patron B. Share list4 with another patron. Remove patron B. Check that list3 is transferred and list4 is deleted. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184704|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186962&action=edit Bug 39145: Add unit tests Test plan: Run t/db_dependent/Koha/Virtualshelves.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184705|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186963&action=edit Bug 39145: (follow-up) Tidy files No test plan (just result of perltidy). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 --- Comment #25 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- All working now.. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 --- Comment #26 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 --- Comment #27 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- +('ListOwnerDesignated', NULL, NULL, 'Designated list owner at patron deletion', 'Free'), the system preference value cannot be NULL: MariaDB [koha_kohadev]> describe systempreferences; +-------------+-------------+------+-----+---------+-------+ | Field | Type | Null | Key | Default | Extra | +-------------+-------------+------+-----+---------+-------+ | variable | varchar(50) | NO | PRI | | | | value | mediumtext | NO | | '' | | | options | longtext | YES | | NULL | | | explanation | mediumtext | YES | | NULL | | | type | varchar(20) | YES | | NULL | | +-------------+-------------+------+-----+---------+-------+ 5 rows in set (0.001 sec) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 --- Comment #28 from David Cook <dcook@prosentient.com.au> --- Comment on attachment 186960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186960 Bug 39145: Add option to transfer only public lists to preference Review of attachment 186960: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=39145&attachment=186960) ----------------------------------------------------------------- ::: installer/data/mysql/mandatory/sysprefs.sql @@ +394,4 @@
('LinkerModule','Default','Default|FirstMatch|LastMatch','Chooses which linker module to use (see documentation).','Choice'), ('LinkerOptions','','','A pipe-separated list of options for the linker.','free'), ('LinkerRelink','1',NULL,'If ON the authority linker will relink headings that have previously been linked every time it runs.','YesNo'), +('ListOwnerDesignated', NULL, NULL, 'Designated list owner at patron deletion', 'Free'),
Looks like this is causing errors in Jenkins: "DBD::mysql::st execute failed: Column 'value' cannot be null at /usr/share/perl5/DBIx/RunSQL.pm line 310, <$args{...}> line 1." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 --- Comment #29 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 187067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187067&action=edit Bug 39145: Use empty string for system preference value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Prefs not being NULL is a new development (40405). This was waiting for some time already. Thx for follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39145 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #31 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This is an enhancement and will not be backported to the 25.05.x branch. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org