[Bug 39971] New: Patron attribute types form logic should be reusable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Bug ID: 39971 Summary: Patron attribute types form logic should be reusable Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: pedro.amorim@openfifth.co.uk Reporter: pedro.amorim@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@gmail.com, martin.renvoize@openfifth.co.uk, tomascohen@gmail.com Other parts of Koha that need to render this should not be repeating code but instead make use of established DRY logic. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 182739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182739&action=edit Bug 39971: Move form rendering to reusable tt block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 --- Comment #2 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 182740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182740&action=edit Bug 39971: Move patron_attributes_form method to a class This makes it reusable, documentable, and testable. This is changing code without adding a new feature or fixing a bug. The first test plan should be to just make sure that the existing functionality is kept intact, i.e. rendering and saving the patron attribute types in the form. As to why we need this, we're maintaining the ILL Actions plugin where we have a feature to quickly add a patron. This is designed to be as minimal as possible, but if there are any mandatory patron attribute types, those need to be considered. To test this: 1) Apply patches and enable ILLModule syspref. 2) Install the plugin: https://github.com/openfifth/koha-plugin-ill-actions/releases/tag/v2.4.0 3) Add a mandatory patron attribute type, you can edit the existing one in k-t-d, visit: <staff_url>/cgi-bin/koha/admin/patron-attr-types.pl?op=edit_attribute_type&code=SHOW_BCODE 5) Tick the 'Staff interface mandatory' checkbox 6) Create a new ILL request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 7) Notice there's a '+Add new user' link next to the cardnumber input at the bottom of the form. Click that. 8) Notice there's a 'Additional attributes and identifiers' section. This is only possible (without writing it again) because of the patches here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 --- Comment #3 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 182741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182741&action=edit Bug 39971: Add POD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 --- Comment #4 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 182742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182742&action=edit Bug 39971: Add query param -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182739|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 183087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183087&action=edit Bug 39971: Move form rendering to reusable tt block Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182740|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 183088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183088&action=edit Bug 39971: Move patron_attributes_form method to a class This makes it reusable, documentable, and testable. This is changing code without adding a new feature or fixing a bug. The first test plan should be to just make sure that the existing functionality is kept intact, i.e. rendering and saving the patron attribute types in the form. As to why we need this, we're maintaining the ILL Actions plugin where we have a feature to quickly add a patron. This is designed to be as minimal as possible, but if there are any mandatory patron attribute types, those need to be considered. To test this: 1) Apply patches and enable ILLModule syspref. 2) Install the plugin: https://github.com/openfifth/koha-plugin-ill-actions/releases/tag/v2.4.0 3) Add a mandatory patron attribute type, you can edit the existing one in k-t-d, visit: <staff_url>/cgi-bin/koha/admin/patron-attr-types.pl?op=edit_attribute_type&code=SHOW_BCODE 5) Tick the 'Staff interface mandatory' checkbox 6) Create a new ILL request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 7) Notice there's a '+Add new user' link next to the cardnumber input at the bottom of the form. Click that. 8) Notice there's a 'Additional attributes and identifiers' section. This is only possible (without writing it again) because of the patches here. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182741|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 183089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183089&action=edit Bug 39971: Add POD Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182742|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 183090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183090&action=edit Bug 39971: Add query param Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #9 from David Nind <david@davidnind.com> --- Things worked as per the test plan. In this case, a new patron wasn't created. However, I assume that is because the plugin has to implement that part? (It also let you press submit even if you didn't add a mandatory field.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183087|0 |1 is obsolete| | --- Comment #10 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189077&action=edit Bug 39971: Move form rendering to reusable tt block Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183088|0 |1 is obsolete| | --- Comment #11 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189078&action=edit Bug 39971: Move patron_attributes_form method to a class This makes it reusable, documentable, and testable. This is changing code without adding a new feature or fixing a bug. The first test plan should be to just make sure that the existing functionality is kept intact, i.e. rendering and saving the patron attribute types in the form. As to why we need this, we're maintaining the ILL Actions plugin where we have a feature to quickly add a patron. This is designed to be as minimal as possible, but if there are any mandatory patron attribute types, those need to be considered. To test this: 1) Apply patches and enable ILLModule syspref. 2) Install the plugin: https://github.com/openfifth/koha-plugin-ill-actions/releases/tag/v2.4.0 3) Add a mandatory patron attribute type, you can edit the existing one in k-t-d, visit: <staff_url>/cgi-bin/koha/admin/patron-attr-types.pl?op=edit_attribute_type&code=SHOW_BCODE 5) Tick the 'Staff interface mandatory' checkbox 6) Create a new ILL request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 7) Notice there's a '+Add new user' link next to the cardnumber input at the bottom of the form. Click that. 8) Notice there's a 'Additional attributes and identifiers' section. This is only possible (without writing it again) because of the patches here. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183089|0 |1 is obsolete| | --- Comment #12 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189079&action=edit Bug 39971: Add POD Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183090|0 |1 is obsolete| | --- Comment #13 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189080&action=edit Bug 39971: Add query param Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k --- Comment #14 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Rebased on bug 40917 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189077|0 |1 is obsolete| | --- Comment #15 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 189125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189125&action=edit Bug 39971: Move form rendering to reusable tt block Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189078|0 |1 is obsolete| | --- Comment #16 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 189126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189126&action=edit Bug 39971: Move patron_attributes_form method to a class This makes it reusable, documentable, and testable. This is changing code without adding a new feature or fixing a bug. The first test plan should be to just make sure that the existing functionality is kept intact, i.e. rendering and saving the patron attribute types in the form. As to why we need this, we're maintaining the ILL Actions plugin where we have a feature to quickly add a patron. This is designed to be as minimal as possible, but if there are any mandatory patron attribute types, those need to be considered. To test this: 1) Apply patches and enable ILLModule syspref. 2) Install the plugin: https://github.com/openfifth/koha-plugin-ill-actions/releases/tag/v2.4.0 3) Add a mandatory patron attribute type, you can edit the existing one in k-t-d, visit: <staff_url>/cgi-bin/koha/admin/patron-attr-types.pl?op=edit_attribute_type&code=SHOW_BCODE 5) Tick the 'Staff interface mandatory' checkbox 6) Create a new ILL request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 7) Notice there's a '+Add new user' link next to the cardnumber input at the bottom of the form. Click that. 8) Notice there's a 'Additional attributes and identifiers' section. This is only possible (without writing it again) because of the patches here. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189079|0 |1 is obsolete| | --- Comment #17 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 189127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189127&action=edit Bug 39971: Add POD Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189080|0 |1 is obsolete| | --- Comment #18 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 189128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189128&action=edit Bug 39971: Add query param Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 --- Comment #19 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 189129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189129&action=edit Bug 39971: (QA follow-up) Unit tests Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 --- Comment #20 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Thank you, Nick. I'm sorry, I realize now I wrongfully set this to PQA after rebase when I should've set it to 'Signed-off' as it was originally. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189125|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189126|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189127|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189128|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189077|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189078|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189079|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189080|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189077|0 |1 is obsolete| | Attachment #189078|0 |1 is obsolete| | Attachment #189079|0 |1 is obsolete| | Attachment #189080|0 |1 is obsolete| | Attachment #189129|0 |1 is obsolete| | --- Comment #21 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 189130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189130&action=edit Bug 39971: Move form rendering to reusable tt block Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 --- Comment #22 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 189131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189131&action=edit Bug 39971: Move patron_attributes_form method to a class This makes it reusable, documentable, and testable. This is changing code without adding a new feature or fixing a bug. The first test plan should be to just make sure that the existing functionality is kept intact, i.e. rendering and saving the patron attribute types in the form. As to why we need this, we're maintaining the ILL Actions plugin where we have a feature to quickly add a patron. This is designed to be as minimal as possible, but if there are any mandatory patron attribute types, those need to be considered. To test this: 1) Apply patches and enable ILLModule syspref. 2) Install the plugin: https://github.com/openfifth/koha-plugin-ill-actions/releases/tag/v2.4.0 3) Add a mandatory patron attribute type, you can edit the existing one in k-t-d, visit: <staff_url>/cgi-bin/koha/admin/patron-attr-types.pl?op=edit_attribute_type&code=SHOW_BCODE 5) Tick the 'Staff interface mandatory' checkbox 6) Create a new ILL request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 7) Notice there's a '+Add new user' link next to the cardnumber input at the bottom of the form. Click that. 8) Notice there's a 'Additional attributes and identifiers' section. This is only possible (without writing it again) because of the patches here. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 --- Comment #23 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 189132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189132&action=edit Bug 39971: Add POD Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 --- Comment #24 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 189133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189133&action=edit Bug 39971: Add query param Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 --- Comment #25 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 189134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189134&action=edit Bug 39971: (QA follow-up) Unit tests Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_26_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #26 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- tidy errors: [FAIL] koha-tmpl/intranet-tmpl/prog/en/includes/member-attribute-types.inc FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/includes/member-attribute-types.inc` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 --- Comment #27 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 191404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191404&action=edit Bug 39971: (QA follow-up): Tidy fix -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Internal refactoring of release notes| |code for reusability. No | |end-user functionality | |changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 --- Comment #28 from Owen Leonard <oleonard@myacpl.org> --- I was just looking at batch patron modification and wondering why we didn't use the full set of inputs there. Maybe this enhancement will make it easier to do so? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #29 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- [FAIL] members/memberentry.pl FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl members/memberentry.pl` [PASS] t/db_dependent/Koha/Patron/Attribute/Types.t Processing additional checks PASS! * Was this bug sponsored by anyone? Running tests (1) * Proving /kohadevbox/koha/t/db_dependent/Koha/Patron/Attribute/Types.t FAIL # Failed test 'Found all three expected values' # at /kohadevbox/koha/t/db_dependent/Koha/Patron/Attribute/Types.t line 589. # got: '0' # expected: '3' # Failed test 'We get only 2 values when from a different branch' # at /kohadevbox/koha/t/db_dependent/Koha/Patron/Attribute/Types.t line 607. # got: '0' # expected: '2' # Failed test 'We get all 3 expected values' # at /kohadevbox/koha/t/db_dependent/Koha/Patron/Attribute/Types.t line 625. # got: '0' # expected: '3' # Looks like you planned 12 tests but ran 4. # Looks like you failed 3 tests of 4 run. # Failed test 'pattron_attributes_form tests' # at /kohadevbox/koha/t/db_dependent/Koha/Patron/Attribute/Types.t line 627. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #30 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Lucas Gass (lukeg) from comment #29)
[FAIL] members/memberentry.pl FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl members/memberentry.pl` [PASS] t/db_dependent/Koha/Patron/Attribute/Types.t
Processing additional checks PASS!
* Was this bug sponsored by anyone?
Running tests (1) * Proving /kohadevbox/koha/t/db_dependent/Koha/Patron/Attribute/Types.t FAIL
# Failed test 'Found all three expected values' # at /kohadevbox/koha/t/db_dependent/Koha/Patron/Attribute/Types.t line 589. # got: '0' # expected: '3'
# Failed test 'We get only 2 values when from a different branch' # at /kohadevbox/koha/t/db_dependent/Koha/Patron/Attribute/Types.t line 607. # got: '0' # expected: '2'
# Failed test 'We get all 3 expected values' # at /kohadevbox/koha/t/db_dependent/Koha/Patron/Attribute/Types.t line 625. # got: '0' # expected: '3' # Looks like you planned 12 tests but ran 4. # Looks like you failed 3 tests of 4 run.
# Failed test 'pattron_attributes_form tests' # at /kohadevbox/koha/t/db_dependent/Koha/Patron/Attribute/Types.t line 627.
This was a "me" problem. The lesson is, don't run tests after you've dropped your test database. ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 --- Comment #31 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_26_05_candidate, | |release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #32 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #33 from David Nind <david@davidnind.com> --- No changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org