[Bug 42312] New: Must enter all four lines of physical address when editing a vendor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42312 Bug ID: 42312 Summary: Must enter all four lines of physical address when editing a vendor Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When editing a vendor we only save as many lines as are submitted, and will retain all four preexisting lines To recreate: 1 - Create or edit a vendor and enter 'Physical address' as Line 1 Line 2 Line 3 Line 4 2 - Edit the vendor, clear physical address and enter: New Line 1 3 - Save, search for vendor, and note the address shows as New Line 1Line2Line3Line4 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42312 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42312 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 196945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196945&action=edit Bug 42312: Clear vendor address before saving new address lines This patch clears the vendor address fields before processing the new input and also adds a space between lines when joining the display To test: 1 - Create or edit a vendor and enter 'Physical address' as Line 1 Line 2 Line 3 Line 4 2 - Edit the vendor, clear physical address and enter: New Line 1 3 - Save, search for vendor, and note the address shows as New Line 1Line2Line3Line4 4 - Apply patch, yanr build, reload the page and clear cache 5 - Clear physicall address and enter Newnew line 1 6 - Search for vendor and confirm display is: Newnew line 1 Line 2 Line 3 Line 4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42312 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42312 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196945|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42312 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 196972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196972&action=edit Bug 42312: Clear vendor address before saving new address lines This patch clears the vendor address fields before processing the new input and also adds a space between lines when joining the display To test: 1 - Create or edit a vendor and enter 'Physical address' as Line 1 Line 2 Line 3 Line 4 2 - Edit the vendor, clear physical address and enter: New Line 1 3 - Save, search for vendor, and note the address shows as New Line 1Line2Line3Line4 4 - Apply patch, yanr build, reload the page and clear cache 5 - Clear physicall address and enter Newnew line 1 6 - Search for vendor and confirm display is: Newnew line 1 Line 2 Line 3 Line 4 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42312 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. For some reason I couldn't edit vendor 1 (My Vendor) - clicking any of the save options didn't do anything. 2. Was able to test by creating a new vendor. Have created Bug 42316 for this (not sure if it is a KTD issue or something else). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42312 Angela Berrett <angela.berrett@familysearch.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |angela.berrett@familysearch | |.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42312 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196972|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42312 --- Comment #4 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 197095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197095&action=edit Bug 42312: Clear vendor address before saving new address lines This patch clears the vendor address fields before processing the new input and also adds a space between lines when joining the display To test: 1 - Create or edit a vendor and enter 'Physical address' as Line 1 Line 2 Line 3 Line 4 2 - Edit the vendor, clear physical address and enter: New Line 1 3 - Save, search for vendor, and note the address shows as New Line 1Line2Line3Line4 4 - Apply patch, yanr build, reload the page and clear cache 5 - Clear physicall address and enter Newnew line 1 6 - Search for vendor and confirm display is: Newnew line 1 Line 2 Line 3 Line 4 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42312 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |emily.lamancusa@montgomeryc | |ountymd.gov QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42312 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42312 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42312 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42312 --- Comment #6 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org