[Bug 14290] New: Add a table foot to circulation matrix
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 Bug ID: 14290 Summary: Add a table foot to circulation matrix Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: nicolas.legrand@bulac.fr QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com We have a big circulation matrix, when I edit an entry, it's hard to tell which column I am editing cause the header is way too up. Printing the header in a footer helps a bit. Test plan : try do add, modify or delete some entries in the circulation matrix, everything should work as expected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 --- Comment #1 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 39639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39639&action=edit Bug 14290: Add a table foot to circulation matrix Reprint circulation matrix header in a footer helps editing entries in big matrix. Otherwise, the header disapears and it's hard to tell which columns we're editing. Test plan : try do add, modify or delete some entries in the circulation matrix, everything should work as expected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- Hi Nicolas, What do you think about having the column headers as 'title' attribute in the td tags? We would then have nice tooltips related to each entry. Marc -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 --- Comment #3 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Hey Marc, (In reply to Marc Véron from comment #2)
Hi Nicolas,
What do you think about having the column headers as 'title' attribute in the td tags? We would then have nice tooltips related to each entry.
Thank you for your suggestion. I'm not sure about it for editing. If I want edit just an entry, the full footer permits me to find that entry in a trice. Having to over every field seems longer to me. I think the footer is better for editing. However, the tooltip might be an excellent idea for an other purpose : know what value a value is about when lost in a big circulation matrix. That was maybe what you were thinking about? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 --- Comment #4 from Marc Véron <veron@veron.ch> --- My idea was to have the tooltip as an addition, not as an alternative to the table footer. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 39667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39667&action=edit [Signed-off] Bug 14290: Add a table foot to circulation matrix Reprint circulation matrix header in a footer helps editing entries in big matrix. Otherwise, the header disapears and it's hard to tell which columns we're editing. Test plan : try do add, modify or delete some entries in the circulation matrix, everything should work as expected. Patch works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39639|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39667|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 39716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39716&action=edit [PASSED QA] Bug 14290: Add a table foot to circulation matrix Reprint circulation matrix header in a footer helps editing entries in big matrix. Otherwise, the header disapears and it's hard to tell which columns we're editing. Test plan : try do add, modify or delete some entries in the circulation matrix, everything should work as expected. Patch works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Nice little patch and an improvement until we can come up with something better to make the big table easier to handle. I dream of an editable table, where the header always stays visible on top... with sorting and filtering options *sigh* ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Nice improvement, Nicolas! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 --- Comment #10 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 41019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41019&action=edit Bug 14290 - fix number of columns in footer for 3.18 Jonathan pointed out that the smart rules table is slightly different in 3.20, this commit cleans it up for 3.18. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz Attachment #41019|0 |1 is obsolete| | --- Comment #11 from Liz Rea <liz@catalyst.net.nz> --- Comment on attachment 41019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41019 Bug 14290 - fix number of columns in footer for 3.18 actually, i have something extra in here. one moment. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 --- Comment #12 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 41020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41020&action=edit Bug 14290 - fix number of columns in footer for 3.18 Jonathan pointed out that the smart rules table is slightly different in 3.20, this commit cleans it up for 3.18. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 --- Comment #13 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.x will be in 3.18.09 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #14 from Mason James <mtj@kohaaloha.com> --- Possible selection for 3.16.x?... needs testing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 --- Comment #15 from Liz Rea <liz@catalyst.net.nz> --- Mason - the 3.18 version may be closer to what you need :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The table footer should not be contained in the table body. A correct table structure is: table -tbody -tfoot not table -tbody -tfoot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org