https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124620&action=edit Bug 28959: DBIC update -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, | |kyle@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|18148 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 [Bug 18148] Make list of lists in OPAC sortable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124619|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124622&action=edit Bug 28959: Move category => public Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124621|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124624&action=edit Bug 28959: Add virtualshelves.public as a boolean This patchset moves the 'category' attribute for virtual shelves, that takes values of 1 and 2 (private and public respectively) into a boolean for public. The DBRev is trivial, and the changes to the code are as well. To test: 1. have some known public and private lists 2. Apply this patches 3. Run: $ updatedatabase => SUCCESS: Public lists have public=1, private have public=0 4. Run: $ kshell k$ prove t/db_dependent/Utils/Datatables_Virtualshelves.t \ t/db_dependent/Virtualshelves.t => SUCCESS: Tests pass! 5. Try the feature in staff and OPAC => SUCCESS: All good 6. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124625|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #9 from David Nind <david@davidnind.com> --- The tests pass. However, there is a change to the way lists are displayed, and I can't easily add items from a search result: 1. Private lists appear under both 'Your lists' and 'Public lists' in the drop down list when you attempt to add an item(s) to a list from search results. 2. You can't see the public lists either. I created three lists: - LISTA = private - LISTB = public (owner only able to make changes) - LISTC = public (anyone seeing can make changes) After applying the patch I have updated the database, flush_memcached, and cleared cached for browser. Now in the staff interface when doing a search and attempting to add items to lists (search > bar at the top with 'Add to list') I only see: Your lists LISTA Public lists LISTA I can't see any of the public lists to add things to. I can create a new list (LISTD) (either private or public) but I still only see the private lists to add things to, and then the private list appears under both headings: Your lists LISTD LISTA Public lists LISTD LISTA The same thing happens in the OPAC. Also, I'm not sure what the sort order for lists should be, but A-Z would seem logical to me. In the OPAC I can see the public lists from Lists > Your lists, then change to the Public lists tab. In the staff interface I can see the public lists from Home > Lists > Public lists tab. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- I've added a followup 2, otherwise seems to work fine. Maybe we could change in form : "Category: Private/Public" with "Public: No/Yes" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124623|0 |1 is obsolete| | --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 124800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124800&action=edit Bug 28959: DBIC update Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124663|0 |1 is obsolete| | --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 124802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124802&action=edit Bug 28959: (follow-up) Adjust all places in which 'category' was used Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi --- Comment #18 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- (In reply to Marcel de Rooy from comment #12)

(In reply to Tomás Cohen Arazi from comment #0)

...

Somehow it got more complicated than required.

This report oversimplifies things? Private lists include shared lists too. Saying public Y/N implicitly may include the wrong message.

This patch does not alter the message we are giving out, we already say before this patch explicitly in the OPAC GUI whether a list is Public or not. So I wouldn't take that into consideration whether to accept this patch or not. If we want to use another naming it can be done even after this patch, this patch doesn't make it any harder as far as I can tell. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124799|0 |1 is obsolete| | Attachment #124800|0 |1 is obsolete| | Attachment #124801|0 |1 is obsolete| | Attachment #124802|0 |1 is obsolete| | Attachment #124803|0 |1 is obsolete| | --- Comment #19 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 124807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124807&action=edit Bug 28959: Move category => public Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 --- Comment #21 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 124809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124809&action=edit Bug 28959: Add virtualshelves.public as a boolean This patchset moves the 'category' attribute for virtual shelves, that takes values of 1 and 2 (private and public respectively) into a boolean for public. The DBRev is trivial, and the changes to the code are as well. To test: 1. have some known public and private lists 2. Apply this patches 3. Run: $ updatedatabase => SUCCESS: Public lists have public=1, private have public=0 4. Run: $ kshell k$ prove t/db_dependent/Utils/Datatables_Virtualshelves.t \ t/db_dependent/Virtualshelves.t => SUCCESS: Tests pass! 5. Try the feature in staff and OPAC => SUCCESS: All good 6. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 --- Comment #23 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 124811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124811&action=edit Bug 28959: (follow-up) Adjust more places in which 'category' was used Some links still had category. I propose we use explicit public=1 and public=0 when links to public/private are side by side. Otherwise whe just use /cgi-bin/koha/opac-shelves.pl?op=list using default value 0. Signed-off-by: David Nind <david@davidnind.com> JK: Adjust commit title Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Joonas Kylmälä from comment #18)

This patch does not alter the message we are giving out, we already say before this patch explicitly in the OPAC GUI whether a list is Public or not. So I wouldn't take that into consideration whether to accept this patch or not. If we want to use another naming it can be done even after this patch, this patch doesn't make it any harder as far as I can tell.

So, we implicitly already have three categories. And some requests show that people are still shaking the tree. Might extending categories solve that? Not sure. But we choose to put that aside here and make it a boolean. I have no strong arguments against it but just have the intuitive feeling that this may not be the right direction :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Fridolin Somers from comment #25)

(In reply to Marcel de Rooy from comment #24)

...

(In reply to Joonas Kylmälä from comment #18)

...

This patch does not alter the message we are giving out, we already say before this patch explicitly in the OPAC GUI whether a list is Public or not. So I wouldn't take that into consideration whether to accept this patch or not. If we want to use another naming it can be done even after this patch, this patch doesn't make it any harder as far as I can tell.

So, we implicitly already have three categories. And some requests show that people are still shaking the tree. Might extending categories solve that? Not sure. But we choose to put that aside here and make it a boolean. I have no strong arguments against it but just have the intuitive feeling that this may not be the right direction :)

I also had the feeling we could keep a place for a third value. But the need here is for API routes to know if datas can be open to the public or not. That is binary.

Isn't the fact that a list is shared just another boolean? What if we decided to make lists shareable with specific patrons or categories? We need stop doing things implicitly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127047&action=edit Bug 28959: DBIC update Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127049&action=edit Bug 28959: (follow-up) Adjust all places in which 'category' was used Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Remaining occurrences of category in opac-shelves.pl I am getting a 500 when sharing a list The method Koha::Virtualshelf->category is not covered by tests! Koha::Object::AUTOLOAD('Koha::Virtualshelf=HASH(0x560389011140)') called at /kohadevbox/koha/opac/opac-shareshelf.pl line 84 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 --- Comment #33 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #32)

Remaining occurrences of category in opac-shelves.pl

I meant opac/opac-shareshelf.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 --- Comment #35 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 127060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127060&action=edit Bug 28959: Fix other cases -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 --- Comment #39 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127206&action=edit Bug 28959: Fix occurrence in tools/batch_record_modification.pl No method count found for Koha::Virtualshelves DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'category' in 'where clause' at /kohadevbox/koha/Koha/Objects.pm line 601 at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt line 80. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #40 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Last two patches pushed to master. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 --- Comment #42 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #41)

Created attachment 128036 [details] [review] Bug 28959: Fix occurrence in tools/batch_delete_records.pl

Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30925 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11889 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 --- Comment #45 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Marcel de Rooy from comment #44)

(In reply to Marcel de Rooy from comment #43)

...

Did this report create bug 30925, Tomnas ?

Tomnas should be Tomas.

FQA -- You are receiving this mail because: You are watching all bug changes.