[Bug 36050] New: Confusing notice is sent if a hold is cancelled on check-in with no reason specified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36050 Bug ID: 36050 Summary: Confusing notice is sent if a hold is cancelled on check-in with no reason specified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: emily.lamancusa@montgomerycountymd.gov Reporter: emily.lamancusa@montgomerycountymd.gov QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 29007 In all other locations where a hold cancellation reason can be specified, no notice is sent if a cancellation reason is not selected. However, if a hold is cancelled from the check-in pop-up and no reason is selected, a notice is sent without a valid reason value. This occurs because the <select> value is set to "NULL", when it should be left undefined. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 [Bug 29007] Prompt for reason when cancelling waiting hold via popup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36050 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Never mind, this was already fixed by bug 35535...should've tested on master before I reported it. :) *** This bug has been marked as a duplicate of bug 35535 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36050 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Sorry Emily. I sneakily put that fix into Bug 29007. You can also fix this in the meantime with a bit of JS. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36050 --- Comment #3 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Haha thanks for fixing it! :) Good point - I addressed it locally by adding [%- IF hold.cancellation_reason != 'NULL' -%] to the notice template before I filed the bug, but I appreciate the JS suggestion as well! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org