[Bug 21456] New: The 'New authority' button lists authority types inconsistently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21456 Bug ID: 21456 Summary: The 'New authority' button lists authority types inconsistently Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: arouss1980@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com As per the attached staff client screenshots, in Home > Authorities (authorities-home.pl), the button 'New authority' lists the available authority types in alphabetical order based on their _description_. The same button in an authority's detail view (detail.pl) lists auth types in alphabetical order based on their _code_. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21456 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |arouss1980@gmail.com |ity.org | Status|NEW |ASSIGNED --- Comment #1 from Andreas Roussos <arouss1980@gmail.com> --- Created attachment 79653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79653&action=edit Authority types sorted by description -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21456 --- Comment #2 from Andreas Roussos <arouss1980@gmail.com> --- Created attachment 79654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79654&action=edit Authority types sorted by code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21456 --- Comment #3 from Andreas Roussos <arouss1980@gmail.com> --- Created attachment 79655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79655&action=edit Bug 21456: The 'New authority' button lists authority types inconsistently The 'New authority' button does not always list the available authority types in A-Z order based on their description. This patch fixes that. Test plan: 1) Go to Home > Authorities in the staff client; notice how the 'New authority' button lists auth types sorted by description. 2) Go to an authority's detail page; notice how the same 'New authority' button will list auth types sorted by their code. 3) Apply the patch. 4) In an authority's detail page, the 'New authority' button will now list the available authority types sorted by description. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21456 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Priority|P5 - low |P3 Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21456 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21456 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79655|0 |1 is obsolete| | --- Comment #4 from Michal Denar <black23@gmail.com> --- Created attachment 79661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79661&action=edit Bug 21456: The 'New authority' button lists authority types inconsistently The 'New authority' button does not always list the available authority types in A-Z order based on their description. This patch fixes that. Test plan: 1) Go to Home > Authorities in the staff client; notice how the 'New authority' button lists auth types sorted by description. 2) Go to an authority's detail page; notice how the same 'New authority' button will list auth types sorted by their code. 3) Apply the patch. 4) In an authority's detail page, the 'New authority' button will now list the available authority types sorted by description. Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21456 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79661|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 80223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80223&action=edit Bug 21456: The 'New authority' button lists authority types inconsistently The 'New authority' button does not always list the available authority types in A-Z order based on their description. This patch fixes that. Test plan: 1) Go to Home > Authorities in the staff client; notice how the 'New authority' button lists auth types sorted by description. 2) Go to an authority's detail page; notice how the same 'New authority' button will list auth types sorted by their code. 3) Apply the patch. 4) In an authority's detail page, the 'New authority' button will now list the available authority types sorted by description. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21456 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 80224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80224&action=edit Bug 21456: (QA follow-up) Catch missed case in authorities merge Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21456 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Added followup to be consistent across the board. Passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21456 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21456 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21456 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Small enhancement, nearly a bug so pushed to 17.11.x for 17.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21456 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21456 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org