[Bug 41700] New: Checkouts note_date has incorrect format in swagger definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41700 Bug ID: 41700 Summary: Checkouts note_date has incorrect format in swagger definitions Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: tomascohen@gmail.com note_date is defined as 'date' in checkout.yaml in the issues table it is a datetime. This is causing errors To recreate: 1 - Enable issue notes: AllowCheckoutNotes preference 2 - Issue an item to a patron 3 - Sign in to opac as that patron, add a note 4 - Have staff client open and a second tab try: http://localhost:8081/api/v1/checkouts/ 5 - Error "message":"Does not match date format.","path":"\/body\/0\/note_date" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41700 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41700 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 191985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191985&action=edit Bug 41700: Update note_date to datetime This patch updates the swaager definition to have the correct format To test: 1 - Enable issue notes: AllowCheckoutNotes preference 2 - Issue an item to a patron 3 - Sign in to opac as that patron, add a note 4 - Have staff client open and a second tab try: http://localhost:8081/api/v1/checkouts/ 5 - Error "message":"Does not match date format.","path":"\/body\/0\/note_date" 6 - Apply patch, yarn build, restart all 7 - Refresh the page 8 - Success! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41700 --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 191986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191986&action=edit Bug 41700: Unit test -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41700 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41700 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191985|0 |1 is obsolete| | Attachment #191986|0 |1 is obsolete| | --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 191987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191987&action=edit Bug 41700: Update note_date to datetime This patch updates the swaager definition to have the correct format To test: 1 - Enable issue notes: AllowCheckoutNotes preference 2 - Issue an item to a patron 3 - Sign in to opac as that patron, add a note 4 - Have staff client open and a second tab try: http://localhost:8081/api/v1/checkouts/ 5 - Error "message":"Does not match date format.","path":"\/body\/0\/note_date" 6 - Apply patch, yarn build, restart all 7 - Refresh the page 8 - Success! Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41700 --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 191988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191988&action=edit Bug 41700: Unit test Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41700 --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Trivial, but far reaching self SO -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41700 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41700 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41700 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191987|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41700 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191988|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41700 --- Comment #6 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 192029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192029&action=edit Bug 41700: Update note_date to datetime This patch updates the swaager definition to have the correct format To test: 1 - Enable issue notes: AllowCheckoutNotes preference 2 - Issue an item to a patron 3 - Sign in to opac as that patron, add a note 4 - Have staff client open and a second tab try: http://localhost:8081/api/v1/checkouts/ 5 - Error "message":"Does not match date format.","path":"\/body\/0\/note_date" 6 - Apply patch, yarn build, restart all 7 - Refresh the page 8 - Success! Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41700 --- Comment #7 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 192030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192030&action=edit Bug 41700: Unit test Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41700 --- Comment #8 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Trivial fix, QA script happy, tests pass. Thanks, Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41700 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192029|0 |1 is obsolete| | --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 192135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192135&action=edit Bug 41700: Update note_date to datetime This patch updates the swaager definition to have the correct format To test: 1 - Enable issue notes: AllowCheckoutNotes preference 2 - Issue an item to a patron 3 - Sign in to opac as that patron, add a note 4 - Have staff client open and a second tab try: http://localhost:8081/api/v1/checkouts/ 5 - Error "message":"Does not match date format.","path":"\/body\/0\/note_date" 6 - Apply patch, yarn build, restart all 7 - Refresh the page 8 - Success! Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41700 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192030|0 |1 is obsolete| | --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 192136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192136&action=edit Bug 41700: Unit test Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41700 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Ive attached back tidied patches but you should mind your QA tools. ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41700 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41700 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41700 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41700 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41700 --- Comment #13 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org