[Bug 18810] New: Update Font Awesome to 4.7.0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18810 Bug ID: 18810 Summary: Update Font Awesome to 4.7.0 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: Needs Signoff Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org Patch complexity: Small patch Status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18810 --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 64458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64458&action=edit Bug 18810: Update Font Awesome to 4.7.0 Test plan: 0) Apply the patch 1) Edit a template and use any of the new icons, see http://fontawesome.io/icons/ 2) Verify that the added icon is shown -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18810 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18810 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- Testing using the following lines in syspref IntranetmainUserblock: <i class="fa fa-address-book"></i> Adress book<br /> <i class="fa fa-address-card"></i> Adress card<br /> <i class="fa fa-envelope-open"></i> Envelope open<br /> <i class="fa fa-times-rectangle"></i> Times rectangle ...OK -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18810 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64458|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 64482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64482&action=edit Bug 18810: Update Font Awesome to 4.7.0 Test plan: 0) Apply the patch 1) Edit a template and use any of the new icons, see http://fontawesome.io/icons/ 2) Verify that the added icon is shown For alternative test see comment #2. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18810 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18810 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|josef.moravec@gmail.com |kyle@bywatersolutions.com CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18810 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle@bywatersolutions.com |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18810 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18810 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64482|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 66742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66742&action=edit Bug 18810: Update Font Awesome to 4.7.0 Test plan: 0) Apply the patch 1) Edit a template and use any of the new icons, see http://fontawesome.io/icons/ 2) Verify that the added icon is shown For alternative test see comment #2. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18810 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66742|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 66743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66743&action=edit Bug 18810: Update Font Awesome to 4.7.0 Test plan: 0) Apply the patch 1) Edit a template and use any of the new icons, see http://fontawesome.io/icons/ 2) Verify that the added icon is shown For alternative test see comment #2. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18810 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18810 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |RESOLVED --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org