[Bug 13871] New: OverDrive message when user authentication fails
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Bug ID: 13871 Summary: OverDrive message when user authentication fails Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: bob@calyx.net.au QA Contact: testopia@bugs.koha-community.org When a Koha user offers correct credentials, Overdrive redirects to the users' Overdrive account page and no messages from Koha are displayed. However: 1. Where a correct cardnumber is entered with an incorrect password, Koha's SIP server responds with '(1) Greetings from Koha.' 2. Where an incorrect cardnumber is entered (with any password), the SIP server responds with a blank message: '(1) ' These are displayed on an Overdrive page which includes a link: 'Click here to return to the sign in form' but there is nothing to draw the user's attention to their error and the need to follow that link back to try again. We propose to replace these messages with 'You have entered an incorrect cardnumber or password. Please try again.' This will appear just above the 'Click here to return ...' link and should make the process obvious for the user. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Bob Birchall <bob@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored --- Comment #1 from Bob Birchall <bob@calyx.net.au> --- This change is being sponsored by Melbourne Athenaeum Library. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #2 from Bob Birchall <bob@calyx.net.au> --- Colin Campbell wrote: I've had this reported recently but havent been able to look at it. I think there might be a change of behaviour I think screen message used to get a default value in cases like this rather than the cryptic "1". It may be the initial flag value for screen_msg in ILS::Patron is not getting replaced by a default? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Bob Birchall <bob@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Bob Birchall <bob@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #3 from Mason James <mtj@kohaaloha.com> --- Created attachment 37539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37539&action=edit Bug 13871 - OverDrive message when user authentication fails perltidy build_patron_status() sub -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37539|0 |1 is obsolete| | --- Comment #4 from Mason James <mtj@kohaaloha.com> --- Created attachment 37543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37543&action=edit Bug 13871 - OverDrive message when user authentication fails NOTE: apply this patch after the additional perltidy patch this patch is basically a small work-around to fix some confusing login text, when users enter incorrect auth details via Overdrive's website with this option disabled (default) there is no change to SIP's behaviour to test... 1/ configure your overdrive account to talk to your Koha's SIP service 2/ start Koha's SIP 3/ enter a correct username and correct password in overdrive see overdrive display '(1) Greetings from Koha…' (good) 4/ enter a correct username and *incorrect* password in overdrive see overdrive display '(1) Greetings from Koha…' (bad) 5/ enter an incorrect username in overdrive see overdrive display '(1)' (badder) 6/ apply patch, enable 'overdrive-mode' in Koha's SIPConfig.xml example... --------------------- <accounts> <login id="kohasip" password="xxxxx" delimiter="|" error-detect="enabled" institution="YYY" overdrive-mode="1" /> </accounts> --------------------- 7/ restart SIP 8/ enter a correct username and correct password see overdrive display '(1) Greetings from Koha…' 9/ enter a correct username and *incorrect* password see overdrive display '(1) Invalid patron or patron password' 10/ enter an incorrect username and incorrect password see overdrive display '(1) Invalid patron or patron password' http://bugs.koha-community.org/show_bug.cgi?id=1387 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37539|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Bob Birchall <bob@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Bob Birchall <bob@calyx.net.au> --- This is running in production for the sponsor, using 3.16.07. It works nicely. I'll sign off, but it may need another sign-off against Master? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Mason, can the first patch be obsoleted? I think this is not a problem specific to OverDrive, but to the error messages from the SIP server? Shoudl we adjust the title? To have the library show up in the release notes as a sponsor, you can add Sponsored-by: ... to the commit message (http://wiki.koha-community.org/wiki/Commit_messages) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #7 from Mason James <mtj@kohaaloha.com> --- (In reply to Katrin Fischer from comment #6)
Hi Mason,
can the first patch be obsoleted?
hmm, no - it's a perltidy patch, that the feature depends on as you can see from the tidy patch, the sub() desperately needed tidying
I think this is not a problem specific to OverDrive, but to the error messages from the SIP server? Shoudl we adjust the title?
sure, thats fine with me i really was thinking about calling the bug/patch something a bit more general. but i couldn't really think of anything suitable
To have the library show up in the release notes as a sponsor, you can add Sponsored-by: ... to the commit message (http://wiki.koha-community.org/wiki/Commit_messages)
thanks, i'll do that :0) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |colin.campbell@ptfs-europe. | |com Component|OPAC |SIP2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |In Discussion --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pardon my being late to reply to this, but could this be solved with a a screen message regex? <screen_msg_regex find="(1) " replace="Invalid patron or patron password" /> If not, please reset the status of this bug. (In reply to Bob Birchall from comment #0)
When a Koha user offers correct credentials, Overdrive redirects to the users' Overdrive account page and no messages from Koha are displayed.
However: 1. Where a correct cardnumber is entered with an incorrect password, Koha's SIP server responds with '(1) Greetings from Koha.' 2. Where an incorrect cardnumber is entered (with any password), the SIP server responds with a blank message: '(1) '
These are displayed on an Overdrive page which includes a link: 'Click here to return to the sign in form' but there is nothing to draw the user's attention to their error and the need to follow that link back to try again.
We propose to replace these messages with 'You have entered an incorrect cardnumber or password. Please try again.' This will appear just above the 'Click here to return ...' link and should make the process obvious for the user.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, not sure this would work? 3/ enter a correct username and correct password in overdrive see overdrive display '(1) Greetings from Koha…' (good) 4/ enter a correct username and *incorrect* password in overdrive see overdrive display '(1) Greetings from Koha…' (bad) 5/ enter an incorrect username in overdrive see overdrive display '(1)' (badder) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- ... and 1 being the cardnumber. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- I see. I hadn't looked deeply enough to realize 1 was the card number. In that case my solution won't work. (In reply to Katrin Fischer from comment #10)
... and 1 being the cardnumber.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37539|0 |1 is obsolete| | Attachment #37543|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38451&action=edit Bug 13871 - perltidy build_patron_status perltidy build_patron_status() sub -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38451|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38452&action=edit Bug 13871 - perltidy build_patron_status perltidy build_patron_status() sub -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38453&action=edit Bug 13871 - OverDrive message when user authentication fails NOTE: apply this patch after the additional perltidy patch this patch is basically a small work-around to fix some confusing login text, when users enter incorrect auth details via Overdrive's website with this option disabled (default) there is no change to SIP's behaviour to test... 1/ configure your overdrive account to talk to your Koha's SIP service 2/ start Koha's SIP 3/ enter a correct username and correct password in overdrive see overdrive display '(1) Greetings from Koha…' (good) 4/ enter a correct username and *incorrect* password in overdrive see overdrive display '(1) Greetings from Koha…' (bad) 5/ enter an incorrect username in overdrive see overdrive display '(1)' (badder) 6/ apply patch, enable 'overdrive-mode' in Koha's SIPConfig.xml example... --------------------- <accounts> <login id="kohasip" password="xxxxx" delimiter="|" error-detect="enabled" institution="YYY" overdrive-mode="1" /> </accounts> --------------------- 7/ restart SIP 8/ enter a correct username and correct password see overdrive display '(1) Greetings from Koha…' 9/ enter a correct username and *incorrect* password see overdrive display '(1) Invalid patron or patron password' 10/ enter an incorrect username and incorrect password see overdrive display '(1) Invalid patron or patron password' http://bugs.koha-community.org/show_bug.cgi?id=1387 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38454&action=edit Bug 13871 [QA Followup] - Rename parameter to send_msg_on_invalid_credentials There are likely other services that would use this same feature. Let's name it something a bit more general. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38455&action=edit Bug 13871 [QA Followup] - Fix namespaces -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- This is looking really good, but I think if we are going to change the behavior for the patron status response, I think we should have the same behavior for the patron information response as well. Mason, can you implement that? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #18 from Mason James <mtj@kohaaloha.com> --- sorry, i missed some questions here... (In reply to Kyle M Hall from comment #8)
Pardon my being late to reply to this, but could this be solved with a a screen message regex?
<screen_msg_regex find="(1) " replace="Invalid patron or patron password" />
^ no that wont work, the glitchy '(1)' string is created within the Overdrive app, and external to Koha -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #19 from Mason James <mtj@kohaaloha.com> --- (In reply to Kyle M Hall from comment #11)
I see. I hadn't looked deeply enough to realize 1 was the card number. In that case my solution won't work.
(In reply to Katrin Fischer from comment #10)
... and 1 being the cardnumber.
just to confirm, (1) appears to be random string from within the Overdrive app ..it's not related to any 'id' within Koha -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #20 from Bob Birchall <bob@calyx.net.au> --- Given Mason's comments, does this still need to be in Failed QA? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Mason James from comment #19)
(In reply to Kyle M Hall from comment #11)
I see. I hadn't looked deeply enough to realize 1 was the card number. In that case my solution won't work.
(In reply to Katrin Fischer from comment #10)
... and 1 being the cardnumber.
just to confirm, (1) appears to be random string from within the Overdrive app ..it's not related to any 'id' within Koha
So for the patron status response, Koha is sending back the "(1)" but not for the patron information response? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #22 from Mason James <mtj@kohaaloha.com> --- (In reply to Kyle M Hall from comment #21)
(In reply to Mason James from comment #19)
(In reply to Kyle M Hall from comment #11)
I see. I hadn't looked deeply enough to realize 1 was the card number. In that case my solution won't work.
(In reply to Katrin Fischer from comment #10)
... and 1 being the cardnumber.
just to confirm, (1) appears to be random string from within the Overdrive app ..it's not related to any 'id' within Koha
So for the patron status response, Koha is sending back the "(1)" but not for the patron information response?
Nope, afaik, the '(1)' string is created and displayed completely within the Overdrive web app ..therefore, it is impossible to correct/remove this string within Koha -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #23 from Mason James <mtj@kohaaloha.com> --- (In reply to Bob Birchall from comment #20)
Given Mason's comments, does this still need to be in Failed QA?
any update Kyle? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> ---
Nope, afaik, the '(1)' string is created and displayed completely within the Overdrive web app ..therefore, it is impossible to correct/remove this string within Koha
That seems like quite a coincidence, but I've no reason to doubt you! Back to needs signoff! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38452|0 |1 is obsolete| | Attachment #38453|0 |1 is obsolete| | Attachment #38454|0 |1 is obsolete| | Attachment #38455|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45645&action=edit Bug 13871 - perltidy build_patron_status perltidy build_patron_status() sub Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45645|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45646&action=edit Bug 13871 - perltidy build_patron_status perltidy build_patron_status() sub Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45647&action=edit Bug 13871 - OverDrive message when user authentication fails NOTE: apply this patch after the additional perltidy patch this patch is basically a small work-around to fix some confusing login text, when users enter incorrect auth details via Overdrive's website with this option disabled (default) there is no change to SIP's behaviour to test... 1/ configure your overdrive account to talk to your Koha's SIP service 2/ start Koha's SIP 3/ enter a correct username and correct password in overdrive see overdrive display '(1) Greetings from Koha…' (good) 4/ enter a correct username and *incorrect* password in overdrive see overdrive display '(1) Greetings from Koha…' (bad) 5/ enter an incorrect username in overdrive see overdrive display '(1)' (badder) 6/ apply patch, enable 'overdrive-mode' in Koha's SIPConfig.xml example... --------------------- <accounts> <login id="kohasip" password="xxxxx" delimiter="|" error-detect="enabled" institution="YYY" overdrive-mode="1" /> </accounts> --------------------- 7/ restart SIP 8/ enter a correct username and correct password see overdrive display '(1) Greetings from Koha…' 9/ enter a correct username and *incorrect* password see overdrive display '(1) Invalid patron or patron password' 10/ enter an incorrect username and incorrect password see overdrive display '(1) Invalid patron or patron password' http://bugs.koha-community.org/show_bug.cgi?id=1387 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45648&action=edit Bug 13871 [QA Followup] - Rename parameter to send_msg_on_invalid_credentials There are likely other services that would use this same feature. Let's name it something a bit more general. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45649&action=edit Bug 13871 [QA Followup] - Fix namespaces Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org