[Bug 35676] New: OPAC search results - link for "Check for suggestions" generates a blank page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35676 Bug ID: 35676 Summary: OPAC search results - link for "Check for suggestions" generates a blank page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org In the OPAC when searching, after the "Your search returned XX results" there is some text: "Not what you expected? Check for suggestions" 'suggestions' is linked to /cgi-bin/koha/svc/suggestion?render=standalone&q=cat This returns a blank page. I could not see any error messages in the logs, or any JavaScript errors in the browser web developer tools console. To replicate: 1. Go to the OPAC and perform a search (for example: cat) (it doesn't matter if you are logged in or not). 2. In the text area after "You search returned XX results" there is some text "Not what you expected? Check for suggestions)", 'suggestions' is linked. 3. Click on the link for 'suggestions'. 4. You get a blank page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35676 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35676 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Status|NEW |ASSIGNED Depends on| |34866 CC| |jonathan.druart+koha@gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Caused by bug 34866 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34866 [Bug 34866] Use template wrapper for breadcrumbs: OPAC part 4 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35676 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35676 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160942&action=edit Bug 35676: Fix DidYouMean when not configured When DidYouMean is not configured, there is the following message displayed: "Not what you expected? Check for suggestions" suggestions is a link to svc/suggestion which does not return content if the feature is displayed 90 unless ( @plugins ) { 91 print $query->header; 92 exit; 93 } We should not see this text, it is supposed to be replaced when the ft is enabled. However commit 79bf4485c1b2ae8059e2ee15ea1e67bba9961c34 Bug 34866: Use template wrapper for breadcrumbs: OPAC part 4 made this change: - [% IF ( DidYouMean ) %] + [% #IF ( DidYouMean ) %] <div id="didyoumean">Not what you expected? Check for <a href="/cgi-bin/koha/svc/suggestion?render=standalone&q=[% querystring | uri %]">suggestions</a></div> - [% END %] + [% #END %] Which is obviously wrong. Test plan: Do not have the ft configured and launch a search (OPAC) that will not return any results. => Without this patch there is the message => With this patch applied it is no longer displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35676 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35676 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35676 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160942|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160962&action=edit Bug 35676: Fix DidYouMean when not configured When DidYouMean is not configured, there is the following message displayed: "Not what you expected? Check for suggestions" suggestions is a link to svc/suggestion which does not return content if the feature is displayed 90 unless ( @plugins ) { 91 print $query->header; 92 exit; 93 } We should not see this text, it is supposed to be replaced when the ft is enabled. However commit 79bf4485c1b2ae8059e2ee15ea1e67bba9961c34 Bug 34866: Use template wrapper for breadcrumbs: OPAC part 4 made this change: - [% IF ( DidYouMean ) %] + [% #IF ( DidYouMean ) %] <div id="didyoumean">Not what you expected? Check for <a href="/cgi-bin/koha/svc/suggestion?render=standalone&q=[% querystring | uri %]">suggestions</a></div> - [% END %] + [% #END %] Which is obviously wrong. Test plan: Do not have the ft configured and launch a search (OPAC) that will not return any results. => Without this patch there is the message => With this patch applied it is no longer displayed Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35676 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35676 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35676 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160962|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160970&action=edit Bug 35676: Fix DidYouMean when not configured When DidYouMean is not configured, there is the following message displayed: "Not what you expected? Check for suggestions" suggestions is a link to svc/suggestion which does not return content if the feature is displayed 90 unless ( @plugins ) { 91 print $query->header; 92 exit; 93 } We should not see this text, it is supposed to be replaced when the ft is enabled. However commit 79bf4485c1b2ae8059e2ee15ea1e67bba9961c34 Bug 34866: Use template wrapper for breadcrumbs: OPAC part 4 made this change: - [% IF ( DidYouMean ) %] + [% #IF ( DidYouMean ) %] <div id="didyoumean">Not what you expected? Check for <a href="/cgi-bin/koha/svc/suggestion?render=standalone&q=[% querystring | uri %]">suggestions</a></div> - [% END %] + [% #END %] Which is obviously wrong. Test plan: Do not have the ft configured and launch a search (OPAC) that will not return any results. => Without this patch there is the message => With this patch applied it is no longer displayed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35676 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35676 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35676 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.02 released in| | --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35676 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliothek@th-wildau.de --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 35958 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35676 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Based on Bug 35958 it looks like folks on 23.05 would like a backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35676 --- Comment #9 from Jan Kissig <bibliothek@th-wildau.de> --- (In reply to Owen Leonard from comment #8)
Based on Bug 35958 it looks like folks on 23.05 would like a backport.
Sorry for wrong version tag in bug 35958 as we ware already running 23.11.01. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35676 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org