[Bug 22898] New: Selenium tests for placing holds from the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Bug ID: 22898 Summary: Selenium tests for placing holds from the staff interface Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Because of bug 22895 we now need those tests ASAP. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19384 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384 [Bug 19384] [OMNIBUS] Add Selenium tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89673&action=edit Bug 22898: Add selenium tests placing holds (staff) Quick selenium tests to prevent regressions like bug 22895. Test plan: Make sure the selenium tests return green You can also test the buggy branch: % git checkout v18.11.05 % prove t/db_dependent/selenium/basic_workflow.t => Failure % git bz apply 22895. % prove t/db_dependent/selenium/basic_workflow.t => Success -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89673|0 |1 is obsolete| | --- Comment #2 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 90208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90208&action=edit Bug 22898: Add selenium tests placing holds (staff) Quick selenium tests to prevent regressions like bug 22895. Test plan: Make sure the selenium tests return green You can also test the buggy branch: % git checkout v18.11.05 % prove t/db_dependent/selenium/basic_workflow.t => Failure % git bz apply 22895. % prove t/db_dependent/selenium/basic_workflow.t => Success Signed-off-by: Victor Grousset <victor.grousset@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 --- Comment #3 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> ---
You can also test the buggy branch:
Applying this patch on v18.11.05 conflicts. I think I might be able to backport it, is it worth it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 --- Comment #4 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- this patch: 22898, the new tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 90241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90241&action=edit Bug 22898: [v18.11.05] Add selenium tests placing holds (staff) Quick selenium tests to prevent regressions like bug 22895. Test plan: Make sure the selenium tests return green You can also test the buggy branch: % git checkout v18.11.05 % prove t/db_dependent/selenium/basic_workflow.t => Failure % git bz apply 22895. % prove t/db_dependent/selenium/basic_workflow.t => Success -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- New patch for 18.11.05, unfortunately I was not able to test it (firefox-esr version mismatch in kohadevbox) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Victor Grousset/tuxayo from comment #3)
You can also test the buggy branch:
Applying this patch on v18.11.05 conflicts. I think I might be able to backport it, is it worth it?
Always good to have more tests :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've got a little lost.. what's the state of these.. do they need testing independently on both 18.11.x and master at this point? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #8)
I've got a little lost.. what's the state of these.. do they need testing independently on both 18.11.x and master at this point?
18.05.x patch was to recreate the failure, see test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This needs updating for current master.. the tests currently fail. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97655&action=edit Bug 22898: Since bug 23957, submit element is now a button (no longer input) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97656&action=edit Bug 22898: Fix failure since bug 19618 See comment in the code, this is not the correct fix, but cannot find something better for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Needs a rebase for the circ rules work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90208|0 |1 is obsolete| | Attachment #90241|0 |1 is obsolete| | Attachment #97655|0 |1 is obsolete| | Attachment #97656|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98877&action=edit Bug 22898: Add selenium tests placing holds (staff) Quick selenium tests to prevent regressions like bug 22895. Test plan: Make sure the selenium tests return green You can also test the buggy branch: % git checkout v18.11.05 % prove t/db_dependent/selenium/basic_workflow.t => Failure % git bz apply 22895. % prove t/db_dependent/selenium/basic_workflow.t => Success Signed-off-by: Victor Grousset <victor.grousset@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98878&action=edit Bug 22898: Since bug 23957, submit element is now a button (no longer input) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98879&action=edit Bug 22898: Fix failure since bug 19618 See comment in the code, this is not the correct fix, but cannot find something better for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I skip the 18.11 patch. New test plan: Make sure the tests pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98877|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98880&action=edit Bug 22898: Add selenium tests placing holds (staff) Quick selenium tests to prevent regressions like bug 22895. Test plan: Make sure the selenium tests return green You can also test the buggy branch: % git checkout v18.11.05 % prove t/db_dependent/selenium/basic_workflow.t => Failure % git bz apply 22895. % prove t/db_dependent/selenium/basic_workflow.t => Success Signed-off-by: Victor Grousset <victor.grousset@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98878|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98881&action=edit Bug 22898: Since bug 23957, submit element is now a button (no longer input) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98879|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98882&action=edit Bug 22898: Fix failure since bug 19618 See comment in the code, this is not the correct fix, but cannot find something better for now. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We're better off with these tests than without.. they are all currently passing and read ok.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |joy@bywatersolutions.com Resolution|--- |FIXED --- Comment #23 from Joy Nelson <joy@bywatersolutions.com> --- does not apply to 19.11.x branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org