http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13966 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #2 from Mason James <mtj@kohaaloha.com> --- Once this patch is appears in a future Koha release, the HEA patchset can be added to older Kohas. Note: this patch is not essential for HEA to be backported, as the 'duplicated rows' SQL warnings without this patch are harmless and not fatal - but it would be nice to avoid those warnings, if possible -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13966 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- What's the discussion here? The patch does not apply on 3.14.x nor 3.16.x. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13966 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Mason James from comment #4)

(In reply to Jonathan Druart from comment #3)

...

What's the discussion here? The patch does not apply on 3.14.x nor 3.16.x.

the patch is only to be applied for the master/3.18.x branches

it's just to stop any 'duplicate rows' SQL upgrade warnings, when a 3.16/3.14 Koha upgrades to 3.18.x or higher

make sense?

Ha yes, sorry. It defenitely makes sense! So needs signoff :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13966 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. Tompsett from comment #6)

Test plan?

Test plan: 1/ Look at the patch 2/ You will know what you should test 3/ I you don't, test another patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13966 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37559|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38003&action=edit Bug 13966 - Backport HEA to Koha 3.16 and/or 3.14 This trivial patch stops any potential SQL errors/warnings for a HEA enabled 3.16 or 3.14 Koha, when upgrading to a newer Koha Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Add the missing prefs unless they exist and don't raise an error if already exist. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13966 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Websites, Mailing Lists, |Database |etc | Assignee|wizzyrea@gmail.com |gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13966 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think that now we need the patch in master, 3.20 and 3.18? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13966 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38003|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 39954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39954&action=edit [PASSED QA] Bug 13966 - Backport HEA to Koha 3.16 and/or 3.14 This trivial patch stops any potential SQL errors/warnings for a HEA enabled 3.16 or 3.14 Koha, when upgrading to a newer Koha Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Add the missing prefs unless they exist and don't raise an error if already exist. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13966 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_18_candidate -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13966 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz, | |liz@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13966 --- Comment #12 from Mason James <mtj@kohaaloha.com> --- (In reply to Katrin Fischer from comment #9)

I think that now we need the patch in master, 3.20 and 3.18?

RMaints(In reply to Mason James from comment #11)

(In reply to Katrin Fischer from comment #9)

...

I think that now we need the patch in master, 3.20 and 3.18?

yep, thats correct Katrin

Patch has passed QA, and is waiting to be pulled to master, 3.22, 3.20 and 3.18 branches -- You are receiving this mail because: You are watching all bug changes.