[Bug 32665] New: warnPrefRequireChoosingExistingAuthority condition incorrect in about.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32665 Bug ID: 32665 Summary: warnPrefRequireChoosingExistingAuthority condition incorrect in about.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org warnPrefRequireChoosingExistingAuthority won't display on about.pl if it's the only problem since the top level condition has a typo. It's written as warnRequireChoosingExistingAuthority -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32665 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32665 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 145382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145382&action=edit Bug 32665: Fix typo in template condition This patch fixes a typo in a template condition so that the about.pl warning about RequireChoosingExistingAuthority is shown when it's the only warning to display Test plan: 0. Don't apply the patch yet 1. Go to http://localhost:8081/cgi-bin/koha/about.pl 2. Note that "No warnings" is shown 3. Apply the patch 4. Go to http://localhost:8081/cgi-bin/koha/about.pl 5. Note that there is a heading for "Warnings regarding the system configuration" and a specific warning about the "RequireChoosingExistingAuthority" system preference -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32665 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32665 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32665 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145382|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 145391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145391&action=edit Bug 32665: Fix typo in template condition This patch fixes a typo in a template condition so that the about.pl warning about RequireChoosingExistingAuthority is shown when it's the only warning to display Test plan: 0. Don't apply the patch yet 1. Go to http://localhost:8081/cgi-bin/koha/about.pl 2. Note that "No warnings" is shown 3. Apply the patch 4. Go to http://localhost:8081/cgi-bin/koha/about.pl 5. Note that there is a heading for "Warnings regarding the system configuration" and a specific warning about the "RequireChoosingExistingAuthority" system preference Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32665 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Testing notes: Both RequireChoosingExistingAuthority and AutoCreateAuthorites should be disabled in system preferences. If you have any other warnings under the "System Information" tab you must resolve them to reproduce the error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32665 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32665 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook@prosentient.com.au |koha-bugs@lists.koha-commun | |ity.org --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Happy for someone to take over this one. Seemed like a simple fix but also vulnerable to needing a lot of rebasing before getting pushed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32665 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Maybe I should just do it. Just feeling overwhelmed by the amount to do... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32665 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32665 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145391|0 |1 is obsolete| | --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Created attachment 147279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147279&action=edit Bug 32665: Fix typo in template condition This patch fixes a typo in a template condition so that the about.pl warning about RequireChoosingExistingAuthority is shown when it's the only warning to display Test plan: 0. Don't apply the patch yet 1. Go to http://localhost:8081/cgi-bin/koha/about.pl 2. Note that "No warnings" is shown 3. Apply the patch 4. Go to http://localhost:8081/cgi-bin/koha/about.pl 5. Note that there is a heading for "Warnings regarding the system configuration" and a specific warning about the "RequireChoosingExistingAuthority" system preference Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32665 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32665 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147279|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147399&action=edit Bug 32665: Fix typo in template condition This patch fixes a typo in a template condition so that the about.pl warning about RequireChoosingExistingAuthority is shown when it's the only warning to display Test plan: 0. Don't apply the patch yet 1. Go to http://localhost:8081/cgi-bin/koha/about.pl 2. Note that "No warnings" is shown 3. Apply the patch 4. Go to http://localhost:8081/cgi-bin/koha/about.pl 5. Note that there is a heading for "Warnings regarding the system configuration" and a specific warning about the "RequireChoosingExistingAuthority" system preference Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32665 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32665 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32665 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32665 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org