[Bug 7806] New: Illegal dates are used to signal non existing dates.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Priority: P5 - low Change sponsored?: --- Bug ID: 7806 Assignee: gmcharlt@gmail.com Summary: Illegal dates are used to signal non existing dates. QA Contact: koha.sekjal@gmail.com Severity: major Classification: Unclassified OS: All Reporter: marc@msys.ch Hardware: All Status: NEW Version: unspecified Component: Database Product: Koha The illegal date '0000-00-00' is being used in Koha to signal a non-existing date. MySQL allows for such illegal dates. A database like PostgreSQL, which is much more strict when it comes to correct data, does not allow illegal values as date values. If a date is inexistant/invalid etc. an SQL NULL must be used instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Marc Balmer <marc@msys.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7365 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Severity|major |normal --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- My search of Koha code returns only instances where checks are being done for a '0000-00-00' value but no instances where a '0000-00-00' value is being set, with one exception: sample_quotes.sql -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- How could we remove all the checks of 0000-00-00 in the code? I personally have no good idea. We could remove the not null constraint and update all date fields with NULL. Or keep the constraint and update with 1970-01-01. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I like NULL better and it looks less dangerous and cleaner than 1970-01-01 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #4 from Marc Balmer <marc@msys.ch> --- Using a valid date like 1.1.1970 to denote an invalid date is so obviously a bad idea. I suggest to go the NULL route. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- I really don't know where I have found this stupid idea :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org