https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17628 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 [Bug 17628] Move bibliographic related code to Koha::Biblio -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61122&action=edit Bug 18276: Remove GetBiblioFromItemNumber - Course reserves Values from the items, biblio and biblioitems tables are used in the template, so we need to pass all of them to the template, but separately. That way we easily see which field from which table we are displaying. Test plan: Create a course reserve and add items. Correct information must be displayed on the detail page of the course reserve, on staff and OPAC interface. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61124&action=edit Bug 18276: Remove GetBiblioFromItemNumber - circulation pages Test plan: 1. Checkout items in a batch The information displayed should be ok (title, subtitles, author, itemnotes, barcode) 2. Checkout an item using the standard checkout page You should correctly see the information of the item that has been checked out (title and author) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61126&action=edit Bug 18276: Remove the C4::Biblio::GetBiblioFromItemNumber subroutine -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #6 from Marc Véron <veron@veron.ch> --- While testing first patch I get an Internal Server Error. Plack error log says: Template process failed: undef error - The method ccode is not covered by tests! at (...)/C4/Templates.pm line 121. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61178&action=edit Bug 18276: Remove GetBiblioFromItemNumber - ILSDI Test plan: Hit /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=51&show_holds=1 The results should be the same before and after this patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61180&action=edit Bug 18276: Remove GetBiblioFromItemNumber - Easy ones The subroutine C4::Biblio::GetBiblioFromItemNumber was wrong for several reasons: - badly named, we can get biblio info from a barcode - SELECT * from items, biblio and biblioitems makes things hard to follow and debug, we never know where do come from the value we display - sometimes called only for trivial information such as biblionumber, author or title This patchset suggests to replace it with calls to: - Koha::Items->find for item's info - $item->biblio for biblio's info - $item->biblio->biblioitem for biblioitem's info Test plan: Item's info should correctly be displayed on the following pages: - circulation history - transfer book - checkin - waiting holds QA will check the other changes reading the code, it's trivial -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #12 from Marc Véron <veron@veron.ch> --- Merge conflicts in 1st patch: koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt course_reserves/add_items.pl Maybe a merge conflict in 3rd patch as well (other patches applied when i skipped 1st and 3rd patch) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62082&action=edit Bug 18276: Remove GetBiblioFromItemNumber - ILSDI Test plan: Hit /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=51&show_holds=1 The results should be the same before and after this patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62084&action=edit Bug 18276: Remove GetBiblioFromItemNumber - Easy ones The subroutine C4::Biblio::GetBiblioFromItemNumber was wrong for several reasons: - badly named, we can get biblio info from a barcode - SELECT * from items, biblio and biblioitems makes things hard to follow and debug, we never know where do come from the value we display - sometimes called only for trivial information such as biblionumber, author or title This patchset suggests to replace it with calls to: - Koha::Items->find for item's info - $item->biblio for biblio's info - $item->biblio->biblioitem for biblioitem's info Test plan: Item's info should correctly be displayed on the following pages: - circulation history - transfer book - checkin - waiting holds QA will check the other changes reading the code, it's trivial -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #18 from Marc Véron <veron@veron.ch> --- Bug 18276: Remove GetBiblioFromItemNumber - Course reserves: Internal server error while displaying course detail in OPAC. Plack error log says: Template process failed: undef error - The method datedue is not covered by tests! at .../koha/C4/Templates.pm line 121 It must be related with line 76 of opac-course-details.tt rsp. an error inside item-status.inc <td>[% INCLUDE 'item-status.inc' item=cr.item issue=cr.issue %]</td> (No error if I remove the template directive) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #19)

Kyle, could you take a look please? On current master opac-course-details.tt includes item-status.inc. But to be displayed correctly the status need info from the checkout. These info are never sent to the template. What were you expecting to display under this "status" column?

Each element in the course_reserves loop should have a key 'issue' if it has an open issue. This data is pulled by GetCourseReserves using GetOpenIssue. It's meant to show what the item's general status is ( available, lost, damaged, checked out, etc ). Does that make sense? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62081|0 |1 is obsolete| | Attachment #62082|0 |1 is obsolete| | Attachment #62083|0 |1 is obsolete| | Attachment #62084|0 |1 is obsolete| | Attachment #62085|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62476&action=edit Bug 18276: Remove GetBiblioFromItemNumber - Course reserves Values from the items, biblio and biblioitems tables are used in the template, so we need to pass all of them to the template, but separately. That way we easily see which field from which table we are displaying. Test plan: Create a course reserve and add items. Correct information must be displayed on the detail page of the course reserve, on staff and OPAC interface. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62478&action=edit Bug 18276: Remove GetBiblioFromItemNumber - circulation pages Test plan: 1. Checkout items in a batch The information displayed should be ok (title, subtitles, author, itemnotes, barcode) 2. Checkout an item using the standard checkout page You should correctly see the information of the item that has been checked out (title and author) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62480&action=edit Bug 18276: Remove the C4::Biblio::GetBiblioFromItemNumber subroutine -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |josef.moravec@gmail.com --- Comment #28 from Josef Moravec <josef.moravec@gmail.com> --- I've got this error on course reserve detail page in opac: Template process failed: undef error - The method onsite_checkout is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. Also there are some problems reported by qa tools: FAIL C4/SIP/ILS/Item.pm FAIL forbidden patterns forbidden pattern: tab char (line 74) forbidden pattern: tab char (line 99) forbidden pattern: tab char (line 100) forbidden pattern: tab char (line 90) FAIL C4/SIP/ILS/Transaction/Hold.pm FAIL forbidden patterns forbidden pattern: tab char (line 108) FAIL circ/returns.pl FAIL valid Global symbol "$biblio" requires explicit package name circ/returns.pl had compilation errors. FAIL circ/transferstoreceive.pl FAIL valid Global symbol "$num" requires explicit package name Global symbol "$getransf" requires explicit package name Global symbol "%getransf" requires explicit package name syntax error Global symbol "$biblio" requires explicit package name Global symbol "%branchloop" requires explicit package name circ/transferstoreceive.pl has too many errors. FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/moveitem.tt FAIL forbidden patterns forbidden pattern: tab char (line 39) forbidden pattern: tab char (line 46) FAIL offline_circ/process_koc.pl FAIL valid Global symbol "$biblio" requires explicit package name offline_circ/process_koc.pl had compilation errors. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62476|0 |1 is obsolete| | Attachment #62477|0 |1 is obsolete| | Attachment #62478|0 |1 is obsolete| | Attachment #62479|0 |1 is obsolete| | Attachment #62480|0 |1 is obsolete| | Attachment #62481|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63121&action=edit Bug 18276: Remove GetBiblioFromItemNumber - Course reserves Values from the items, biblio and biblioitems tables are used in the template, so we need to pass all of them to the template, but separately. That way we easily see which field from which table we are displaying. Test plan: Create a course reserve and add items. Correct information must be displayed on the detail page of the course reserve, on staff and OPAC interface. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63123&action=edit Bug 18276: Remove GetBiblioFromItemNumber - circulation pages Test plan: 1. Checkout items in a batch The information displayed should be ok (title, subtitles, author, itemnotes, barcode) 2. Checkout an item using the standard checkout page You should correctly see the information of the item that has been checked out (title and author) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63125&action=edit Bug 18276: Remove the C4::Biblio::GetBiblioFromItemNumber subroutine -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I would suggest to not make this change a priority for 17.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #37 from Josef Moravec <josef.moravec@gmail.com> --- All other looks good for me -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Josef Moravec from comment #36)

Works good for item level holds, with title level holds I see:

"Can't call method "biblio" on an undefined value at /home/vagrant/kohaclone/C4/ILSDI/Services.pm line 422"

Great catch Josef! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #41 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63295&action=edit [SIGNED-OFF] Bug 18276: Remove GetBiblioFromItemNumber - ILSDI Test plan: Hit /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=51&show_holds=1 The results should be the same before and after this patch Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #43 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63297&action=edit [SIGNED-OFF] Bug 18276: Remove GetBiblioFromItemNumber - Easy ones The subroutine C4::Biblio::GetBiblioFromItemNumber was wrong for several reasons: - badly named, we can get biblio info from a barcode - SELECT * from items, biblio and biblioitems makes things hard to follow and debug, we never know where do come from the value we display - sometimes called only for trivial information such as biblionumber, author or title This patchset suggests to replace it with calls to: - Koha::Items->find for item's info - $item->biblio for biblio's info - $item->biblio->biblioitem for biblioitem's info Test plan: Item's info should correctly be displayed on the following pages: - circulation history - transfer book - checkin - waiting holds QA will check the other changes reading the code, it's trivial Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #45 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63299&action=edit [SIGNED-OFF] Bug 18276: FIX status display for course reserves This include file is terribly wrong, it's called from different places that do not set the same flag. The status from detail and result page might be different from the one display on the course reserve table. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #47 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #49 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Add checks for find please. Can't call method "biblio" on an undefined value at circ/circulation.pl line 334. Before this patch set you get a warning on an unknown barcode, now an Internal server error.. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63294|0 |1 is obsolete| | Attachment #63295|0 |1 is obsolete| | Attachment #63296|0 |1 is obsolete| | Attachment #63297|0 |1 is obsolete| | Attachment #63298|0 |1 is obsolete| | Attachment #63299|0 |1 is obsolete| | Attachment #63300|0 |1 is obsolete| | Attachment #64748|0 |1 is obsolete| | --- Comment #50 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64809&action=edit Bug 18276: Remove GetBiblioFromItemNumber - Course reserves Values from the items, biblio and biblioitems tables are used in the template, so we need to pass all of them to the template, but separately. That way we easily see which field from which table we are displaying. Test plan: Create a course reserve and add items. Correct information must be displayed on the detail page of the course reserve, on staff and OPAC interface. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #52 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64811&action=edit Bug 18276: Remove GetBiblioFromItemNumber - circulation pages Test plan: 1. Checkout items in a batch The information displayed should be ok (title, subtitles, author, itemnotes, barcode) 2. Checkout an item using the standard checkout page You should correctly see the information of the item that has been checked out (title and author) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #54 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64813&action=edit Bug 18276: Remove the C4::Biblio::GetBiblioFromItemNumber subroutine Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #56 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64815&action=edit Bug 18276: (follow-up) Remove GetBiblioFromItemNumber - ILSDI Take into account biblio level holds Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #58 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Fixed conflicts with bug 17843 and bug 17738. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #60 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #49)

Add checks for find please.

Can't call method "biblio" on an undefined value at circ/circulation.pl line 334.

Before this patch set you get a warning on an unknown barcode, now an Internal server error..

Thanks for catching that Marcel. Must be fixed with the last patch. The other calls look safe. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64810|0 |1 is obsolete| | --- Comment #62 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64879&action=edit Bug 18276: Remove GetBiblioFromItemNumber - ILSDI Test plan: Hit /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=51&show_holds=1 The results should be the same before and after this patch Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64812|0 |1 is obsolete| | --- Comment #64 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64881&action=edit Bug 18276: Remove GetBiblioFromItemNumber - Easy ones The subroutine C4::Biblio::GetBiblioFromItemNumber was wrong for several reasons: - badly named, we can get biblio info from a barcode - SELECT * from items, biblio and biblioitems makes things hard to follow and debug, we never know where do come from the value we display - sometimes called only for trivial information such as biblionumber, author or title This patchset suggests to replace it with calls to: - Koha::Items->find for item's info - $item->biblio for biblio's info - $item->biblio->biblioitem for biblioitem's info Test plan: Item's info should correctly be displayed on the following pages: - circulation history - transfer book - checkin - waiting holds QA will check the other changes reading the code, it's trivial Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64814|0 |1 is obsolete| | --- Comment #66 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64883&action=edit Bug 18276: FIX status display for course reserves This include file is terribly wrong, it's called from different places that do not set the same flag. The status from detail and result page might be different from the one display on the course reserve table. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64816|0 |1 is obsolete| | --- Comment #68 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64885&action=edit Bug 18276: [QA Follow-up] Two newlines to make qa tools happy FAIL pod Apparent command =cut not preceded by blank line in file misc/cronjobs/advance_notices.pl FAIL pod Apparent command =cut not preceded by blank line in file C4/SIP/ILS/Item.pm Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #70 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64887&action=edit Bug 18276: [QA Follow-up] Fix two new calls Found two calls in opac-issue-note.pl and svc/patron_notes. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #71 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64974&action=edit Bug 18276: (follow-up) Remove GetBiblioFromItemNumber - Easy ones -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #73 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19388 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19388 [Bug 19388] Error in course details on OPAC if an item is checked-out -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19651 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651 [Bug 19651] SIP/ILS/Item missing title -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19798 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798 [Bug 19798] Returns.pl doesn't define itemnumber for transfer-slip. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20276 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20546 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20546 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20546 [Bug 20546] Shelving location not displayed on checkin -- You are receiving this mail because: You are watching all bug changes.