https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35722 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |angus.purcell@angels.co.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35722 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey@ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35722 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize@openfifth.c |johanna.raisa@koha-suomi.fi |o.uk | Status|NEW |Needs Signoff --- Comment #2 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 183069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183069&action=edit Bug 35722: Create item transfer REST api This patch creates a REST API for item transfers, allowing users to transfer items between libraries via the API. Test Plan: 1. Apply the patch. 2. perl build-resources.PL 3. prove t/db_dependent/api/v1/items/item_transfers.t 4. Verify that the API endpoints for item transfers work as expected. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35722 Bernard <bernard.scaife@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bernard.scaife@openfifth.co | |.uk Status|Needs Signoff |Signed Off --- Comment #3 from Bernard <bernard.scaife@openfifth.co.uk> --- kohadev-koha@kohadevbox:koha(bug_35722)$ prove t/db_dependent/api/v1/items/item_transfers.t t/db_dependent/api/v1/items/item_transfers.t .. ok All tests successful. Files=1, Tests=5, 10 wallclock secs ( 0.03 usr 0.01 sys + 7.95 cusr 0.70 csys = 8.69 CPU) Result: PASS kohadev-koha@kohadevbox:koha(bug_35722)$ Tested list get add cancel 1. Ensured RESTBasicAuth enabled 2. Installed patch 3. Put an item in transfer in staff intranet. Circulation dashboard, click Transfer. Ensure item is in list of Transferred items. 4. Got itenumber from step 3 and did a curl request: curl --request GET "http://127.0.0.1:8080/api/v1/items/312/transfers" --header "Content-Type: application/json" --user u:p 5. Observed details: to_library_id and from_library_id match step above. Date requested and sent are set - PASS 6. Cancel request from the API curl --request DELETE "http://127.0.0.1:8080/api/v1/items/312/transfers" --header "Content-Type: application/json" --user u:p 7. Listed as in step 4 8. Noted cancellation date added and request cancelled - PASS 9. Added new request curl --request POST "http://127.0.0.1:8080/api/v1/items/313/transfers" --header "Content-Type: application/json" --user u:p --data-raw '{ "to_library_id": "FFL", "reason": "Manual" }' 10. Request added same as if via staff intranet - PASS 11. Tried to add a request for a staff user without permission reserveforothers: place_holds (Place holds for patrons) (edited user's permissions) 10. Repeated step 9 with another itemnumber. 11. Observed {"error":"Invalid password","required_permissions":null} - PASS 12. Listed all requests curl --request GET "http://127.0.0.1:8080/api/v1/items/transfers" --header "Content-Type: application/json" --user u:p 13. Observed list of requests returned - PASS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35722 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #5 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Hi! This isn't applying cleanly could you please rebase? Thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35722 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189753|0 |1 is obsolete| | --- Comment #7 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 197248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197248&action=edit Bug 35722: (follow-up) fix parameters on catalogue detail page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35722 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |tomascohen@gmail.com --- Comment #8 from Lisette Scheer <lisette@bywatersolutions.com> --- Setting empty QA contacts to Default. Some searches don't handle empty QA contact fields well. -- You are receiving this mail because: You are watching all bug changes.