[Bug 10107] New: opacbookbag shouldn't prevent from adding items to a list in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10107 Bug ID: 10107 Summary: opacbookbag shouldn't prevent from adding items to a list in the OPAC Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: tomascohen@gmail.com To reproduce: - Disable the opacbookbag syspref - Login in the OPAC - Create a list (I tested a private one) - Search in your db for some biblios. - Choose some and add them to the created list - Go to your users's page, to the my lists tab - Your list is empty. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10107 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I confirm this in both 'prog' and 'ccsr' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10107 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10107 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to comment #1)
I confirm this in both 'prog' and 'ccsr'
Also only a bug on the search results page, in the detail page it works as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10107 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 17656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17656&action=edit Bug 10107 - opacbookbag shouldn't prevent from adding items to a list in the OPAC This bug is present in master and (at least 3.8.x, where we spotted it). The patch makes adding items, to a list from the results page, not rely only on opacbookbag syspref but also 'virtualshelves'. Regards To+ PS: Thanks Graciela Galli for reporting. Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10107 --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Tomas: Via this report I connect to the encoding stuff: Search for something with diacritics. Try to add it to a list with bookbag disabled. You will see a mangled search expression without results and no item added. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10107 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored Assignee|oleonard@myacpl.org |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10107 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10107 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17656|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 17659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17659&action=edit [SIGNED-OFF] Bug 10107 - opacbookbag shouldn't prevent from adding items to a list in the OPAC This bug is present in master and (at least 3.8.x, where we spotted it). The patch makes adding items, to a list from the results page, not rely only on opacbookbag syspref but also 'virtualshelves'. Regards To+ PS: Thanks Graciela Galli for reporting. Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10107 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10107 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17659|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10107 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17665&action=edit PASSED-QA-Bug-10107-opacbookbag-shouldn-t-prevent... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10107 --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #4)
Tomas: Via this report I connect to the encoding stuff: Search for something with diacritics. Try to add it to a list with bookbag disabled. You will see a mangled search expression without results and no item added.
Bug 10114 is created for this new bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10107 MJ Ray (software.coop) <mjr@software.coop> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17665|0 |1 is obsolete| | --- Comment #8 from MJ Ray (software.coop) <mjr@software.coop> --- Created attachment 17675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17675&action=edit Bug 10107 - opacbookbag shouldn't prevent from adding items to a list in the OPAC This bug is present in master and (at least 3.8.x, where we spotted it). The patch makes adding items, to a list from the results page, not rely only on opacbookbag syspref but also 'virtualshelves'. Regards To+ PS: Thanks Graciela Galli for reporting. Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Template only patch, works nicely. Test plan copied from bug report: - Disable the opacbookbag syspref - Login in the OPAC - Create a list (I tested a private one) - Search in your db for some biblios. - Choose some and add them to the created list - Go to your users's page, to the my lists tab - Your list is empty. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10107 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17675|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10107 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17665|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10107 --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I cannot reproduce this problem. Is there anything else I might need to know? However, when I disable the opacbookbag syspref all the other javascript on the page breaks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10107 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I did my test in CCSR and it worked like described. There was still a [News list] link in the dropdown on top of the result list, but if you clicked on it, nothing happened. After applying the patch and reloading the patch the normal popup came up and it worked nicely. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10107 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. I was unable to replicate the problem, but this patch did not make things worse for me and fixed things for others so I have pushed anyway. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10107 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17729&action=edit Bug 10107 - opacbookbag shouldn't prevent from adding items to a list in the OPAC This bug is present in master and (at least 3.8.x, where we spotted it). The patch makes adding items, to a list from the results page, not rely only on opacbookbag syspref but also 'virtualshelves'. Regards To+ PS: Thanks Graciela Galli for reporting. Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Template only patch, works nicely. Test plan copied from bug report: - Disable the opacbookbag syspref - Login in the OPAC - Create a list (I tested a private one) - Search in your db for some biblios. - Choose some and add them to the created list - Go to your users's page, to the my lists tab - Your list is empty. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10107 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17729|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10107 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.6 and 3.8.13 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10107 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org