[Bug 16589] New: Quote of the day: Can not upload csv file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589 Bug ID: 16589 Summary: Quote of the day: Can not upload csv file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org Upload a valid CSV file to QOD results in error message. Uploads limited to csv. Incorrect filetype: application/vnd.sun.xml.calc Tested with a valid sample file from Bug 15684 - Fix encoding issues with quote upload https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47405 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16513 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I've tried my own CSV file and those on Bug 15684 and I get no errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589 --- Comment #2 from Marc Véron <veron@veron.ch> --- (In reply to Owen Leonard from comment #1)
I've tried my own CSV file and those on Bug 15684 and I get no errors.
I think the issue is related to the fact that on my computer .csv files are associated with LibreOffice (Calc): application/vnd.sun.xml.calc See koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes-upload.tt line 241: if (!fileType.match(/comma-separated-values|csv|excel/i)) { alert(_("Uploads limited to csv. Incorrect filetype: %s").format(fileType)); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Quote of the day: Can not |Quote of the day: Fix |upload csv file |upload with csv files | |associated to LibreOffice | |Calc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 51892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51892&action=edit Bug 16589 - Quote of the day: Fix upload with csv files associated to LibreOffice Calc To reproduce: - Install LibreOffice and make sure that csv files are associated to Calc (Note: tested with Firefox 46.0.1 on Windows 8) - Go to Home > Tools > Quote editor > Quote uploader - Try to upload a valid CSV (e.g. Example from Bug 15684) Result: File can not be uploaded (Incorrect filetype: application/vnd.sun.xml.calc) To test: - Apply patch - Try to upload again Expected result: Quotes are imported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51892|0 |1 is obsolete| | --- Comment #4 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 51894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51894&action=edit Bug 16589 - Quote of the day: Fix upload with csv files associated to LibreOffice Calc To reproduce: - Install LibreOffice and make sure that csv files are associated to Calc (Note: tested with Firefox 46.0.1 on Windows 8) - Go to Home > Tools > Quote editor > Quote uploader - Try to upload a valid CSV (e.g. Example from Bug 15684) Result: File can not be uploaded (Incorrect filetype: application/vnd.sun.xml.calc) To test: - Apply patch - Try to upload again Expected result: Quotes are imported. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Can't reproduce on a Mac but get it fails on a Windows Box: fixed with this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Looks good but I cannot recreate the issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51894|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52244&action=edit Bug 16589 - Quote of the day: Fix upload with csv files associated to LibreOffice Calc To reproduce: - Install LibreOffice and make sure that csv files are associated to Calc (Note: tested with Firefox 46.0.1 on Windows 8) - Go to Home > Tools > Quote editor > Quote uploader - Try to upload a valid CSV (e.g. Example from Bug 15684) Result: File can not be uploaded (Incorrect filetype: application/vnd.sun.xml.calc) To test: - Apply patch - Try to upload again Expected result: Quotes are imported. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Can't reproduce on a Mac but get it fails on a Windows Box: fixed with this patch. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Can't recreate on debian but the fix looks safe. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for Koha 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.01. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 53129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53129&action=edit Bug 16859: Fix wrong item field name in export.pl Field callnumber should be itemcallnumber. For completeness, prefixing the joined fields with items table prefix. Note: You should expect Tools/Export to export only the items within a given itemcallnumber range, but if the biblio has one item in that range, the biblionumber is selected for export with ALL items. The script is designed that way (first select biblio numbers based on criteria, and run export with those biblio numbers). Test plan: [1] Select a biblio N with one item with say itemcallnumber X. [2] Goto Tools/Export. Select biblio range N,N and no itemcallnumber range. The biblio should be exported. [3] Select biblio range N,N and itemcallnumber range A,B. No output. [4] Select biblio range N,N and itemcallnumber range A,<empty>. Output. [5] Select biblio range N,N and itemcallnumber range <empty>,X. Output. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53129|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Comment on attachment 53129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53129 Bug 16859: Fix wrong item field name in export.pl Sorry, wrong bug number.. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org