[Bug 16682] New: Batch patron modification tool should not allow selection of empty patron lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 Bug ID: 16682 Summary: Batch patron modification tool should not allow selection of empty patron lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1 - create a patron list with no patrons 2 - Go to Tools->Batch patron modification 3 - Select that empty list 4 - Stare blankly at a blank screen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #1 from Marc Véron <veron@veron.ch> --- You get the same result if you simply do not fill any of "Use a file", "Or use a patron list", "Or list card numbers...". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Batch patron modification |Fix display if Batch patron |tool should not allow |modification tool does not |selection of empty patron |get any patrons |lists | Assignee|gmcharlt@gmail.com |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- Changed Bug title to reflect all of the cases (see comment #1) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 53149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53149&action=edit Bug 16682 - Fix display if Batch patron modification tool does not get any patrons To reproduce: - Go to Tools->Batch patron modification - Submit without filling any of "Use a file", "Or use a patron list", "Or list card numbers..." or use a patron lists with zero members Result: Screen without any information To test: - Apply patch - Repeat steps above - Verify that you get a nice message -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan@catalyst.net.nz --- Comment #4 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- I think this needs an additional level of indentation, and maybe a comment at the [% END %] , just to mark what is being closed, because it is far away. Also, I prefer [% IF something %] [% ELSE %] rather than [% IF !something %] [% ELSE %], but that's not that important. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 --- Comment #5 from Marc Véron <veron@veron.ch> --- (In reply to Srdjan Jankovic from comment #4)
I think this needs an additional level of indentation, and maybe a comment at the [% END %] , just to mark what is being closed, because it is far away. Also, I prefer [% IF something %] [% ELSE %] rather than [% IF !something %] [% ELSE %], but that's not that important.
Hi Srdjan, thanks for testing. I'll change the strategy for this, patch follows. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 53163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53163&action=edit Bug 16682: Fix display if Batch patron modification tool does not get any patrons To reproduce: - Go to Tools->Batch patron modification - Submit without filling any of "Use a file", "Or use a patron list", "Or list card numbers..." or use a patron lists with zero members Result: Screen without any information To test: - Apply patch - Repeat steps above - Verify that you get a nice message - Verify that the tool works as before - with invalid card numbers only - with valid and invalid card numbers - with valid card numbers only -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53149|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53163|0 |1 is obsolete| | --- Comment #7 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 53211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53211&action=edit [SIGNED-OFF] Bug 16682: Fix display if Batch patron modification tool does not get any patrons To reproduce: - Go to Tools->Batch patron modification - Submit without filling any of "Use a file", "Or use a patron list", "Or list card numbers..." or use a patron lists with zero members Result: Screen without any information To test: - Apply patch - Repeat steps above - Verify that you get a nice message - Verify that the tool works as before - with invalid card numbers only - with valid and invalid card numbers - with valid card numbers only Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- I think the message should follow the pattern used when you try to delete a currency which is in use. Something like this: <h1>Batch patrons modification</h1> <div class="dialog alert"> <p>No patron card numbers given.</p> <form action="/cgi-bin/koha/tools/modborrowers.pl" method="get"> <button type="submit" class="approve"><i class="fa fa-fw fa-check"></i> OK</button> </form> </div> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 --- Comment #9 from Marc Véron <veron@veron.ch> --- Created attachment 53235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53235&action=edit Bug 16682: (followup) Fix display if Batch patron modification tool does not get any patrons Format message as proposed in comment #8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53211|0 |1 is obsolete| | Attachment #53235|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53236&action=edit Bug 16682: Fix display if Batch patron modification tool does not get any patrons To reproduce: - Go to Tools->Batch patron modification - Submit without filling any of "Use a file", "Or use a patron list", "Or list card numbers..." or use a patron lists with zero members Result: Screen without any information To test: - Apply patch - Repeat steps above - Verify that you get a nice message - Verify that the tool works as before - with invalid card numbers only - with valid and invalid card numbers - with valid card numbers only Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53237&action=edit Bug 16682: (followup) Fix display if Batch patron modification tool does not get any patrons Format message as proposed in comment #8 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #13 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org