http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Bug ID: 13731 Summary: Suggestions reason Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org When you, as librarian make decisions about purchase suggestions, you can choose one of the SUGGEST authorized value, which describes, why do you decide this way. But, unfortunetely, this reason isn't presented anywhere, it looks like it isn't saved into database either... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- When viewing accepted suggestions in the staff client you should see a "status" column which includes the reason which was specified when the suggestion was accepted. The information is stored in the "reason" column in the suggestions table. Are you not seeing it like that, or are you expecting it to display somewhere else? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- I can't see it anywhere... and in the database, in table suggestions, i have just NULL value in column reason in every row. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen and Josef, I just tested this after some weirdness seen in training. I can confirm the problem: It's not really a display problem, but if you accept/reject a suggestion right now, the reason doesn't seem to get saved into the suggestion at all :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I did a git bisect as I couldn't spot the problem right away, it points to: 1c2744a83f99027386f9409ad43e725707ae45f8 is the first bad commit commit 1c2744a83f99027386f9409ad43e725707ae45f8 Author: Yohann Dufour <dufour.yohann@gmail.com> Date: Fri Aug 8 15:11:18 2014 +0200 Bug 12627: SQLHelper replacement - C4::Suggestions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- ... I fail to spot the problem, could someone else please take a look? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Suggestions reason |Suggestions reason doesn't | |save -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12627 CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36119&action=edit Bug 13731: Suggestions reason does not save on updating the status On the suggestion list view, if you set a status, it won't be saved. Test plan: 1/ Create a suggestion 2/ Go on the suggestion list view (suggestion/suggestion.pl) 3/ Select a suggestion and marked it as "rejected" (or the status you want) and choose a reason 4/ Save 5/ Browse you suggestions DB table (using your favorite MySQL CLI) and verify that the "reason" field is correctly filled. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 36140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36140&action=edit [Signed-off] Bug 13731: Suggestions reason does not save on updating the status On the suggestion list view, if you set a status, it won't be saved. Test plan: 1/ Create a suggestion 2/ Go on the suggestion list view (suggestion/suggestion.pl) 3/ Select a suggestion and marked it as "rejected" (or the status you want) and choose a reason 4/ Save 5/ Browse you suggestions DB table (using your favorite MySQL CLI) and verify that the "reason" field is correctly filled. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Attachment #36119|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36140|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 36281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36281&action=edit [PASSED QA] Bug 13731: Suggestions reason does not save on updating the status On the suggestion list view, if you set a status, it won't be saved. Test plan: 1/ Create a suggestion 2/ Go on the suggestion list view (suggestion/suggestion.pl) 3/ Select a suggestion and marked it as "rejected" (or the status you want) and choose a reason 4/ Save 5/ Browse you suggestions DB table (using your favorite MySQL CLI) and verify that the "reason" field is correctly filled. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as expected, thx! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj@kohaaloha.com --- Comment #11 from Mason James <mtj@kohaaloha.com> --- Possible selection for 3.16.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | --- Comment #12 from Mason James <mtj@kohaaloha.com> --- (In reply to Mason James from comment #11)
Possible selection for 3.16.x
bug does not exist in 3.16.9 - so skipping patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Bug 13731 depends on bug 12627, which changed state. Bug 12627 Summary: SQLHelper replacement - C4::Suggestions http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org