[Bug 19474] New: Convert staff client CSS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Bug ID: 19474 Summary: Convert staff client CSS to SCSS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org I propose a new workflow for handling CSS in the staff client based on the work in Bug 15522 which adds a client-side asset processing workflow. My patch will be designed to work independently from that bug but use the same framework so that the two can be merged easily. - Uses yarn (https://yarnpkg.com) to manage installation of npm dependencies - Uses gulp (https://gulpjs.com) to process client-side assets. In this case, conversion of SCSS to CSS, auto-prefixing of CSS, minification of CSS. This patch will add a configuration file for sass-lint (https://github.com/sasstools/sass-lint) to help standardize how we write SCSS. The version I'm working with is pretty much the default, and I hope it won't be controversial. I'm using this configuration file in conjunction with my editor's linting plugin. We might later plug sass-lint into the gulp build process. The patch will include a conversion of staff-global.css to SCSS and remove staff-global.css from git. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 68211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68211&action=edit Bug 19474: Convert staff client CSS to SCSS This patch converts staff-global.css to Sass, using SCSS syntax. This changes the build process for Koha to include installation and execution of yarn to install npm dependencies and run SCSS -> CSS conversion. To test, apply the patch and run the following: $ sudo apt-get install nodejs npm [not necessary in kohadevbox] $ sudo npm install -g yarn $ yarn install $ yarn build Clear your browser cache if necessary and confirm that CSS styling throughout the staff client looks correct. The "yarn build" command triggers a gulp process which compiles SCSS to CSS, adds automatic vendor-prefixing, and minifies the resulting CSS file. There is also a "yarn css" command available which might be used by developers who are making changes to SCSS. This command does two things differently: 1. Adds .css.map files which aid CSS debugging using in-browser inspector tools. 2. Compiles staff-global.css without minification. It can be useful to see unminified CSS during development, especially to see how SCSS compiles. This patch adds a configuration file for sass-lint, .sass-lint.yml. Currently this configuration is not used during the build process but can be used in a code editor which supports linting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Note to testers: The qa tools gave me a fail for .sass-lint.yml ("YAML Error: Invalid element in map"), but using web-based YAML linter returned no errors. Not sure what's going on there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #2)
Note to testers: The qa tools gave me a fail for .sass-lint.yml ("YAML Error: Invalid element in map"), but using web-based YAML linter returned no errors. Not sure what's going on there.
The script executes YAML::LoadFile($filepath) and displays the lines containing "YAML error". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Another note to testers: If you are using the included sass-lint configuration to lint the new scss file, it's not perfect. I've tried to make a good first pass as properly nesting staff-global.css, but there are many cases where I'm not sure using strict SCSS syntax results in more efficient output than the non-nested version. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dilan@calyx.net.au --- Comment #5 from Dilan Johnpullé <dilan@calyx.net.au> --- Patch fails to apply in devbox. The following is from my terminal. vagrant@kohadevbox:kohaclone((dafb678...))$ git bz apply -s 19474 Bug 19474 - Convert staff client CSS to SCSS 68211 - Bug 19474: Convert staff client CSS to SCSS Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 19474: Convert staff client CSS to SCSS Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/css/staff-global.css Falling back to patching base and 3-way merge... CONFLICT (modify/delete): koha-tmpl/intranet-tmpl/prog/css/staff-global.css deleted in Bug 19474: Convert staff client CSS to SCSS and modified in HEAD. Version HEAD of koha-tmpl/intranet-tmpl/prog/css/staff-global.css left in tree. Failed to merge in the changes. Patch failed at 0001 Bug 19474: Convert staff client CSS to SCSS The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-19474-Convert-staff-client-CSS-to-SCSS-bSMH6p.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- This patch deletes staff-global.css, assuming that staff-global.css should be generated from the SCSS file. Since commits have been made to stafff-global.css in the meantime, it creates a conflict. I will submit follow-ups to catch up with master, but I think this could be properly tested by resolving the conflict manually. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69197&action=edit Bug 19474 [follow-up] Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically ILL module styles. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70315&action=edit Bug 19474 (Follow-up) Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically staff client responsiveness improvements (Bug 19851). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68211|0 |1 is obsolete| | Attachment #69197|0 |1 is obsolete| | Attachment #70315|0 |1 is obsolete| | --- Comment #9 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 70915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70915&action=edit [SIGNED-OFF] Bug 19474: Convert staff client CSS to SCSS This patch converts staff-global.css to Sass, using SCSS syntax. This changes the build process for Koha to include installation and execution of yarn to install npm dependencies and run SCSS -> CSS conversion. To test, apply the patch and run the following: $ sudo apt-get install nodejs npm [not necessary in kohadevbox] $ sudo npm install -g yarn $ yarn install $ yarn build Clear your browser cache if necessary and confirm that CSS styling throughout the staff client looks correct. The "yarn build" command triggers a gulp process which compiles SCSS to CSS, adds automatic vendor-prefixing, and minifies the resulting CSS file. There is also a "yarn css" command available which might be used by developers who are making changes to SCSS. This command does two things differently: 1. Adds .css.map files which aid CSS debugging using in-browser inspector tools. 2. Compiles staff-global.css without minification. It can be useful to see unminified CSS during development, especially to see how SCSS compiles. This patch adds a configuration file for sass-lint, .sass-lint.yml. Currently this configuration is not used during the build process but can be used in a code editor which supports linting. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #10 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 70916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70916&action=edit [SIGNED-OFF] Bug 19474 [follow-up] Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically ILL module styles. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #11 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 70917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70917&action=edit [SIGNED-OFF] Bug 19474 (Follow-up) Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically staff client responsiveness improvements (Bug 19851). Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70915|0 |1 is obsolete| | Attachment #70916|0 |1 is obsolete| | Attachment #70917|0 |1 is obsolete| | --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 70944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70944&action=edit Bug 19474: Convert staff client CSS to SCSS This patch converts staff-global.css to Sass, using SCSS syntax. This changes the build process for Koha to include installation and execution of yarn to install npm dependencies and run SCSS -> CSS conversion. To test, apply the patch and run the following: $ sudo apt-get install nodejs npm [not necessary in kohadevbox] $ sudo npm install -g yarn $ yarn install $ yarn build Clear your browser cache if necessary and confirm that CSS styling throughout the staff client looks correct. The "yarn build" command triggers a gulp process which compiles SCSS to CSS, adds automatic vendor-prefixing, and minifies the resulting CSS file. There is also a "yarn css" command available which might be used by developers who are making changes to SCSS. This command does two things differently: 1. Adds .css.map files which aid CSS debugging using in-browser inspector tools. 2. Compiles staff-global.css without minification. It can be useful to see unminified CSS during development, especially to see how SCSS compiles. This patch adds a configuration file for sass-lint, .sass-lint.yml. Currently this configuration is not used during the build process but can be used in a code editor which supports linting. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #13 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 70945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70945&action=edit Bug 19474: (follow-up) Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically ILL module styles. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #14 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 70946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70946&action=edit Bug 19474: (follow-up) Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically staff client responsiveness improvements (Bug 19851). Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #15 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 70947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70947&action=edit Bug 19474: (QA follow-up) Fix sass lint yaml configuration Test plan: QA tools should report green on the .sass-lint.yml file now Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Noticing this is PQA :) Should we prepare a wiki page with instructions to go with it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70944|0 |1 is obsolete| | Attachment #70945|0 |1 is obsolete| | Attachment #70946|0 |1 is obsolete| | Attachment #70947|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71055&action=edit Bug 19474: Convert staff client CSS to SCSS This patch converts staff-global.css to Sass, using SCSS syntax. This changes the build process for Koha to include installation and execution of yarn to install npm dependencies and run SCSS -> CSS conversion. To test, apply the patch and run the following: $ sudo apt-get install nodejs npm [not necessary in kohadevbox] $ sudo npm install -g yarn $ yarn install $ yarn build Clear your browser cache if necessary and confirm that CSS styling throughout the staff client looks correct. The "yarn build" command triggers a gulp process which compiles SCSS to CSS, adds automatic vendor-prefixing, and minifies the resulting CSS file. There is also a "yarn css" command available which might be used by developers who are making changes to SCSS. This command does two things differently: 1. Adds .css.map files which aid CSS debugging using in-browser inspector tools. 2. Compiles staff-global.css without minification. It can be useful to see unminified CSS during development, especially to see how SCSS compiles. This patch adds a configuration file for sass-lint, .sass-lint.yml. Currently this configuration is not used during the build process but can be used in a code editor which supports linting. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71055|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71056&action=edit Bug 19474: Convert staff client CSS to SCSS This patch converts staff-global.css to Sass, using SCSS syntax. This changes the build process for Koha to include installation and execution of yarn to install npm dependencies and run SCSS -> CSS conversion. To test, apply the patch and run the following: $ sudo apt-get install nodejs npm [not necessary in kohadevbox] $ sudo npm install -g yarn $ yarn install $ yarn build Clear your browser cache if necessary and confirm that CSS styling throughout the staff client looks correct. The "yarn build" command triggers a gulp process which compiles SCSS to CSS, adds automatic vendor-prefixing, and minifies the resulting CSS file. There is also a "yarn css" command available which might be used by developers who are making changes to SCSS. This command does two things differently: 1. Adds .css.map files which aid CSS debugging using in-browser inspector tools. 2. Compiles staff-global.css without minification. It can be useful to see unminified CSS during development, especially to see how SCSS compiles. This patch adds a configuration file for sass-lint, .sass-lint.yml. Currently this configuration is not used during the build process but can be used in a code editor which supports linting. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71057&action=edit Bug 19474: (follow-up) Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically ILL module styles. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71058&action=edit Bug 19474: (follow-up) Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically staff client responsiveness improvements (Bug 19851). Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71059&action=edit Bug 19474: (QA follow-up) Fix sass lint yaml configuration Test plan: QA tools should report green on the .sass-lint.yml file now Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #16)
Noticing this is PQA :) Should we prepare a wiki page with instructions to go with it?
Yes, that seems like an excellent idea. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #23 from Owen Leonard <oleonard@myacpl.org> --- https://wiki.koha-community.org/wiki/Working_with_staff_client_SCSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- .gitignore is not tracked yet, so I get: error: The following untracked working tree files would be overwritten by merge: .gitignore Please move or remove them before you merge. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #24)
.gitignore is not tracked yet, so I get:
error: The following untracked working tree files would be overwritten by merge: .gitignore Please move or remove them before you merge.
Sounds like you added your own .gitignore file. Just remove it and everything should apply just fine. You could add a followup to merge the two versions if what you have in yours would be generally useful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I thought it was not a good idea to commit the .gitignore file, but actually it does. .git/info/exclude must be used for local modifications. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Did we discuss and vote this change in a dev meeting or the mailing list (I do not find track of that)? I do not understand why the .css is no longer part of the codebase. Do not you think RM should generate it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #28 from Owen Leonard <oleonard@myacpl.org> --- I think most of the discussion so far centered around a different bug, Bug 15522. We discussed the idea of implementing this kind of workflow on the mailing list here: http://lists.koha-community.org/pipermail/koha-devel/2017-August/043910.html ...and during a dev meeting: http://meetings.koha-community.org/2017/development_irc_meeting_9_august_201... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #27)
I do not understand why the .css is no longer part of the codebase. Do not you think RM should generate it?
? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71056|0 |1 is obsolete| | --- Comment #30 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 71609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71609&action=edit Bug 19474: Convert staff client CSS to SCSS This patch converts staff-global.css to Sass, using SCSS syntax. This changes the build process for Koha to include installation and execution of yarn to install npm dependencies and run SCSS -> CSS conversion. To test, apply the patch and run the following: $ sudo apt-get install nodejs npm [not necessary in kohadevbox] $ sudo npm install -g yarn $ yarn install $ yarn build Clear your browser cache if necessary and confirm that CSS styling throughout the staff client looks correct. The "yarn build" command triggers a gulp process which compiles SCSS to CSS, adds automatic vendor-prefixing, and minifies the resulting CSS file. There is also a "yarn css" command available which might be used by developers who are making changes to SCSS. This command does two things differently: 1. Adds .css.map files which aid CSS debugging using in-browser inspector tools. 2. Compiles staff-global.css without minification. It can be useful to see unminified CSS during development, especially to see how SCSS compiles. This patch adds a configuration file for sass-lint, .sass-lint.yml. Currently this configuration is not used during the build process but can be used in a code editor which supports linting. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71057|0 |1 is obsolete| | Attachment #71058|0 |1 is obsolete| | --- Comment #31 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 71610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71610&action=edit Bug 19474: (follow-up) Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically ILL module styles. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #32 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 71611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71611&action=edit Bug 19474: (follow-up) Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically staff client responsiveness improvements (Bug 19851). Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71059|0 |1 is obsolete| | --- Comment #33 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 71612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71612&action=edit Bug 19474: (QA follow-up) Fix sass lint yaml configuration Test plan: QA tools should report green on the .sass-lint.yml file now Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #34 from Owen Leonard <oleonard@myacpl.org> --- I've modified the first patch in two ways: 1. staff-global.css now remains in git 2. .gitignore no longer ignores staff-global.css QA team: Should I seek another signoff? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #35 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 71616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71616&action=edit Bug 19474: (follow-up) Catch up with changes to staff-global.css This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css: - Bug 15707: (QA follow-up) Fix UI issues - Bug 20135: Prevent staff client language choose pop-up from appearing off-screen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20217 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 [Bug 20217] Make header's catalog search menu into a split button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #36 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 72444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72444&action=edit Bug 19474 (follow-up) Catch up with changes to CSS from Bug 19981 This patch brings staff-global.scss up to date with changes made in Bug 19981. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72444|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #37 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 72643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72643&action=edit Bug 19474: (follow-up) Catch up with changes to CSS from Bug 19981 This patch brings staff-global.scss up to date with changes made in Bug 19981. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72643|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #38 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 72677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72677&action=edit Bug 19474: (follow-up) Catch up with changes to CSS from Bug 19981 This patch brings staff-global.scss up to date with changes made in Bug 19981. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71616|0 |1 is obsolete| | Attachment #72677|0 |1 is obsolete| | --- Comment #39 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 72684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72684&action=edit Bug 19474: (follow-up) Catch up with changes to staff-global.css This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css: - Bug 15707: (QA follow-up) Fix UI issues - Bug 20135: Prevent staff client language choose pop-up from appearing off-screen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #40 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 72685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72685&action=edit Bug 19474: (follow-up) Catch up with changes to CSS from Bug 19981 This patch brings staff-global.scss up to date with changes made in Bug 19981. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72684|0 |1 is obsolete| | --- Comment #41 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 72686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72686&action=edit Bug 19474: (follow-up) Catch up with changes to staff-global.css This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css: - Bug 15707: (QA follow-up) Fix UI issues - Bug 20135: Prevent staff client language choose pop-up from appearing off-screen Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71609|0 |1 is obsolete| | Attachment #71610|0 |1 is obsolete| | Attachment #71611|0 |1 is obsolete| | Attachment #71612|0 |1 is obsolete| | Attachment #72685|0 |1 is obsolete| | Attachment #72686|0 |1 is obsolete| | --- Comment #42 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 72776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72776&action=edit Bug 19474: Convert staff client CSS to SCSS This patch converts staff-global.css to Sass, using SCSS syntax. This changes the build process for Koha to include installation and execution of yarn to install npm dependencies and run SCSS -> CSS conversion. To test, apply the patch and run the following: $ sudo apt-get install nodejs npm [not necessary in kohadevbox] $ sudo npm install -g yarn $ yarn install $ yarn build Clear your browser cache if necessary and confirm that CSS styling throughout the staff client looks correct. The "yarn build" command triggers a gulp process which compiles SCSS to CSS, adds automatic vendor-prefixing, and minifies the resulting CSS file. There is also a "yarn css" command available which might be used by developers who are making changes to SCSS. This command does two things differently: 1. Adds .css.map files which aid CSS debugging using in-browser inspector tools. 2. Compiles staff-global.css without minification. It can be useful to see unminified CSS during development, especially to see how SCSS compiles. This patch adds a configuration file for sass-lint, .sass-lint.yml. Currently this configuration is not used during the build process but can be used in a code editor which supports linting. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #43 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 72777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72777&action=edit Bug 19474: (QA follow-up) Fix sass lint yaml configuration Test plan: QA tools should report green on the .sass-lint.yml file now Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #44 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 72778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72778&action=edit Bug 19474 (follow-up) Compiled CSS This patch includes the compiled CSS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72776|0 |1 is obsolete| | --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 72788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72788&action=edit Bug 19474: Convert staff client CSS to SCSS This patch converts staff-global.css to Sass, using SCSS syntax. This changes the build process for Koha to include installation and execution of yarn to install npm dependencies and run SCSS -> CSS conversion. To test, apply the patch and run the following: $ sudo apt-get install nodejs npm [not necessary in kohadevbox] $ sudo npm install -g yarn $ yarn install $ yarn build Clear your browser cache if necessary and confirm that CSS styling throughout the staff client looks correct. The "yarn build" command triggers a gulp process which compiles SCSS to CSS, adds automatic vendor-prefixing, and minifies the resulting CSS file. There is also a "yarn css" command available which might be used by developers who are making changes to SCSS. This command does two things differently: 1. Adds .css.map files which aid CSS debugging using in-browser inspector tools. 2. Compiles staff-global.css without minification. It can be useful to see unminified CSS during development, especially to see how SCSS compiles. This patch adds a configuration file for sass-lint, .sass-lint.yml. Currently this configuration is not used during the build process but can be used in a code editor which supports linting. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72777|0 |1 is obsolete| | --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 72789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72789&action=edit Bug 19474: (QA follow-up) Fix sass lint yaml configuration Test plan: QA tools should report green on the .sass-lint.yml file now Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72778|0 |1 is obsolete| | --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 72790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72790&action=edit Bug 19474 (follow-up) Compiled CSS This patch includes the compiled CSS. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72790|0 |1 is obsolete| | --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 72791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72791&action=edit Bug 19474: (follow-up) Compiled CSS This patch includes the compiled CSS. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20427 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20427 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20427 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20427 [Bug 20427] Convert OPAC LESS to SCSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20329 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72788|0 |1 is obsolete| | --- Comment #49 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 73470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73470&action=edit Bug 19474: Convert staff client CSS to SCSS This patch converts staff-global.css to Sass, using SCSS syntax. This changes the build process for Koha to include installation and execution of yarn to install npm dependencies and run SCSS -> CSS conversion. To test, apply the patch and run the following: $ sudo apt-get install nodejs npm [not necessary in kohadevbox] $ sudo npm install -g yarn $ yarn install $ yarn build Clear your browser cache if necessary and confirm that CSS styling throughout the staff client looks correct. The "yarn build" command triggers a gulp process which compiles SCSS to CSS, adds automatic vendor-prefixing, and minifies the resulting CSS file. There is also a "yarn css" command available which might be used by developers who are making changes to SCSS. This command does two things differently: 1. Adds .css.map files which aid CSS debugging using in-browser inspector tools. 2. Compiles staff-global.css without minification. It can be useful to see unminified CSS during development, especially to see how SCSS compiles. This patch adds a configuration file for sass-lint, .sass-lint.yml. Currently this configuration is not used during the build process but can be used in a code editor which supports linting. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72789|0 |1 is obsolete| | --- Comment #50 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 73471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73471&action=edit Bug 19474: (QA follow-up) Fix sass lint yaml configuration Test plan: QA tools should report green on the .sass-lint.yml file now Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72791|0 |1 is obsolete| | --- Comment #51 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 73472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73472&action=edit Bug 19474 (follow-up) Compiled CSS This patch includes the compiled CSS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #52 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Could we imagine to have a staff-global.css and staff-global.min.css It would depend on the dev_install config flag, devs will use .css whereas production installations will use .min.css The .min.css would be generated only on releasing (and will avoid to pollute the git log). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://wiki.koha-community | |.org/wiki/Working_with_staf | |f_client_SCSS --- Comment #53 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Owen, could you add, on the wiki page, a list of the files bug 19474 and bug 20427 are going to add to our codebase? And tell what is the purpose in front each one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed, | |rel_18_05_candidate --- Comment #54 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We should also update https://wiki.koha-community.org/wiki/Working_with_Bootstrap_OPAC_LESS_files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73472|0 |1 is obsolete| | --- Comment #55 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 74724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74724&action=edit Bug 19474: (follow-up) Bring scss up to date with latest CSS changes This patch catches the scss up to the latest changes in master: Bug 19946, Bug 20045, Bug 20343, Bug 18327, Bug 20322, and Bug 18799 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #56 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 74725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74725&action=edit Bug 19474: (follow-up) Compiled CSS This patch includes the compiled CSS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74724|0 |1 is obsolete| | Attachment #74725|0 |1 is obsolete| | --- Comment #57 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 74757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74757&action=edit Bug 19474: (follow-up) Bring scss up to date with latest CSS changes This patch catches the scss up to the latest changes in master: Bug 19946, Bug 20045, Bug 20343, Bug 18327, Bug 20322, Bug 18799, and Bug 20622. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #58 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 74758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74758&action=edit Bug 19474: (follow-up) Compiled CSS This patch includes the compiled CSS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #59 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am stuck here and I need help: https://framabin.org/?92fc14016eb1b26b#Ign1IDycTejFZj7suueyIXO/wEy2wFB13hxbq... I changed .scss file and `yarn build` or `yarn css` does not update .css files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed, | |rel_18_05_candidate | --- Comment #60 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This will not be part of 18.05 unfortunately. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74757|0 |1 is obsolete| | Attachment #74758|0 |1 is obsolete| | --- Comment #61 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 76657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76657&action=edit Bug 19474: (follow-up) Bring scss up to date with latest CSS changes This patch catches the scss up to the latest changes in master: Bug 19946 Bug 20045 Bug 20343 Bug 18327 Bug 20322 Bug 18799 Bug 20622 Bug 20329 Bug 20744 Bug 20931 Bug 20793 Bug 20651 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76657|0 |1 is obsolete| | --- Comment #62 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77189&action=edit Bug 19474: (follow-up) Bring scss up to date with latest CSS changes This patch catches the scss up to the latest changes in master: Bug 19946 Bug 20045 Bug 20343 Bug 18327 Bug 20322 Bug 18799 Bug 20622 Bug 20329 Bug 20744 Bug 20931 Bug 20793 Bug 20651 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #63 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #59)
I am stuck here and I need help: https://framabin.org/?92fc14016eb1b26b#Ign1IDycTejFZj7suueyIXO/ wEy2wFB13hxbqq5Yle0=
I changed .scss file and `yarn build` or `yarn css` does not update .css files.
Retested right now and I do see the expected changes made to koha-tmpl/intranet-tmpl/prog/css/staff-global.css -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #64 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #63)
(In reply to Jonathan Druart from comment #59)
I am stuck here and I need help: https://framabin.org/?92fc14016eb1b26b#Ign1IDycTejFZj7suueyIXO/ wEy2wFB13hxbqq5Yle0=
I changed .scss file and `yarn build` or `yarn css` does not update .css files.
Retested right now and I do see the expected changes made to koha-tmpl/intranet-tmpl/prog/css/staff-global.css
I would like to retest on top of bug 20427 as well (maybe it came from there?), but it does no longer apply. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #65 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #64)
(In reply to Jonathan Druart from comment #63)
(In reply to Jonathan Druart from comment #59)
I am stuck here and I need help: https://framabin.org/?92fc14016eb1b26b#Ign1IDycTejFZj7suueyIXO/ wEy2wFB13hxbqq5Yle0=
I changed .scss file and `yarn build` or `yarn css` does not update .css files.
Retested right now and I do see the expected changes made to koha-tmpl/intranet-tmpl/prog/css/staff-global.css
I would like to retest on top of bug 20427 as well (maybe it came from there?), but it does no longer apply.
Confirmed! The issue still exists for me with bug 20427 applied -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #66 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #65)
(In reply to Jonathan Druart from comment #64)
(In reply to Jonathan Druart from comment #63)
(In reply to Jonathan Druart from comment #59)
I am stuck here and I need help: https://framabin.org/?92fc14016eb1b26b#Ign1IDycTejFZj7suueyIXO/ wEy2wFB13hxbqq5Yle0=
I changed .scss file and `yarn build` or `yarn css` does not update .css files.
Retested right now and I do see the expected changes made to koha-tmpl/intranet-tmpl/prog/css/staff-global.css
I would like to retest on top of bug 20427 as well (maybe it came from there?), but it does no longer apply.
Confirmed! The issue still exists for me with bug 20427 applied
Fixed since patch on bug 20427 comment 13. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77189|0 |1 is obsolete| | --- Comment #67 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77621&action=edit Bug 19474: (follow-up) Bring scss up to date with latest CSS changes This patch catches the scss up to the latest changes in master: Bug 19946 Bug 20045 Bug 20343 Bug 18327 Bug 20322 Bug 18799 Bug 20622 Bug 20329 Bug 20744 Bug 20931 Bug 20793 Bug 20651 Bug 20668 Bug 16575 Bug 19166 Bug 20770 Bug 21163 Bug 20779 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #68 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21195 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21195 [Bug 21195] Makefile.t is failing due to new files for SCSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #69 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, this will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21223 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21223 [Bug 21223] Some floating values are wrong -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21229 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21229 [Bug 21229] Correct nesting and specificity for some button styles -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21237 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21237 [Bug 21237] Clean up staff client SCSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21239 --- Comment #70 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have opened bug 21239 to list the different regressions introduced by this change. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 [Bug 21239] CSS regressions caused by SCSS move -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21363 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21363 [Bug 21363] Unwanted margin between checkout form and last checked out information -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21470 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21470 [Bug 21470] Due date no longer shown in red when viewing checkouts for a patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #71 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Any chance of a short rationale and summary for the release notes for this one Owen? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #72 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 11896 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=1918 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23572 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23572 [Bug 23572] Regression: Bug 18878 - Improve item form display / labels too far from input fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org