[Bug 9997] New: Suspected typo in patron self registration code
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9997 Bug ID: 9997 Summary: Suspected typo in patron self registration code Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com While translating this: %s %s [%% SET field_display_names = { surname => "Surname" firstname => "First name" title => "Title" othernames => "Other names" initials => "Initials" streetnumber => "Street number" streettype => "Street type" address => "Address" address2 => "Address 2" city => "City" state => "State" zipcode => "Zip code" country => "Country" email => "Email" phone => "Primary Phone" mobile => "Primary Mobile Phone" fax => "Fax" emailpro => "Secondary email" phonepro => "Secondary phone" B_streetnumber => "Alternate address - street number" B_streettype => "Alternate address - street type" B_address => "Alternate address" B_address2 => "Alternate address 2" B_city => "Alternate address - city" B_state => "Alternate address - state" B_zipcode => "Alternate address - zip code" B_email => "Alternate address - email" B_phone => "Alertnate address - phone" dateofbirth => "Date of birth" contactname => "Contact - last name" contactfirstname=> "Contact - first name" contacttitle => "Contact - title" relationship => "Contact - relationship" ethnicity => "Ethnicity" ethnotes => "Ethnicity notes" sex => "Sex" altcontactfirstname => "Alternate contact - first name" altcontactsurname => "Alternate contact - surname" altcontactaddress1 => "Alternate contact - address" altcontactaddress2 => "Alternate contact - address 2" altcontactaddress3 => "Alternate contact - city" altcontactstate => "Alternate contact - state" altcontactzipcode => "Alternate contact - zip code" altcontactcounty => "Alternate contact - county" altcontactphone => "Alternate contact - phone" smsalertnumber => "SMS alert number" } %%] I was wondering if altcontactcounty => "Alternate contact - county" shouldn't be country to match the field in the database? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9997 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17290&action=edit Bug 9997 - Suspected typo in patron self registration code String fix. The field name is also incorrect, causing the alternate contact country to not be stored. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9997 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9997 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle.m.hall@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9997 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9997 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9997 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17290|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 17293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17293&action=edit [SIGNED-OFF] Bug 9997 - Suspected typo in patron self registration code String fix. The field name is also incorrect, causing the alternate contact country to not be stored. To test: Submit an update to an existing patron record an include a change to the alternate contact's country field. Before the patch this line would not appear in the staff client for approval. After the patch it should. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Reminder: Even small patches require test plans. I have added one which I think covers the changes in the patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9997 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|String patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9997 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17293|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17324&action=edit [PASSED QA] Bug 9997 - Suspected typo in patron self registration code String fix. The field name is also incorrect, causing the alternate contact country to not be stored. To test: Submit an update to an existing patron record an include a change to the alternate contact's country field. Before the patch this line would not appear in the staff client for approval. After the patch it should. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Reminder: Even small patches require test plans. I have added one which I think covers the changes in the patch. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9997 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org