https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38251 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- You can remove items, what you can't do is remove an item: one fails, two or more works. https://git.koha-community.org/Koha-community/Koha/src/commit/e74f10042d78a9... thinks that if selected_titles.size() == 1 that means you clicked the Remove from this list and it can just stuff the biblionumber in its hidden form and submit that, but biblionumber isn't defined if you checked one checkbox and used Remove selected items. Bonus, in #L967 single_bib is always undefined, it's a Reference error, so no matter what you do and whether it works or not you get a nice JS error in the console. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38251 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37150 Summary|"Remove selected items" |"Remove selected items" |button not removing items |button not removing single |in OPAC lists |item in OPAC lists Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37150 [Bug 37150] Can't delete single title from a list using the "Remove from list" link -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38251 --- Comment #4 from Phil Ringnalda <phil@chetcolibrary.org> --- (In reply to David Cook from comment #2)

I love finding bugs when testing bug fixes for other things... 😭

Oh, like bug 38268? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38251 --- Comment #5 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 173308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173308&action=edit Bug 38251: Make 'Remove selected items' button work when there is one item There are two ways to remove items from a list: you can remove a single item by clicking a 'Remove from this list' button below the item, or you can remove one or more items by checking the checkboxes for them and clicking the 'Remove selected items' button. Bug 37150 needed to fix 'Remove from this list' for CSRF, because in the wild old days it just triggered a GET to delete, and instead it needed to POST. The first patch to do that defined the JS var single_bib, checked the checkbox for that bib and submitted the form, as though you had used the checkbox yourself. But if you cancelled the confirmation prompt, it would need to uncheck the checkbox it checked, so it added a function to do that if (single_bib). That patch didn't land. What landed instead was a patch with a separate hidden form that could be populated with the single biblionumber from 'Remove from this list', but without single_bib to define that state, it used selected_titles.size() == 1 as the condition to use the hidden form, forgetting that when the user checks a single checkbox, selected_titles.size() is also 1. The right condition is the same one used to tell where to get the titles for the confirmation dialog: if the click event passed along a biblionumber, it's 'Remove from this list.' Since checking that sets var biblionumber, we can just use that being truthy as the condition. Test plan: 1. Without the patch, open the OPAC and log in 2. Add any two biblios to a new list 3. Lists - {your list name} 4. Click the checkbox for one of the items, click 'Remove selected items' and click 'Yes, remove from list' in the confirmation dialog 5. Note that it wasn't removed 6. Click the checkboxes for both items, click 'Remove selected items' and click 'Yes, remove from list' in the confirmation dialog 7. Note that both were removed 8. Apply patch, restart_all 9. Add any four items to your list 10. Lists - {your list name} 11. For the first item, click the 'Remove from this list' button below the details for the item, confirm, make sure it was deleted 12. Click the checkbox for what's now the first item, click 'Remove from this list,' confirm, make sure it was deleted 13. Click the checkboxes for what are now the first two items, click 'Remove from this list,' confirm, make sure both were deleted Sponsored-by: Chetco Community Public Library -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38251 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173308|0 |1 is obsolete| | --- Comment #6 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 173411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173411&action=edit Bug 38251: Make 'Remove selected items' button work when there is one item There are two ways to remove items from a list: you can remove a single item by clicking a 'Remove from this list' button below the item, or you can remove one or more items by checking the checkboxes for them and clicking the 'Remove selected items' button. Bug 37150 needed to fix 'Remove from this list' for CSRF, because in the wild old days it just triggered a GET to delete, and instead it needed to POST. The first patch to do that defined the JS var single_bib, checked the checkbox for that bib and submitted the form, as though you had used the checkbox yourself. But if you cancelled the confirmation prompt, it would need to uncheck the checkbox it checked, so it added a function to do that if (single_bib). That patch didn't land. What landed instead was a patch with a separate hidden form that could be populated with the single biblionumber from 'Remove from this list', but without single_bib to define that state, it used selected_titles.size() == 1 as the condition to use the hidden form, forgetting that when the user checks a single checkbox, selected_titles.size() is also 1. The right condition is the same one used to tell where to get the titles for the confirmation dialog: if the click event passed along a biblionumber, it's 'Remove from this list.' Since checking that sets var biblionumber, we can just use that being truthy as the condition. Test plan: 1. Without the patch, open the OPAC and log in 2. Add any two biblios to a new list 3. Lists - {your list name} 4. Click the checkbox for one of the items, click 'Remove selected items' and click 'Yes, remove from list' in the confirmation dialog 5. Note that it wasn't removed 6. Click the checkboxes for both items, click 'Remove selected items' and click 'Yes, remove from list' in the confirmation dialog 7. Note that both were removed 8. Apply patch, restart_all 9. Add any four items to your list 10. Lists - {your list name} 11. For the first item, click the 'Remove from this list' button below the details for the item, confirm, make sure it was deleted 12. Click the checkbox for what's now the first item, click 'Remove from this list,' confirm, make sure it was deleted 13. Click the checkboxes for what are now the first two items, click 'Remove from this list,' confirm, make sure both were deleted Sponsored-by: Chetco Community Public Library Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38251 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38251 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38251 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38251 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #11 from Phil Ringnalda <phil@chetcolibrary.org> --- Since there's no documentation of the temporary bug, no need to document it being gone. -- You are receiving this mail because: You are watching all bug changes.