[Bug 32350] New: Should we die if TestBuilder is passed a column we're not expecting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Bug ID: 32350 Summary: Should we die if TestBuilder is passed a column we're not expecting Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144229&action=edit Bug 32350: Die on unrecognised column passed to testbuilder This should prevent mis-matches between tests and database fields in the future and reduce our chances of hitting random test failures. However, it may have a performance impact on the test suite. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Is this a crazy idea of worthwhile.. I can't make up my mind.. It would have helped prevent the series of bugs Jonathan is now working through after the boolean fix.. I think. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144229|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144230&action=edit Bug 32350: Die on unrecognised column passed to testbuilder This should prevent mis-matches between tests and database fields in the future and reduce our chances of hitting random test failures. However, it may have a performance impact on the test suite. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- [09:35] <marcelr> ashimema: you should do the check in build not in build_object [09:35] <marcelr> we are using build too still [09:35] <marcelr> and build_object calls bild [09:35] <marcelr> build -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I would have used Array::List::intersect -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #5)
I would have used Array::List::intersect
In _buildColumnValues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #4)
[09:35] <marcelr> ashimema: you should do the check in build not in build_object [09:35] <marcelr> we are using build too still [09:35] <marcelr> and build_object calls bild [09:35] <marcelr> build
Nonsense, sorry -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- diff --git a/t/lib/TestBuilder.pm b/t/lib/TestBuilder.pm index d065835ded0..d9e48b45c54 100644 --- a/t/lib/TestBuilder.pm +++ b/t/lib/TestBuilder.pm @@ -8,6 +8,7 @@ use Koha::Biblios qw( _type ); use Koha::Items qw( _type ); use Koha::DateUtils qw( dt_from_string ); +use Array::Utils qw( intersect ); use Bytes::Random::Secure; use Carp qw( carp ); use Module::Load qw( load ); @@ -280,6 +281,9 @@ sub _buildColumnValues { my @columns = $self->schema->source($source)->columns; my %unique_constraints = $self->schema->source($source)->unique_constraints(); + my @intersect = intersect( keys %$original_value, @columns ); + die Dumper @intersect if @intersect; + my $build_value = 5; # we try max $build_value times if there are unique constraints BUILD_VALUE: while ( $build_value ) { -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Something in the lines, with a good die message :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32343 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Needs a bit more logic for the "FK hashes" in value. On it now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #8)
+ my @intersect = intersect( keys %$original_value, @columns ); + die Dumper @intersect if @intersect; +
No intersect. Wrong logic. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144230|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 144233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144233&action=edit Bug 32350: Die on unrecognised column passed to testbuilder This should prevent mis-matches between tests and database fields in the future and reduce our chances of hitting random test failures. However, it may have a performance impact on the test suite. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 144234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144234&action=edit Bug 32350: Use array_minus and ignore nesting Note: Test will be extended in follow-up. This fixes the module_bit hash to follow the FK path from user_permissions to permissions to userflags. One step was missed in the existing test, although it did not fail. The change here revealed that now. Test plan: Run t/db_dependent/TestBuilder.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 144235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144235&action=edit Bug 32350: Add subtest for bad columns Test plan: Run t/db_dependent/TestBuilder.t And now run the whole test suite :) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- t/db_dependent/Koha/Holds.t ................... 6/10 # No tests run! # Failed test 'No tests run for subtest "Test Koha::Hold::item_group"' # at t/db_dependent/Koha/Holds.t line 669. Error: value hash contains unrecognized columns: biblionumber at /usr/share/koha/t/lib/TestBuilder.pm line 287. # Looks like your test exited with 255 just after 8. t/db_dependent/Koha/Holds.t ................... Dubious, test returned 255 (wstat 65280, 0xff00) Failed 3/10 subtests First hit in t/db../Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- t/db_dependent/Koha/Patron.t .................. 6/19 # No tests run! # Failed test 'No tests run for subtest "unique attributes tests"' # at t/db_dependent/Koha/Patron.t line 593. # Looks like you planned 16 tests but ran 13. # Looks like you failed 1 test of 13 run. t/db_dependent/Koha/Patron.t .................. 7/19 # Failed test 'extended_attributes' # at t/db_dependent/Koha/Patron.t line 727. Error: value hash contains unrecognized columns: unique at /usr/share/koha/t/lib/TestBuilder.pm line 287. # Looks like your test exited with 255 just after 7. t/db_dependent/Koha/Patron.t .................. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 13/19 subtests t/db_dependent/Koha/Patrons.t ................. 1/44 # Looks like you planned 9 tests but ran 4. t/db_dependent/Koha/Patrons.t ................. 5/44 # Failed test 'guarantees' # at t/db_dependent/Koha/Patrons.t line 235. Error: value hash contains unrecognized columns: guarantorid at /usr/share/koha/t/lib/TestBuilder.pm line 287. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize@ptfs-europe |m.de.rooy@rijksmuseum.nl |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Here are few more from t/db.. in root dir ./Acquisition.t ........................... 63/71 # Failed test 'No tests run for subtest "ModReceiveOrder replacementprice tests"' # at ./Acquisition.t line 748. Error: value hash contains unrecognized columns: booksellerid at /usr/share/koha/t/lib/TestBuilder.pm line 287. ./Budgets.t ............................... 105/154 # No tests run! # Failed test 'No tests run for subtest "GetBudgetSpent and GetBudgetOrdered and GetBudgetHierarchy shipping and adjustments"' # at ./Budgets.t line 1039. Error: value hash contains unrecognized columns: budget_total at /usr/share/koha/t/lib/TestBuilder.pm line 287. ./Circulation.t ........................... 33/64 # No tests run! # Failed test 'No tests run for subtest "CanBookBeIssued + AutoReturnCheckedOutItems"' # at ./Circulation.t line 2895. Error: value hash contains unrecognized columns: library at /usr/share/koha/t/lib/TestBuilder.pm line 287. ./Illrequests.t ........................... 9/15 # No tests run! # Failed test 'No tests run for subtest "Checking out"' # at ./Illrequests.t line 1312. Error: value hash contains unrecognized columns: category_type at /usr/share/koha/t/lib/TestBuilder.pm line 287. ./Members.t ............................... 43/54 # Looks like you planned 8 tests but ran 5. ./Members.t ............................... 53/54 # Failed test 'purgeSelfRegistration' # at ./Members.t line 470. Error: value hash contains unrecognized columns: acocunttype at /usr/share/koha/t/lib/TestBuilder.pm line 287. ./Reserves.t .............................. 72/77 # Looks like you planned 2 tests but ran 1. # Failed test 'IsAvailableForItemLevelRequest() tests' # at ./Reserves.t line 1475. Error: value hash contains unrecognized columns: notloan at /usr/share/koha/t/lib/TestBuilder.pm line 287. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Not sure if following are related. I missed Test::DBIx::Class. Skipped selenium and www. ./Holds.t ................................. 76/76 # Looks like you failed 2 tests of 76. ./Search.t (Wstat: 65280 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 255 Parse errors: Bad plan. You planned 3 tests but ran 1. ./Sitemapper.t (Wstat: 512 Tests: 2 Failed: 0) Non-zero exit status: 2 Parse errors: Bad plan. You planned 16 tests but ran 2. ./Suggestions.t (Wstat: 256 Tests: 91 Failed: 1) Failed test: 89 Non-zero exit status: 1 ./check_sysprefs.t (Wstat: 256 Tests: 795 Failed: 1) Failed test: 294 Non-zero exit status: 1 ./yaml.t (Wstat: 1024 Tests: 4 Failed: 4) Failed tests: 1-4 Non-zero exit status: 4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I think it makes sense to fix those tests on follow-up reports. And push when it looks like we are green ;) Will fix some now on a follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32351 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351 [Bug 32351] Fix TestBuilder calls in Koha/Holds.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #19)
I think it makes sense to fix those tests on follow-up reports. And push when it looks like we are green ;) Will fix some now on a follow-up.
Probably better to fix them all on 32351 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144235|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 144239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144239&action=edit Bug 32350: Add subtest for bad columns Test plan: Run t/db_dependent/TestBuilder.t And now run the whole test suite :) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Couldnt live with it: - value => { surname => 'Pass', categorycode => { description => 'bla', wrong_nested => 1 }}, + value => { surname => 'WontPass', categorycode => { description => 'bla', wrong_nested => 1 }}, -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144233|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144245&action=edit Bug 32350: Die on unrecognised column passed to testbuilder This should prevent mis-matches between tests and database fields in the future and reduce our chances of hitting random test failures. However, it may have a performance impact on the test suite. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144234|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144246&action=edit Bug 32350: Use array_minus and ignore nesting Note: Test will be extended in follow-up. This fixes the module_bit hash to follow the FK path from user_permissions to permissions to userflags. One step was missed in the existing test, although it did not fail. The change here revealed that now. Test plan: Run t/db_dependent/TestBuilder.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144239|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144247&action=edit Bug 32350: Add subtest for bad columns Test plan: Run t/db_dependent/TestBuilder.t And now run the whole test suite :) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144248&action=edit Bug 32350: (follow-up) Remove List::Util import We replaced it with Array::Utils -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Should we die if |We should die if |TestBuilder is passed a |TestBuilder is passed a |column we're not expecting |column we're not expecting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great teamwork here :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- First and last patches are useless, can we remove them? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #28)
First and last patches are useless, can we remove them?
You're welcome to do it in the QA step :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144245|0 |1 is obsolete| | Attachment #144246|0 |1 is obsolete| | Attachment #144247|0 |1 is obsolete| | Attachment #144248|0 |1 is obsolete| | --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 144276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144276&action=edit Bug 32350: Use array_minus and ignore nesting Note: Test will be extended in follow-up. This fixes the module_bit hash to follow the FK path from user_permissions to permissions to userflags. One step was missed in the existing test, although it did not fail. The change here revealed that now. Test plan: Run t/db_dependent/TestBuilder.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 144277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144277&action=edit Bug 32350: Add subtest for bad columns Test plan: Run t/db_dependent/TestBuilder.t And now run the whole test suite :) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #32 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #28)
First and last patches are useless, can we remove them?
So I did now, making Martin loose his attribution. One of the reasons why I didnt do it in the first place.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144276|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144277|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #33 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144349&action=edit Bug 32350: Use array_minus and ignore nesting Note: Test will be extended in follow-up. This fixes the module_bit hash to follow the FK path from user_permissions to permissions to userflags. One step was missed in the existing test, although it did not fail. The change here revealed that now. Test plan: Run t/db_dependent/TestBuilder.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #34 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144350&action=edit Bug 32350: Add subtest for bad columns Test plan: Run t/db_dependent/TestBuilder.t And now run the whole test suite :) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #35 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 --- Comment #36 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Bad timing for BZ to be down. I pushed this to see what happens on jenkins, then I'll move to bug 32351 so we chase all the problems. Thanks everyone. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00, 22.11.01 released in| | --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks everyone, pushing to 22.11.x for 22.11.01. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org