[Bug 31619] New: Cannot select title when setting non-default value for OPACSuggestionMandatoryFields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 Bug ID: 31619 Summary: Cannot select title when setting non-default value for OPACSuggestionMandatoryFields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: gmcharlt@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Possibly because of a timing issue when the patches for bug 29695 were merged, "title" is no longer listed as an option on the value list for OPACSuggestionMandatoryFields. As a consequence, if that system preference is set to any non-default value, it becomes impossible to have the title field be mandatory on the OPAC purchase suggestion form. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Keywords| |regression -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 --- Comment #1 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 140963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140963&action=edit Bug 31619: add title back to list of OPACSuggestionMandatoryFields options This patch fixes a regression introduced by bug 29695 that prevented setting the title as a required field when setting the OPACSuggestionMandatoryFields to a non-default value. To test: [1] Set OPACSuggestionMandatoryFields in the system preferences editor and note that 'title' is not listed in the modal that is displayed. [2] Apply the patch. [3] Revist the system preference editor and note that 'title' is now displayed as an option. Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- The patch adds the title to the list of fields and is in red, however it can't be made optional - that is, it is still mandatory. Happy to sign off if this is what is intended. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> --- I confirm that that is intended behavior - see commit 432f296b965 for bug 26296. (Also, with the possible exception of asking the library to buy a piece of equipment, most anything a patron would ask a library to purchase would have a title at minimum.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 --- Comment #4 from David Nind <david@davidnind.com> --- (In reply to Galen Charlton from comment #3)
I confirm that that is intended behavior - see commit 432f296b965 for bug 26296. (Also, with the possible exception of asking the library to buy a piece of equipment, most anything a patron would ask a library to purchase would have a title at minimum.)
Thanks Galen for clarifying. Sign off on the way! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140963|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 141039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141039&action=edit Bug 31619: add title back to list of OPACSuggestionMandatoryFields options This patch fixes a regression introduced by bug 29695 that prevented setting the title as a required field when setting the OPACSuggestionMandatoryFields to a non-default value. To test: [1] Set OPACSuggestionMandatoryFields in the system preferences editor and note that 'title' is not listed in the modal that is displayed. [2] Apply the patch. [3] Revist the system preference editor and note that 'title' is now displayed as an option. Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the release notes| |OPACSuggestionMandatoryFiel | |ds system preference so | |that the title field is | |visible and marked as | |mandatory (in red). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Thanks for your patch, Galen. Note that title does not belong to biblioitems, but to biblio. And that the pref explains that title is always mandatory and therefore not listed. You cannot deselect it. So we either skip this change or move the explanation to the popup form somehow? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Marcel de Rooy from comment #6)
Thanks for your patch, Galen. Note that title does not belong to biblioitems, but to biblio.
The patch adds an entry for "title" as a column in the suggestions table, not biblio nor biblioitems.
And that the pref explains that title is always mandatory and therefore not listed. You cannot deselect it. So we either skip this change or move the explanation to the popup form somehow?
Without the patch, any attempt to change the value of OPACSuggestionMandatoryFields to a non-default value will cause the title to not be marked as required; the "title" field is not permanently considered required by the code that reads the value of the system preference unless that preference value is blank. Setting status back to signed off and requesting re-review. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |gmcharlt@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Galen Charlton from comment #7)
The patch adds an entry for "title" as a column in the suggestions table, not biblio nor biblioitems.
Ah, you are right. I just stumbled over an earlier occurrence in the wrong place (i.e. biblioitems). Sorry for that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141039|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 141478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141478&action=edit Bug 31619: add title back to list of OPACSuggestionMandatoryFields options This patch fixes a regression introduced by bug 29695 that prevented setting the title as a required field when setting the OPACSuggestionMandatoryFields to a non-default value. To test: [1] Set OPACSuggestionMandatoryFields in the system preferences editor and note that 'title' is not listed in the modal that is displayed. [2] Apply the patch. [3] Revist the system preference editor and note that 'title' is now displayed as an option. Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Gotta say... I'm really happy to push a patch from you, Galen :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.08 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |arthur.suzuki@biblibre.com Resolution|--- |FIXED --- Comment #13 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Koha/Database/Columns.pm doesn't exist on 21.11. Patch doesn't apply here (not needed most probably) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org