[Bug 24197] New: Custom destination for failed overdue notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Bug ID: 24197 Summary: Custom destination for failed overdue notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Notices Assignee: alexbuckley@catalyst.net.nz Reporter: alexbuckley@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Currently failed overdue notices are sent to the branch email , or when that is not set to the KohaAdminEmailAddress syspref. Several of our clients have requested a seperate email address for failed overdue notices to be sent to. This email address will be defined in the: RedirectAddressForFailedOverdueNotices syspref. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 96123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96123&action=edit Bug 24197: Added new local use syspref which sets the email address that failed overdue notices are set to. Test plan: 1. Set an email in KohaAdminEmailAddress and notice there is no syspref named RedirectAddressForFailedOverdueNotices 2. Set some invalid email addresses in patron records then checkout items to those patrons making the due date in the past 3. Manually run overdue_notices.pl 4. Check the message_queue database table and notice the patrons with invalid email addresses are in an email starting with the content: 'These messages were not sent directly to the patrons.' 5. Apply patch 6. Run database update: cd installer/data/mysql sudo koha-shell <instance_name> ./updatedb.pl 7. Confirm there is a new system preference named: RedirectAddressForFailedOverdueNotices Give it a different email address to that in the KohaAdminEmailAddress syspref. 7. Repeat steps 2-4 and notice that the failed overdue notices have been sent to the email defined in RedirectAddressForFailedOverdueNotices Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96123|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 96124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96124&action=edit Bug 24197: Added new local use syspref which sets the email address that failed overdue notices are set to. Test plan: 1. Set an email in KohaAdminEmailAddress and notice there is no syspref named RedirectAddressForFailedOverdueNotices 2. Set some invalid email addresses in patron records then checkout items to those patrons making the due date in the past 3. Manually run overdue_notices.pl 4. Check the message_queue database table and notice the patrons with invalid email addresses are in an email starting with the content: 'These messages were not sent directly to the patrons.' 5. Apply patch 6. Run database update: cd installer/data/mysql sudo koha-shell <instance_name> ./updatedb.pl 7. Confirm there is a new system preference named: RedirectAddressForFailedOverdueNotices Give it a different email address to that in the KohaAdminEmailAddress syspref. 7. Repeat steps 2-4 and notice that the failed overdue notices have been sent to the email defined in RedirectAddressForFailedOverdueNotices Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96124|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 96125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96125&action=edit Bug 24197: Added new local use syspref which sets the email address that failed overdue notices are set to. Test plan: 1. Set an email in KohaAdminEmailAddress and notice there is no syspref named RedirectAddressForFailedOverdueNotices 2. Set some invalid email addresses in patron records then checkout items to those patrons making the due date in the past 3. Manually run overdue_notices.pl 4. Check the message_queue database table and notice the patrons with invalid email addresses are in an email starting with the content: 'These messages were not sent directly to the patrons.' 5. Apply patch 6. Run database update: cd installer/data/mysql sudo koha-shell <instance_name> ./updatedb.pl 7. Confirm there is a new system preference named: RedirectAddressForFailedOverdueNotices Give it a different email address to that in the KohaAdminEmailAddress syspref. 7. Repeat steps 2-4 and notice that the failed overdue notices have been sent to the email defined in RedirectAddressForFailedOverdueNotices Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_candidate CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Thanks for tagging this 20.05 candidate Martin, I've just applying the patch and it doesn't apply on master. Attaching a corrected patch now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96125|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 --- Comment #5 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 103428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103428&action=edit Bug 24197: Added new local use syspref which sets the email address that failed overdue notices are set to. Test plan: 1. Set no email addresses in patron record then checkout items to the patron making the due date in the past 2. Visit patron's home library page: Administration > Libraries Set a branch email and in global system preferences observe there is no syspref named RedirectAddressForFailedOverdueNotices 3. Manually run overdue_notices.pl 4. Check the message_queue database table and observe there is a print overdue notice and a email notice with to_address of the branch email address 5. Apply patch 6. Run database update: cd installer/data/mysql sudo koha-shell <instance_name> ./updatedb.pl 7. Confirm there is a new system preference named: RedirectAddressForFailedOverdueNotices Give it a different email address to that in the branch email. 7. Repeat steps 1,3,4 and observe that the failed overdue notices have been sent to the email defined in RedirectAddressForFailedOverdueNotices Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 --- Comment #6 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 103429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103429&action=edit Bug 24197: Changed use of 'branch' terminology to 'library' Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 --- Comment #7 from Alex Buckley <alexbuckley@catalyst.net.nz> --- All ready to test :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103428|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 103465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103465&action=edit Bug 24197: Added new local use syspref which sets the email address that failed overdue notices are set to. Test plan: 1. Set no email addresses in patron record then checkout items to the patron making the due date in the past 2. Visit patron's home library page: Administration > Libraries Set a branch email and in global system preferences observe there is no syspref named RedirectAddressForFailedOverdueNotices 3. Manually run overdue_notices.pl 4. Check the message_queue database table and observe there is a print overdue notice and a email notice with to_address of the branch email address 5. Apply patch 6. Run database update: cd installer/data/mysql sudo koha-shell <instance_name> ./updatedb.pl 7. Confirm there is a new system preference named: RedirectAddressForFailedOverdueNotices Give it a different email address to that in the branch email. 7. Repeat steps 1,3,4 and observe that the failed overdue notices have been sent to the email defined in RedirectAddressForFailedOverdueNotices Sponsored-By: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103429|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 103466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103466&action=edit Bug 24197: Changed use of 'branch' terminology to 'library' Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected, passes QA scripts.. Signing Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_candidate |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The preference description is not correct for libraries using the *replyto functionality to avoid having the emails marked as spam. See here: - my $branch_email_address = $library->inbound_email_address; + my $branch_email_address = C4::Context->preference('RedirectAddressForFailedOverdueNotices') + || $library->inbound_email_address; The inbound_email_address is not the KohaAdminEmailAdress or branchemail in htese cases. Can you please check and adapt the wording? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103465|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109549&action=edit Bug 24197: Added new local use syspref which sets the email address that failed overdue notices are set to. Test plan: 1. Set no email addresses in patron record then checkout items to the patron making the due date in the past 2. Visit patron's home library page: Administration > Libraries Set a branch email and in global system preferences observe there is no syspref named RedirectAddressForFailedOverdueNotices 3. Manually run overdue_notices.pl 4. Check the message_queue database table and observe there is a print overdue notice and a email notice with to_address of the branch email address 5. Apply patch 6. Run database update: cd installer/data/mysql sudo koha-shell <instance_name> ./updatedb.pl 7. Confirm there is a new system preference named: RedirectAddressForFailedOverdueNotices Give it a different email address to that in the branch email. 7. Repeat steps 1,3,4 and observe that the failed overdue notices have been sent to the email defined in RedirectAddressForFailedOverdueNotices Sponsored-By: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103466|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109550&action=edit Bug 24197: Changed use of 'branch' terminology to 'library' Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109551&action=edit Bug 24197: (QA follow-up) Embelished syspref description As requested, I have embelished the syspref description to more accurately depict the fallback sequence for email delivery. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit | |y.org | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Patch rescued, ready for second QA run. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109549|0 |1 is obsolete| | --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 109552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109552&action=edit Bug 24197: Added new local use syspref which sets the email address that failed overdue notices are set to. Test plan: 1. Set no email addresses in patron record then checkout items to the patron making the due date in the past 2. Visit patron's home library page: Administration > Libraries Set a branch email and in global system preferences observe there is no syspref named RedirectAddressForFailedOverdueNotices 3. Manually run overdue_notices.pl 4. Check the message_queue database table and observe there is a print overdue notice and a email notice with to_address of the branch email address 5. Apply patch 6. Run database update: cd installer/data/mysql sudo koha-shell <instance_name> ./updatedb.pl 7. Confirm there is a new system preference named: RedirectAddressForFailedOverdueNotices Give it a different email address to that in the branch email. 7. Repeat steps 1,3,4 and observe that the failed overdue notices have been sent to the email defined in RedirectAddressForFailedOverdueNotices Sponsored-By: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109550|0 |1 is obsolete| | --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 109553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109553&action=edit Bug 24197: Changed use of 'branch' terminology to 'library' Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109551|0 |1 is obsolete| | --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 109554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109554&action=edit Bug 24197: (QA follow-up) Embelished syspref description As requested, I have embelished the syspref description to more accurately depict the fallback sequence for email delivery. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 109555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109555&action=edit Bug 24197: (QA follow-up) Shorten syspref name to AddressForFailedEmailNotices If you define the address we use it, if not we fallback, it's not really a redirect, and that just makes the name longer. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Last patch can be accepted or ignored, just trying to keep pref names under control :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Not blocker but: shouldn't have it been defined at library level instead? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #21)
Not blocker but: shouldn't have it been defined at library level instead?
I did wonder that myself when testing, but then decided that we have a pattern of introducing a system level default and then enhancing later with library level refinement if it proves useful. I'm still keen to overhaul how library emails get associated at some point but didn't think that should hold this piece up either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26380 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26380 [Bug 26380] Add RedirectAddressForFailedOverdueNotices option on library level -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #24 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This adds a new system release notes| |preference | |AddressForFailedEmailNotice | |s that allows to control | |where the summarized | |overdue email for patrons | |without email addresses is | |sent to. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Niamh Walker-Headon <Niamh.WalkerHeadon@hse.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Niamh.WalkerHeadon@hse.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #25 from David Cook <dcook@prosentient.com.au> --- It seems too bad this wasn't done for all emails and not just overdue emails... -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org