[Bug 9476] New: Use Datatables on Koha news page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9476 Bug ID: 9476 Summary: Use Datatables on Koha news page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/koha-news.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The Koha news page uses the old tablesorter plugin. It should use the DataTables plugin instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9476 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9476 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14806&action=edit Bug 9476 - Use Datatables on Koha news page Replace the tablesorter plugin with the DataTables plugin on the Koha news page. To test, open the Koha news page (Tools -> News). Confirm that table sorting works correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9476 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gmcharlt@gmail.com --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> --- Patch doesn't apply to master -- please rebase and resubmit. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9476 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9476 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14806|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15099&action=edit Bug 9476 - Use Datatables on Koha news page Replace the tablesorter plugin with the DataTables plugin on the Koha news page. To test, open the Koha news page (Tools -> News). Confirm that table sorting works correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9476 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- With the revised patch, I get the following error: Template process failed: file error - parse error - /home/gmc/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt line 202: unexpected end of input at /home/gmc/koha/C4/Templates.pm line 132. Looks like the "[% IF ( opac_news_count ) %]" introduced by the patch isn't closed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9476 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9476 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9476 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15099|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15109&action=edit Bug 9476 [Revised] Use Datatables on Koha news page Replace the tablesorter plugin with the DataTables plugin on the Koha news page. To test, open the Koha news page (Tools -> News). Confirm that table sorting works correctly. Revision corrects merge error after rebase. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9476 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9476 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15109|0 |1 is obsolete| | --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 15113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15113&action=edit Bug 9476: Use Datatables on Koha news page Replace the tablesorter plugin with the DataTables plugin on the Koha news page. To test, open the Koha news page (Tools -> News). Confirm that table sorting works correctly. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9476 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Replace tablesorter with datatable on the koha-news tool page. Works great. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9476 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15113|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15131&action=edit Bug 9476: Use Datatables on Koha news page Replace the tablesorter plugin with the DataTables plugin on the Koha news page. To test, open the Koha news page (Tools -> News). Confirm that table sorting works correctly. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9476 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org