[Bug 32627] New: Reprinting holds slips should not reset the expiration date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 Bug ID: 32627 Summary: Reprinting holds slips should not reset the expiration date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: Laura.escamilla@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Occasionally, the slips in items waiting on the holds shelf tend to get pulled out. When this happens, library staff check in items to reprint the slips. Previous to the latest upgrade the holds expiration date would remain the same, but now the expiration date is being calculated based on the NEW date the item is checked in. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |emily.lamancusa@montgomeryc |ity.org |ountymd.gov -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 --- Comment #1 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 149130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149130&action=edit Bug 32627: Calculate expirationdate relative to waitingdate Hold::set_waiting should calculate the MaxPickupDelay expiration date based on waitingdate rather than the current date, to avoid resetting the expirationdate on a hold that was already waiting. To test: 1. Place a hold and check in the item so the hold will be set to Waiting 2. Confirm that the expiration date is correct based on the ReservesMaxPickupDelay setting 3. Adjust your system clock to one day later 4. Check in the item again and confirm the hold 5. Note that the expiration date has changed 7. Apply patch and restart_all 8. Repeat steps 1-4. Confirm that the expiration date is calculated correctly, and does not change when the item is checked in again 9. Reset your system clock to the current date 10. Set ExcludeHolidaysFromMaxPickupDelay to Use the Calendar 11. Add an upcoming holiday to the calendar 12. Repeat steps 1-4. Confirm the expiration date correctly accounts for the holiday, and does not change when the item is checked in again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149130|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 149148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149148&action=edit Bug 32627: Calculate expirationdate relative to waitingdate Hold::set_waiting should calculate the MaxPickupDelay expiration date based on waitingdate rather than the current date, to avoid resetting the expirationdate on a hold that was already waiting. To test: 1. Place a hold and check in the item so the hold will be set to Waiting 2. Confirm that the expiration date is correct based on the ReservesMaxPickupDelay setting 3. Adjust your system clock to one day later 4. Check in the item again and confirm the hold 5. Note that the expiration date has changed 7. Apply patch and restart_all 8. Repeat steps 1-4. Confirm that the expiration date is calculated correctly, and does not change when the item is checked in again 9. Reset your system clock to the current date 10. Set ExcludeHolidaysFromMaxPickupDelay to Use the Calendar 11. Add an upcoming holiday to the calendar 12. Repeat steps 1-4. Confirm the expiration date correctly accounts for the holiday, and does not change when the item is checked in again Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149148|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 149245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149245&action=edit Bug 32627: Calculate expirationdate relative to waitingdate Hold::set_waiting should calculate the MaxPickupDelay expiration date based on waitingdate rather than the current date, to avoid resetting the expirationdate on a hold that was already waiting. To test: 1. Place a hold and check in the item so the hold will be set to Waiting 2. Confirm that the expiration date is correct based on the ReservesMaxPickupDelay setting 3. Adjust your system clock to one day later 4. Check in the item again and confirm the hold 5. Note that the expiration date has changed 7. Apply patch and restart_all 8. Repeat steps 1-4. Confirm that the expiration date is calculated correctly, and does not change when the item is checked in again 9. Reset your system clock to the current date 10. Set ExcludeHolidaysFromMaxPickupDelay to Use the Calendar 11. Add an upcoming holiday to the calendar 12. Repeat steps 1-4. Confirm the expiration date correctly accounts for the holiday, and does not change when the item is checked in again Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149245|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 150403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150403&action=edit Bug 32627: Calculate expirationdate relative to waitingdate Hold::set_waiting should calculate the MaxPickupDelay expiration date based on waitingdate rather than the current date, to avoid resetting the expirationdate on a hold that was already waiting. To test: 1. Place a hold and check in the item so the hold will be set to Waiting 2. Confirm that the expiration date is correct based on the ReservesMaxPickupDelay setting 3. Adjust your system clock to one day later 4. Check in the item again and confirm the hold 5. Note that the expiration date has changed 7. Apply patch and restart_all 8. Repeat steps 1-4. Confirm that the expiration date is calculated correctly, and does not change when the item is checked in again 9. Reset your system clock to the current date 10. Set ExcludeHolidaysFromMaxPickupDelay to Use the Calendar 11. Add an upcoming holiday to the calendar 12. Repeat steps 1-4. Confirm the expiration date correctly accounts for the holiday, and does not change when the item is checked in again Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.14 released in| | CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 Danyon Sewell <danyonsewell@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |danyonsewell@catalyst.net.n | |z Resolution|--- |FIXED --- Comment #8 from Danyon Sewell <danyonsewell@catalyst.net.nz> --- Not backporting for 21.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 Dave <ddaghita@mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ddaghita@mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 --- Comment #9 from Dave <ddaghita@mckinneytexas.org> --- did this get backported to 22.11,08, noticed issue after Labor day when reprinting slips. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Dave from comment #9)
did this get backported to 22.11,08, noticed issue after Labor day when reprinting slips.
Hi Dave, if you scroll to the top there is the field: Version(s) released in. This fix was in 22.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 --- Comment #11 from Dave <ddaghita@mckinneytexas.org> --- (In reply to Katrin Fischer from comment #10)
(In reply to Dave from comment #9)
did this get backported to 22.11,08, noticed issue after Labor day when reprinting slips.
Hi Dave, if you scroll to the top there is the field: Version(s) released in. This fix was in 22.11.06
Hi Katrin, Thank you, I overlooked that field. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org