https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37845 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 171201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171201&action=edit Bug 37845: Remove C4::Members::DeleteExpiredOpacRegistrations This patch remove the subroutine C4::Members::DeleteExpiredOpacRegistrations. The code is moved and adjusted to Koha::Patrons. We now have 2 new methods: Koha::Patrons->filter_by_expired_opac_registrations Koha::Patrons->filter_by_safe_to_delete Test plan: Run the misc/cronjobs/cleanup_database.pl script with the Improve the output of the verbose mode Tell if the something is wrong in the config (syspref not set) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37845 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37844 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37844 [Bug 37844] Remove C4::Members::DeleteUnverifiedOpacRegistrations -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37845 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171201|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 171202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171202&action=edit Bug 37845: Remove C4::Members::DeleteExpiredOpacRegistrations This patch remove the subroutine C4::Members::DeleteExpiredOpacRegistrations. The code is moved and adjusted to Koha::Patrons. We now have 2 new methods: Koha::Patrons->filter_by_expired_opac_registrations Koha::Patrons->filter_by_safe_to_delete Test plan: Run the misc/cronjobs/cleanup_database.pl script with the --del-exp-selfreg (as well as --verbose and --confirm) and confirm that it behaves as expected Note that it improve the output of the verbose mode and now tell if the something is wrong with the config (syspref not set) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37845 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #2)

Test plan: Run the misc/cronjobs/cleanup_database.pl script with the --del-exp-selfreg (as well as --verbose and --confirm) and confirm that it behaves as expected

I should have noted that there is a behaviour change here. Prior to this patch we only tested if the patron had checkouts and an account balance. Now we are relying on Koha::Patron->safe_to_delete that is doing much more tests (not anonymous patron, not protected, not a guarantor). That should not happen for self registration entries anyway, but this is a better test IMO. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37845 Sukhmandeep <sukhmandeep.benipal@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171202|0 |1 is obsolete| | --- Comment #4 from Sukhmandeep <sukhmandeep.benipal@inLibro.com> --- Created attachment 171999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171999&action=edit Bug 37845: Remove C4::Members::DeleteExpiredOpacRegistrations This patch remove the subroutine C4::Members::DeleteExpiredOpacRegistrations. The code is moved and adjusted to Koha::Patrons. We now have 2 new methods: Koha::Patrons->filter_by_expired_opac_registrations Koha::Patrons->filter_by_safe_to_delete Test plan: Run the misc/cronjobs/cleanup_database.pl script with the --del-exp-selfreg (as well as --verbose and --confirm) and confirm that it behaves as expected Note that it improve the output of the verbose mode and now tell if the something is wrong with the config (syspref not set) Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37845 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37845 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171999|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 172015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172015&action=edit Bug 37845: Remove C4::Members::DeleteExpiredOpacRegistrations This patch remove the subroutine C4::Members::DeleteExpiredOpacRegistrations. The code is moved and adjusted to Koha::Patrons. We now have 2 new methods: Koha::Patrons->filter_by_expired_opac_registrations Koha::Patrons->filter_by_safe_to_delete Test plan: Run the misc/cronjobs/cleanup_database.pl script with the --del-exp-selfreg (as well as --verbose and --confirm) and confirm that it behaves as expected Note that it improve the output of the verbose mode and now tell if the something is wrong with the config (syspref not set) Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37845 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37845 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37845 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to main |RESOLVED --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Enhancement, no 24.05.x backport -- You are receiving this mail because: You are watching all bug changes.