https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32652 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Severity|enhancement |major Depends on| |32111 CC| |jonathan.druart+koha@gmail. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111 [Bug 32111] Cannot schedule a pickup at the OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32652 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 145361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145361&action=edit Bug 32652: Fix curbside pickup if configured on more than 1 branch If curbside pickup is configured on more than 1 branch, the calendar will not display the correct day. We are always selecting the days for the last branch. Test plan: Configure curbside pickup for CPL Monday 8:12 FPL Tuesday 12:15 Login at the opac, select CPL, notice Tuesday are available Apply the patch and confirm all is working correctly now. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32652 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32652 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 42635 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32652 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Comma delimited| |Athens County Public list of Sponsors| |Libraries Status|ASSIGNED |Needs Signoff Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32652 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #145361|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32652 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199292|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32652

--- Comment #5 from David Nind <david@davidnind.com> ---
Created attachment 199513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199513&action=edit
Screenshots - Before and after patch

Before and after screenshots for OPAC and the staff interface (in a PDF).

Testing notes (using KTD) - setting up curbside bookings:
1. Enable curbside pickup: set CurbsidePickup to "Enable"
2. Go to Administration > Patrons and circulation > Curbside pickup
3. Select one library and configure curbside pickup:
   - Centerville
     . Enable: select
     . Pickup interval: 5
     . Maximum patrons per interval: 2
     . Patron-scheduled pickup: select
     . Curbside pickup hours:
       . Add slots for each day from 08:00 to 17:00
4. Repeat for another library, for example: Midway
5. Place some holds for a patron.
   - I used Mary Burton, change username and password so you can log into the
OPAC as the patron, and placed holds on
     . Programming Perl - pickup location Centerville
     . CGI programming with Perl - Pickup location Centerville
     . Programming the Perl DBI  - Pickup location Midway
6. Fulfill the holds by checking in items:
   - With library set to Centerville:
     . 39999000011418
     . 39999000000498
   - With library set to Midway:
     . 39999000000559
7. Before the patch:
   - OPAC:
     . Log into the OPAC as the patron you used
     . Go to the patron's account > Curbside pickups section
     . Click the "Schedule a pickup" tab
     . Pickup library: Centerville
     . Pickup date: select any date
     . Select a time: pick any time for the pickup (highlights the slot you
selected in green)
     . Click "Schedule pickup"
   - Staff interface:
     . Set library to Midway
     . Go to Circulation > Holds and bookings > Curbside pickups
     . Select the schedule pickup tab
     . Enter patron name, for example: Mary
     . Pickup date: select any date
     . Select a time: pick any time for the pickup (highlights the slot you
selected in green)
     . Click Submit
8. After the patch:
   - Cancel any pickups waiting to be staged (Circulation > Holds and bookings
> Curbside pickups > To be staged > click cancel for any to be staged pickups
   - Repeat step 7
   - Note that the select a time now more closely matches the OPAC time
selection
   - For another two patrons place and fulfil the hold (using the same library
as Mary so that there are multiple pickups on the same day and time):
     . Lisa, Effective Perl programming, 39999000005776
     . Bobbie, Perl template toolkit, 39999000011111
   - Repeat step 7 for the staff interface and select the same date
   - Note that when you hover over a full time slot (in a lighter grey) that
the mouse point changes and there is a tool tip

-- 
You are receiving this mail because:
You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32652 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement updates |This enhancement updates release notes|the style of the time |the style of the time |selection controls for |selection controls for |curbside pickups so that it |curbside pickups so that it |more closely matches how |more closely matches the |they are presented in the |OPAC. |OPAC. | | |Changes include: |Changes include: |- The times are now styled |- The times are now styled |as buttons |as buttons |- A check-mark icon is |- A check-mark icon is |shown when a time is |shown when a time is |selected |selected |- There is now a tooltip: |- There is now a tooltip: |"Pickups scheduled: X" |"Pickups scheduled: X" |- The form now uses CSS |- The form now uses CSS |grids |grids | Summary|Standardize slots selection |Match the curbside pickup |between staff interface and |time slots selection for |opac |the staff interface with | |the OPAC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32652 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 202622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202622&action=edit Bug 32652: Standardize slots selection between staff interface and opac This patch updates the style of the time selection controls so that it is clearer that they are elements which the user can interact with. The times are now styled as buttons, and a check-mark icon is added when a time is selected. A tooltip has been added: "Pickups scheduled: X" The patch also updates the form so that it uses CSS grids. To test, apply the patch and enable and configure curbside pickups if necessary. You should have at least two libraries with curbside hours defined. - In the staff interface, go to Circulation -> Curbside pickups. - Switch to the "Schedule pickup" tab and search for a patron. - After selecting a patron, confirm that the pickup entry form looks correct. Try resizing the browser window to confirm that the form fields and the pickup time buttons adapt well to different widths. - When you select a date the time-selection buttons should appear. - Hovering over a time should trigger the "Pickups scheduled" tooltip. - Clicking a time should cause the "button" to turn green with a check-mark icon. - Submit a pickup request and confirm that it is saved correctly. - Switch to the "To be staged" tab to confirm that the pickup has been saved. - Schedule as many pickups in the same time slot as the "Maximum patrons per interval" setting for that location's curbside pickup configuration. - Try to schedule another pickup on that date and confirm that the maxed-out time slot is now shown by a greyed-out and disabled button. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.